)]}'
{"doc/source/configuring.rst":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"b3cabe3141d761343da93b5ef55f87e3ebfb3a6c","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"Presently, the wsgi server allows persist connections. Hence even after the"},{"line_number":1498,"context_line":"response is sent to the client, it does not close the client socket"},{"line_number":1499,"context_line":"connection. Because of this problem, the green thread is not released back to"},{"line_number":1500,"context_line":"the pool. Setting this option to False will prevent avoid this leak happen."},{"line_number":1501,"context_line":"If False, server will return the header \"Connection: close\", If True, server"},{"line_number":1502,"context_line":"will return \"Connection: Keep-Alive\" in its responses. In order to close the"},{"line_number":1503,"context_line":"client socket connection explicitly after the response is sent and read"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_efc69a67","line":1500,"updated":"2015-03-18 10:18:39.000000000","message":"nit: As a non-native English speaker, not sure if one of \u0027prevent\u0027 and \u0027avoid\u0027 is redundant..","commit_id":"0e23969e351f749dce64b94f74e899f934ff5ebc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"642f6d99ef596ce620373ddb7eb9061cf9a3b694","unresolved":false,"context_lines":[{"line_number":1497,"context_line":"Presently, the wsgi server allows persist connections. Hence even after the"},{"line_number":1498,"context_line":"response is sent to the client, it does not close the client socket"},{"line_number":1499,"context_line":"connection. Because of this problem, the green thread is not released back to"},{"line_number":1500,"context_line":"the pool. Setting this option to False will prevent avoid this leak happen."},{"line_number":1501,"context_line":"If False, server will return the header \"Connection: close\", If True, server"},{"line_number":1502,"context_line":"will return \"Connection: Keep-Alive\" in its responses. In order to close the"},{"line_number":1503,"context_line":"client socket connection explicitly after the response is sent and read"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a80dd14_cff1d697","line":1500,"in_reply_to":"9a80dd14_efc69a67","updated":"2015-03-18 10:22:34.000000000","message":"yes it is, my bad","commit_id":"0e23969e351f749dce64b94f74e899f934ff5ebc"}],"glance/common/wsgi.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"f25ceda15e5bd805b295a0b07d7d3f7fee498699","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"},{"line_number":90,"context_line":"                      \u0027large tokens (typically those generated by the \u0027"},{"line_number":91,"context_line":"                      \u0027Keystone v3 API with big service catalogs\u0027)),"},{"line_number":92,"context_line":"    cfg.BoolOpt(\u0027http_keepalive\u0027, default\u003dFalse,"},{"line_number":93,"context_line":"                help\u003d_(\u0027If False, server will return the header \u0027"},{"line_number":94,"context_line":"                       \u0027\"Connection: close\", \u0027"},{"line_number":95,"context_line":"                       \u0027If True, server will return \"Connection: Keep-Alive\" \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e0f15197","line":92,"updated":"2015-03-18 08:17:41.000000000","message":"1. Prefer to mention the reason why False here is useful and reasonable, e.g. \"Presently, the wsgi server allows persist connections. Hence even after the response is sent to the client, it doesn\u0027t close the client socket\nconnection. Because of this problem, the green thread is not released\nback to the pool.\", and set this option to False will prevent avoid this leak happen.\n\n2. Please update template config files: etc/glance-api.conf and etc/glance-registry.conf, and in-tree configuration doc, for the \u0027False\u0027 default value and the reason above #1 point mentioned.","commit_id":"e4faa37a5ffa769f617efc3f1779d3500a18f735"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c11e8920a66c753b177b06bb75a3ef0c1e61e46f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027max_header_line may need to be increased when using \u0027"},{"line_number":90,"context_line":"                      \u0027large tokens (typically those generated by the \u0027"},{"line_number":91,"context_line":"                      \u0027Keystone v3 API with big service catalogs\u0027)),"},{"line_number":92,"context_line":"    cfg.BoolOpt(\u0027http_keepalive\u0027, default\u003dFalse,"},{"line_number":93,"context_line":"                help\u003d_(\u0027If False, server will return the header \u0027"},{"line_number":94,"context_line":"                       \u0027\"Connection: close\", \u0027"},{"line_number":95,"context_line":"                       \u0027If True, server will return \"Connection: Keep-Alive\" \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_5e659a1b","line":92,"in_reply_to":"9a80dd14_e0f15197","updated":"2015-03-18 09:15:37.000000000","message":"Done","commit_id":"e4faa37a5ffa769f617efc3f1779d3500a18f735"}]}