)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a2237b17733ac635ed2b87e41a5a7a64d950ea4d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"registered even if you\u0027re only running one test. When you wish to debug"},{"line_number":11,"context_line":"into your tests and use python -m testtools.run these options will not"},{"line_number":12,"context_line":"be registered."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie3426cee8cd3f6f1222529160d39b281af5ce317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_d96ebf95","line":13,"updated":"2015-03-19 13:34:46.000000000","message":"Missing Closes-Bug tag","commit_id":"473594b3c3a72827a20a07171e09985e5f9d4fda"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"32dc16d6224485bc666d35bfd901d741b4adf3bb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"registered even if you\u0027re only running one test. When you wish to debug"},{"line_number":11,"context_line":"into your tests and use python -m testtools.run these options will not"},{"line_number":12,"context_line":"be registered."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie3426cee8cd3f6f1222529160d39b281af5ce317"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a80dd14_9c25100c","line":13,"in_reply_to":"9a80dd14_d96ebf95","updated":"2015-03-19 15:15:18.000000000","message":"Good catch.\n\nDone","commit_id":"473594b3c3a72827a20a07171e09985e5f9d4fda"}],"glance/tests/utils.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"8ac6d88c291689c9066cef8a76322ed9b5da9cad","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from glance.db.sqlalchemy import api as db_api"},{"line_number":44,"context_line":"from glance.db.sqlalchemy import models as db_models"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"try:"},{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_0937cdb1","line":46,"updated":"2015-03-21 23:13:13.000000000","message":"Why don\u0027t we explicitly do logging.register_options here ? I think this is necessary rather than to rely on some test being loaded to register logging options.","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"bd371e7ce82972613fc28beafcd250ed446d57fa","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from glance.db.sqlalchemy import api as db_api"},{"line_number":44,"context_line":"from glance.db.sqlalchemy import models as db_models"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"try:"},{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_a9f5d9cc","line":46,"in_reply_to":"1a6ced46_0937cdb1","updated":"2015-03-21 23:14:11.000000000","message":"s/logging/log/","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"0f1cb098a527d40e726c363afc7b06d90a67d2c0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from glance.db.sqlalchemy import api as db_api"},{"line_number":44,"context_line":"from glance.db.sqlalchemy import models as db_models"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"try:"},{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_bf5015d5","line":46,"in_reply_to":"1a6ced46_4b7930c7","updated":"2015-03-25 19:39:25.000000000","message":"Man, you are right! I think I didn\u0027t run the whole test suite when I tried explicitly registering log opts. \n\n\nUpon some digging, looks like the console script entry points register logging options in the module thus conflicting with tests\u0027. IIRC, its done during config.parse_args in other projects. Anyway, lots to catch up for me in glance :). Thanks!","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"dca17881fde8d9eadeccb497f6a4d2133c70bd02","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from glance.db.sqlalchemy import api as db_api"},{"line_number":44,"context_line":"from glance.db.sqlalchemy import models as db_models"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"CONF \u003d cfg.CONF"},{"line_number":47,"context_line":"try:"},{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_4b7930c7","line":46,"in_reply_to":"1a6ced46_a9f5d9cc","updated":"2015-03-25 16:04:40.000000000","message":"We don\u0027t do it here because it causes test failures. Please pull down the changes for yourself to see this. I don\u0027t have those logs any longer.","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"c18fa385ca099047a5e5667b4152e6d986af3080","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"},{"line_number":50,"context_line":"    # When running a test in isolation, this is necessary when using a test"},{"line_number":51,"context_line":"    # case class that inherits from BaseTestCase and uses the config method to"},{"line_number":52,"context_line":"    # set the debug level."},{"line_number":53,"context_line":"    # See bug 1433785 for more details."},{"line_number":54,"context_line":"    log.register_options(CONF)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a80dd14_5850c02b","line":51,"updated":"2015-03-20 23:05:28.000000000","message":"Seems like poor clarity in the comment.\n\nIs this comment equivalent to:\n\"When running a test in isolation which inherits from ...\"","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"8303a866d0901dcb4b788eec8d430794aeafc4b9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"},{"line_number":50,"context_line":"    # When running a test in isolation, this is necessary when using a test"},{"line_number":51,"context_line":"    # case class that inherits from BaseTestCase and uses the config method to"},{"line_number":52,"context_line":"    # set the debug level."},{"line_number":53,"context_line":"    # See bug 1433785 for more details."},{"line_number":54,"context_line":"    log.register_options(CONF)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa963961_92403a58","line":51,"in_reply_to":"9a80dd14_5850c02b","updated":"2015-03-27 15:59:07.000000000","message":"Done","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"dca17881fde8d9eadeccb497f6a4d2133c70bd02","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    debug \u003d CONF.debug"},{"line_number":49,"context_line":"except cfg.NoSuchOptError:"},{"line_number":50,"context_line":"    # When running a test in isolation, this is necessary when using a test"},{"line_number":51,"context_line":"    # case class that inherits from BaseTestCase and uses the config method to"},{"line_number":52,"context_line":"    # set the debug level."},{"line_number":53,"context_line":"    # See bug 1433785 for more details."},{"line_number":54,"context_line":"    log.register_options(CONF)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6ced46_2b3f94d7","line":51,"in_reply_to":"9a80dd14_5850c02b","updated":"2015-03-25 16:04:40.000000000","message":"It could use rewording but it\u0027s not exactly equivalent to what you\u0027ve said.","commit_id":"85d6fcdeb00a2aa8fc8da1e070032309d84c46d8"},{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"f5684463add335a7a6e6378a66c3a77d1a8a51eb","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # See bug 1433785 for more details."},{"line_number":59,"context_line":"    log.register_options(CONF)"},{"line_number":60,"context_line":"else:"},{"line_number":61,"context_line":"    del debug"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class BaseTestCase(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aaa499b_c7826600","line":61,"updated":"2015-04-14 11:01:16.000000000","message":"What is the reason for explicitly calling del for debug variable? debug is just a pointer to CONF.debug object. So why not let it remain?","commit_id":"a15cc1bc1640488980461887bd4b05531d5b04ce"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"520629354b2e75329a48f492eaeaf18d0605f770","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # See bug 1433785 for more details."},{"line_number":59,"context_line":"    log.register_options(CONF)"},{"line_number":60,"context_line":"else:"},{"line_number":61,"context_line":"    del debug"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class BaseTestCase(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_b57d451e","line":61,"in_reply_to":"3acd31a7_35d13558","updated":"2015-05-01 21:30:31.000000000","message":"Done","commit_id":"a15cc1bc1640488980461887bd4b05531d5b04ce"},{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"a08223e0e49bfd39c66ae6514530db52cd8ef7c4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # See bug 1433785 for more details."},{"line_number":59,"context_line":"    log.register_options(CONF)"},{"line_number":60,"context_line":"else:"},{"line_number":61,"context_line":"    del debug"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class BaseTestCase(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_5a814ac2","line":61,"in_reply_to":"3acd31a7_35d13558","updated":"2015-05-05 07:02:16.000000000","message":"my bad. I should have said debug is a reference to CONF.debug object.","commit_id":"a15cc1bc1640488980461887bd4b05531d5b04ce"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"9d041dca95b578c2f7983fa1cfe38083be6f19ff","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # See bug 1433785 for more details."},{"line_number":59,"context_line":"    log.register_options(CONF)"},{"line_number":60,"context_line":"else:"},{"line_number":61,"context_line":"    del debug"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class BaseTestCase(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ad32947_1d4d9472","line":61,"in_reply_to":"7aaa499b_c7826600","updated":"2015-04-27 16:08:27.000000000","message":"I\u0027m guessing so it doesn\u0027t stay around globally.\n\nIan, any particular other reason?","commit_id":"a15cc1bc1640488980461887bd4b05531d5b04ce"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"818dc441087b5c6c2b5b37571ffae3a1ea200fb1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # See bug 1433785 for more details."},{"line_number":59,"context_line":"    log.register_options(CONF)"},{"line_number":60,"context_line":"else:"},{"line_number":61,"context_line":"    del debug"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class BaseTestCase(testtools.TestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3acd31a7_35d13558","line":61,"in_reply_to":"7ad32947_1d4d9472","updated":"2015-05-01 21:20:36.000000000","message":"There\u0027s no reason for it to stick around globally. To reduce the noise/confusion this seems to have caused we could rewrite this as:\n\n    try:\n        CONF.debug\n    except cfg.NoSuchOptError:\n        ...\n\nI think having an actual assignment doesn\u0027t make much of a difference. Also, let\u0027s be clear, debug is not a pointer to CONF.debug.","commit_id":"a15cc1bc1640488980461887bd4b05531d5b04ce"}]}