)]}'
{"glance/store/filesystem.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"be82e062bbca44798689cb46d9c612b8e4752441","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            msg \u003d _(\"Found image at %s. Returning in ChunkedFile.\") % filepath"},{"line_number":156,"context_line":"            LOG.debug(msg)"},{"line_number":157,"context_line":"            try:"},{"line_number":158,"context_line":"                image_size \u003d int(os.path.getsize(filepath))"},{"line_number":159,"context_line":"            except os.error:"},{"line_number":160,"context_line":"                image_size \u003d None"},{"line_number":161,"context_line":"            return (ChunkedFile(filepath), image_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FwtU%3D","side":"PARENT","line":158,"updated":"2012-11-26 21:49:03.000000000","message":"https://review.openstack.org/#/c/16866/2/glance/store/filesystem.py makes it look like the int() cast is necessary. . . so I don\u0027t think we should drop it here","commit_id":"9a2f30964d190bdc0899492a621b69515c6e81fd"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"273dd00e8166c16c94d052a5b49c6ee1b9b36db2","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            msg \u003d _(\"Found image at %s. Returning in ChunkedFile.\") % filepath"},{"line_number":156,"context_line":"            LOG.debug(msg)"},{"line_number":157,"context_line":"            try:"},{"line_number":158,"context_line":"                image_size \u003d int(os.path.getsize(filepath))"},{"line_number":159,"context_line":"            except os.error:"},{"line_number":160,"context_line":"                image_size \u003d None"},{"line_number":161,"context_line":"            return (ChunkedFile(filepath), image_size)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fwqo%3D","side":"PARENT","line":158,"in_reply_to":"AAAAMH%2F%2FwtU%3D","updated":"2012-11-26 22:06:34.000000000","message":"os.path.getsize actually returns an int - the change in the other review is unnecessary.","commit_id":"9a2f30964d190bdc0899492a621b69515c6e81fd"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"f6f4851a87ae58a48699e2f988f511120eafb3ed","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if not os.path.exists(filepath):"},{"line_number":145,"context_line":"            raise exception.NotFound(_(\"Image file %s not found\") % filepath)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        filesize \u003d os.path.getsize(filepath)"},{"line_number":148,"context_line":"        return filepath, filesize"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2Fwu0%3D","line":146,"updated":"2012-11-26 21:42:44.000000000","message":"I guess there is a race condition if the file is somehow deleted during this whitespace line.","commit_id":"b15fcd4c63ce9450475a6f95aa7c806700d4b68f"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"273dd00e8166c16c94d052a5b49c6ee1b9b36db2","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if not os.path.exists(filepath):"},{"line_number":145,"context_line":"            raise exception.NotFound(_(\"Image file %s not found\") % filepath)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        filesize \u003d os.path.getsize(filepath)"},{"line_number":148,"context_line":"        return filepath, filesize"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAMH%2F%2FwrY%3D","line":146,"in_reply_to":"AAAAMH%2F%2Fwu0%3D","updated":"2012-11-26 22:06:34.000000000","message":"Yep, something I\u0027m not going to try to fix with this patch.","commit_id":"b15fcd4c63ce9450475a6f95aa7c806700d4b68f"}]}