)]}'
{"glance/tests/unit/test_image_cache.py":[{"author":{"_account_id":7939,"name":"Luke Wollney","email":"luke.wollney@rackspace.com","username":"lwollney"},"change_message_id":"32d003a0338d10cf942fbf934180e9ff8100f620","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # should be the ones pruned..."},{"line_number":183,"context_line":"        for x in range(10):"},{"line_number":184,"context_line":"            FIXTURE_FILE \u003d six.StringIO(FIXTURE_DATA)"},{"line_number":185,"context_line":"            self.assertTrue(self.cache.cache_image_file(x, FIXTURE_FILE))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertEqual(10 * units.Ki, self.cache.get_cache_size())"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_34048548","line":185,"updated":"2015-03-31 20:50:23.000000000","message":"You may want to consider including an assertion message that explicitly states what failed if this is not true.  The same goes for all assertions in this module.","commit_id":"b372b5041d2ce18d4bab0cd7cec6741396a68931"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"005765349428e1553ebefac13171e38b38e67ef2","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # should be the ones pruned..."},{"line_number":183,"context_line":"        for x in range(10):"},{"line_number":184,"context_line":"            FIXTURE_FILE \u003d six.StringIO(FIXTURE_DATA)"},{"line_number":185,"context_line":"            self.assertTrue(self.cache.cache_image_file(x, FIXTURE_FILE))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertEqual(10 * units.Ki, self.cache.get_cache_size())"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_ad3ba49b","line":185,"in_reply_to":"da9b358b_34048548","updated":"2015-03-31 21:51:38.000000000","message":"Luke, I think that the coding pattern here is that what\u0027s asserted here isn\u0027t actually being tested.  The assertion is being used so that if the precondition for the test fails, the \"real\" assertions in the test won\u0027t fail for the wrong reason.  So with this kind of thing, the line number is usually sufficient for troubleshooting (plus, it should never fail because it\u0027s been tested elsewhere).","commit_id":"b372b5041d2ce18d4bab0cd7cec6741396a68931"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"00721279e0f17b0fd26468b7260dbacf894e4240","unresolved":false,"context_lines":[{"line_number":182,"context_line":"        # should be the ones pruned..."},{"line_number":183,"context_line":"        for x in range(10):"},{"line_number":184,"context_line":"            FIXTURE_FILE \u003d six.StringIO(FIXTURE_DATA)"},{"line_number":185,"context_line":"            self.assertTrue(self.cache.cache_image_file(x, FIXTURE_FILE))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        self.assertEqual(10 * units.Ki, self.cache.get_cache_size())"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_f21ce414","line":185,"in_reply_to":"da9b358b_ad3ba49b","updated":"2015-04-01 03:13:10.000000000","message":"+1 to what Brian said","commit_id":"b372b5041d2ce18d4bab0cd7cec6741396a68931"},{"author":{"_account_id":7939,"name":"Luke Wollney","email":"luke.wollney@rackspace.com","username":"lwollney"},"change_message_id":"32d003a0338d10cf942fbf934180e9ff8100f620","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # Ensure the newly added image, 99, is still cached"},{"line_number":216,"context_line":"        self.assertTrue(self.cache.is_cached(99),"},{"line_number":217,"context_line":"                        \"Image %s was not cached!\" % x)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @skip_if_disabled"},{"line_number":220,"context_line":"    def test_prune_to_zero(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_54482987","line":217,"updated":"2015-03-31 20:50:23.000000000","message":"Unless I am not seeing something correctly here, it appears that the message should read \"Image 99 was not cached!\" because the image identifier is static and x wouldn\u0027t be 99 at this point.","commit_id":"b372b5041d2ce18d4bab0cd7cec6741396a68931"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"00721279e0f17b0fd26468b7260dbacf894e4240","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # Ensure the newly added image, 99, is still cached"},{"line_number":216,"context_line":"        self.assertTrue(self.cache.is_cached(99),"},{"line_number":217,"context_line":"                        \"Image %s was not cached!\" % x)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @skip_if_disabled"},{"line_number":220,"context_line":"    def test_prune_to_zero(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_72d7b423","line":217,"in_reply_to":"da9b358b_54482987","updated":"2015-04-01 03:13:10.000000000","message":"Good catch!","commit_id":"b372b5041d2ce18d4bab0cd7cec6741396a68931"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"005765349428e1553ebefac13171e38b38e67ef2","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        # Ensure the newly added image, 99, is still cached"},{"line_number":216,"context_line":"        self.assertTrue(self.cache.is_cached(99),"},{"line_number":217,"context_line":"                        \"Image %s was not cached!\" % x)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @skip_if_disabled"},{"line_number":220,"context_line":"    def test_prune_to_zero(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_0d5730cf","line":217,"in_reply_to":"da9b358b_54482987","updated":"2015-03-31 21:51:38.000000000","message":"Good catch, I completely missed this my first time through.","commit_id":"b372b5041d2ce18d4bab0cd7cec6741396a68931"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b83d875fb5e147c1ab56fa1659629f77c13b7725","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(0, self.cache.get_cache_size())"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Add a bunch of images to the cache. The max cache"},{"line_number":178,"context_line":"        # size for the cache is set to 5KB and each image is"},{"line_number":179,"context_line":"        # 1K. We add 10 images to the cache and then we\u0027ll"},{"line_number":180,"context_line":"        # prune it. We should see only 5 images left after"},{"line_number":181,"context_line":"        # pruning, and the images that are least recently accessed"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_6fda9d7a","line":178,"updated":"2015-04-01 15:17:12.000000000","message":"Please change the note as per the changes below. We have 11 images now and 5 of them are cached. Cache size is still 5K.","commit_id":"9ddf0bfb0a55a41eea4970dd1e48cf822ba0c359"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"b83d875fb5e147c1ab56fa1659629f77c13b7725","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.assertEqual(5 * units.Ki, self.cache.get_cache_size())"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # Ensure images 0, 1, 2, 3, 4 \u0026 5 are not cached anymore"},{"line_number":206,"context_line":"        for x in range(0, 6):"},{"line_number":207,"context_line":"            self.assertFalse(self.cache.is_cached(x),"},{"line_number":208,"context_line":"                             \"Image %s was cached!\" % x)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_2f8db57b","line":205,"updated":"2015-04-01 15:17:12.000000000","message":"Since the cache is 5K only 5 image are cached. You would need to change the note above.","commit_id":"9ddf0bfb0a55a41eea4970dd1e48cf822ba0c359"}]}