)]}'
{"glance/search/__init__.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"3f60e4495b3fb738eb7ee1f9d8dd1b67c21263b9","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            doc_type\u003ddefault_type,"},{"line_number":64,"context_line":"            actions\u003dactions)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def plugins_info(self):"},{"line_number":67,"context_line":"        return self.plugins_info_dict"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_plugin_info(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_226e8c95","line":66,"updated":"2015-04-08 13:41:08.000000000","message":"Do we really need both `plugins_info_dict` variable and `plugins_info` method?","commit_id":"1461527c8e5a02aae17b3bca63e6986f04844edd"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"977c403e35507ea9d23204bbd531291de9025a14","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            doc_type\u003ddefault_type,"},{"line_number":64,"context_line":"            actions\u003dactions)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def plugins_info(self):"},{"line_number":67,"context_line":"        return self.plugins_info_dict"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_plugin_info(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aa745d1_aa318f0d","line":66,"in_reply_to":"9aa53dc9_226e8c95","updated":"2015-04-16 14:52:58.000000000","message":"Nice catch, but its required by policy and search api. Better to keep it consistent as a definition vs variable. \nDuring __init__ it does eager initialization of response data and just returns the cached data later.","commit_id":"1461527c8e5a02aae17b3bca63e6986f04844edd"}],"glance/search/api/v0_1/search.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f46c9df1387694d98ec67e7e772e4ca74fe57f94","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":81,"context_line":"            result \u003d search_repo.plugins()"},{"line_number":82,"context_line":"            return result"},{"line_number":83,"context_line":"        except exception.Forbidden as e:"},{"line_number":84,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":85,"context_line":"        except exception.NotFound as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_b879d895","line":82,"updated":"2015-04-02 17:52:31.000000000","message":"here you can directly return search_repo.plugins()","commit_id":"1461527c8e5a02aae17b3bca63e6986f04844edd"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"977c403e35507ea9d23204bbd531291de9025a14","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":81,"context_line":"            result \u003d search_repo.plugins()"},{"line_number":82,"context_line":"            return result"},{"line_number":83,"context_line":"        except exception.Forbidden as e:"},{"line_number":84,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":85,"context_line":"        except exception.NotFound as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aa745d1_eaaaf718","line":82,"in_reply_to":"9aa53dc9_c27da0e8","updated":"2015-04-16 14:52:58.000000000","message":"Done","commit_id":"1461527c8e5a02aae17b3bca63e6986f04844edd"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"3f60e4495b3fb738eb7ee1f9d8dd1b67c21263b9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":81,"context_line":"            result \u003d search_repo.plugins()"},{"line_number":82,"context_line":"            return result"},{"line_number":83,"context_line":"        except exception.Forbidden as e:"},{"line_number":84,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":85,"context_line":"        except exception.NotFound as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_c27da0e8","line":82,"in_reply_to":"baa041b7_b879d895","updated":"2015-04-08 13:41:08.000000000","message":"++","commit_id":"1461527c8e5a02aae17b3bca63e6986f04844edd"},{"author":{"_account_id":8959,"name":"Lakshmi N Sampath","email":"lakshmi.sampath@hp.com","username":"lakshmi"},"change_message_id":"977c403e35507ea9d23204bbd531291de9025a14","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        try:"},{"line_number":80,"context_line":"            search_repo \u003d self.gateway.get_catalog_search_repo(req.context)"},{"line_number":81,"context_line":"            result \u003d search_repo.plugins()"},{"line_number":82,"context_line":"            return result"},{"line_number":83,"context_line":"        except exception.Forbidden as e:"},{"line_number":84,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":85,"context_line":"        except exception.NotFound as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aa745d1_aa63cf19","line":82,"in_reply_to":"baa041b7_b879d895","updated":"2015-04-16 14:52:58.000000000","message":"Done","commit_id":"1461527c8e5a02aae17b3bca63e6986f04844edd"}]}