)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"2c8beb2895754cbb9f13240f26307f0b658bb646","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix image list for deleted images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now when talking about deleted images in Glance, there are two"},{"line_number":10,"context_line":"aspects: status and deleted fileds from database view."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For v1, we do support listing the deleted images, but it\u0027s broken"},{"line_number":13,"context_line":"for now, since the \u0027deleted\u0027 filter parameter is removed explicitly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_a52664b8","line":10,"updated":"2015-04-13 08:27:25.000000000","message":"s/fileds/field","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"810e2d546b37123d366da9825076475a62005e63","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix image list for deleted images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now when talking about deleted images in Glance, there are two"},{"line_number":10,"context_line":"aspects: status and deleted fileds from database view."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"For v1, we do support listing the deleted images, but it\u0027s broken"},{"line_number":13,"context_line":"for now, since the \u0027deleted\u0027 filter parameter is removed explicitly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_f1fc2e40","line":10,"in_reply_to":"7aaa499b_a52664b8","updated":"2015-04-13 10:39:29.000000000","message":"Done","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"2c8beb2895754cbb9f13240f26307f0b658bb646","unresolved":false,"context_lines":[{"line_number":13,"context_line":"for now, since the \u0027deleted\u0027 filter parameter is removed explicitly."},{"line_number":14,"context_line":"So we add it back in this patch."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For v2, now it\u0027s hard code to hide the deleted images. This patch"},{"line_number":17,"context_line":"will enable the \u0027status\u0027 filter so that end user can list deleted"},{"line_number":18,"context_line":"images with status\u003d\u003cstatus\u003e."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_253b74d3","line":16,"updated":"2015-04-13 08:27:25.000000000","message":"s/code/coded","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"810e2d546b37123d366da9825076475a62005e63","unresolved":false,"context_lines":[{"line_number":13,"context_line":"for now, since the \u0027deleted\u0027 filter parameter is removed explicitly."},{"line_number":14,"context_line":"So we add it back in this patch."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For v2, now it\u0027s hard code to hide the deleted images. This patch"},{"line_number":17,"context_line":"will enable the \u0027status\u0027 filter so that end user can list deleted"},{"line_number":18,"context_line":"images with status\u003d\u003cstatus\u003e."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aaa499b_d1f9324f","line":16,"in_reply_to":"7aaa499b_253b74d3","updated":"2015-04-13 10:39:29.000000000","message":"Done","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e73fc85a3d91e54f7304e413dcdc0034ccdbd0e7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For v2, now it\u0027s harded code to hide the deleted images. This patch"},{"line_number":13,"context_line":"will enable the \u0027status\u0027 filter so that end user can list deleted"},{"line_number":14,"context_line":"images with status\u003d\u003cstatus\u003e."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1432701"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I7fced3d8d037aef8e11b402366a3fbc3cc8527a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_b9ea0173","line":15,"updated":"2015-07-07 09:08:25.000000000","message":"APIImpact\nDocImpact \n:)","commit_id":"e134f8933722aab5151a7bc146b34acad40e7c6a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"db8d9552753fb29dc7b15f3b0f29f6e1d37cac2b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For v2, now it\u0027s harded code to hide the deleted images. This patch"},{"line_number":13,"context_line":"will enable the \u0027status\u0027 filter so that end user can list deleted"},{"line_number":14,"context_line":"images with status\u003d\u003cstatus\u003e."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1432701"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I7fced3d8d037aef8e11b402366a3fbc3cc8527a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a41bdd9_066f80fc","line":15,"in_reply_to":"ba3cc151_b9ea0173","updated":"2015-07-16 02:28:27.000000000","message":"Good point, man","commit_id":"e134f8933722aab5151a7bc146b34acad40e7c6a"}],"glance/api/v2/images.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"2c8beb2895754cbb9f13240f26307f0b658bb646","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        result \u003d {}"},{"line_number":98,"context_line":"        if filters is None:"},{"line_number":99,"context_line":"            filters \u003d {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if req.context.is_admin:"},{"line_number":102,"context_line":"            if \u0027status\u0027 in filters and filters[\u0027status\u0027] in (\u0027killed\u0027,"},{"line_number":103,"context_line":"                                                             \u0027deleted\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_a2d3fa37","line":100,"updated":"2015-04-13 08:27:25.000000000","message":"nit: It would be nice to rewrite it to make it a bit cleaner and easier to read. Something like:\n\ndeleted_states \u003d (\u0027killed\u0027, \u0027deleted\u0027, \u0027pending-delete\u0027)\nif req.context.is_admin and filters.get(\u0027status\u0027) in deleted_states:\n    filters[\u0027deleted\u0027] \u003d True\nelse:\n    filters[\u0027deleted\u0027] \u003d False","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"810e2d546b37123d366da9825076475a62005e63","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        result \u003d {}"},{"line_number":98,"context_line":"        if filters is None:"},{"line_number":99,"context_line":"            filters \u003d {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        if req.context.is_admin:"},{"line_number":102,"context_line":"            if \u0027status\u0027 in filters and filters[\u0027status\u0027] in (\u0027killed\u0027,"},{"line_number":103,"context_line":"                                                             \u0027deleted\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_f1930ef9","line":100,"in_reply_to":"7aaa499b_a2d3fa37","updated":"2015-04-13 10:39:29.000000000","message":"Make sense for me, thanks.","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"32ef5df70a2a83025c3390479ba06e0ca134d32e","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if (req.context.is_admin and"},{"line_number":105,"context_line":"                filters.get(\u0027status\u0027) in self.deleted_status):"},{"line_number":106,"context_line":"            filters[\u0027deleted\u0027] \u003d True"},{"line_number":107,"context_line":"        else:"},{"line_number":108,"context_line":"            filters[\u0027deleted\u0027] \u003d False"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_4fee8fb5","line":106,"updated":"2015-07-21 08:26:17.000000000","message":"An image in \u0027killed\u0027 state will have \u0027deleted\u0027\u003dFalse. \n\nI think we should remove killed state from deleted_status.","commit_id":"e134f8933722aab5151a7bc146b34acad40e7c6a"}],"glance/tests/unit/v2/test_images_resource.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"2c8beb2895754cbb9f13240f26307f0b658bb646","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        output \u003d self.controller.index(request, filters\u003d{\u0027status\u0027: \u0027deleted\u0027})"},{"line_number":219,"context_line":"        self.assertEqual(1, len(output[\u0027images\u0027]))"},{"line_number":220,"context_line":"        self.assertEqual(UUID1, output[\u0027images\u0027][0].image_id)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_index_return_parameters(self):"},{"line_number":223,"context_line":"        self.config(limit_param_default\u003d1, api_limit_max\u003d3)"},{"line_number":224,"context_line":"        request \u003d unit_test_utils.get_fake_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_a279bafe","line":221,"updated":"2015-04-13 08:27:25.000000000","message":"Additional test covering that non-admin user cannot get deleted images even if `status: deleted` has been specified would be nice to have.","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"810e2d546b37123d366da9825076475a62005e63","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        output \u003d self.controller.index(request, filters\u003d{\u0027status\u0027: \u0027deleted\u0027})"},{"line_number":219,"context_line":"        self.assertEqual(1, len(output[\u0027images\u0027]))"},{"line_number":220,"context_line":"        self.assertEqual(UUID1, output[\u0027images\u0027][0].image_id)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def test_index_return_parameters(self):"},{"line_number":223,"context_line":"        self.config(limit_param_default\u003d1, api_limit_max\u003d3)"},{"line_number":224,"context_line":"        request \u003d unit_test_utils.get_fake_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aaa499b_d19012ef","line":221,"in_reply_to":"7aaa499b_a279bafe","updated":"2015-04-13 10:39:29.000000000","message":"Good point.","commit_id":"4fd93403f2a9e78c2673e65cc73460489bf1729c"}]}
