)]}'
{"glance/api/middleware/cache.py":[{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"ad17ca3480c58e5558223feae031ace642c32f04","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                                         image_id)"},{"line_number":115,"context_line":"            return utils.create_mashup_dict(image_metadata)"},{"line_number":116,"context_line":"        except exception.NotFound as e:"},{"line_number":117,"context_line":"            LOG.debug(\"No metadata found for image \u0027%s\u0027\", image_id)"},{"line_number":118,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg, request\u003drequest)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _get_v2_image_metadata(self, request, image_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_9704424a","line":117,"updated":"2015-05-05 19:13:15.000000000","message":"Are you changing this for all log formatting? Or just the ones in the patch mentioned in the commit message?","commit_id":"6a19f549a56bf4883cd4b148aa4cc2fe495add70"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"a24ae584806ff792f67b4ea9c1d407874b9130e9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                                                         image_id)"},{"line_number":115,"context_line":"            return utils.create_mashup_dict(image_metadata)"},{"line_number":116,"context_line":"        except exception.NotFound as e:"},{"line_number":117,"context_line":"            LOG.debug(\"No metadata found for image \u0027%s\u0027\", image_id)"},{"line_number":118,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg, request\u003drequest)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def _get_v2_image_metadata(self, request, image_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_174cb29c","line":117,"in_reply_to":"3acd31a7_9704424a","updated":"2015-05-05 19:17:47.000000000","message":"I was aiming for just the ones mentioned in the previous patch, but I may have been a little overzealous. The rest of them should also be changed, but I\u0027d rather it was done in smaller chunks so we don\u0027t have a giant patchset which isn\u0027t fun to review and needs to be rebased all the time.","commit_id":"6a19f549a56bf4883cd4b148aa4cc2fe495add70"}],"glance/api/v2/image_data.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"cede6310b1616eadc32ef598081bc3e6fb3adb6c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                glance_store.StoreRandomGetNotSupported) as e:"},{"line_number":230,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":231,"context_line":"        except exception.Forbidden as e:"},{"line_number":232,"context_line":"            LOG.debug(\"User not permitted to download image \u0027%s\u0027\" % image)"},{"line_number":233,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":234,"context_line":"        # NOTE(saschpe): \"response.app_iter \u003d ...\" currently resets Content-MD5"},{"line_number":235,"context_line":"        # (https://github.com/Pylons/webob/issues/86), so it should be set"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4bcd475c","side":"PARENT","line":232,"updated":"2015-05-15 21:47:31.000000000","message":"This should be image.image_id. Technically not related to this patch but wouldn\u0027t it be better to fix it ?","commit_id":"7896c006353426348c88938fc72ecf1df57d88e4"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"ebd1a208b46ed618bc74c2918c644dd517f1c761","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                glance_store.StoreRandomGetNotSupported) as e:"},{"line_number":230,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":231,"context_line":"        except exception.Forbidden as e:"},{"line_number":232,"context_line":"            LOG.debug(\"User not permitted to download image \u0027%s\u0027\" % image)"},{"line_number":233,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":234,"context_line":"        # NOTE(saschpe): \"response.app_iter \u003d ...\" currently resets Content-MD5"},{"line_number":235,"context_line":"        # (https://github.com/Pylons/webob/issues/86), so it should be set"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_76d32339","side":"PARENT","line":232,"in_reply_to":"7a016987_36a5ab03","updated":"2015-05-28 14:52:25.000000000","message":"Sounds good :)","commit_id":"7896c006353426348c88938fc72ecf1df57d88e4"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"d8d00bbf8ab4342841672e0fe7d48f52b33f4b21","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                glance_store.StoreRandomGetNotSupported) as e:"},{"line_number":230,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":231,"context_line":"        except exception.Forbidden as e:"},{"line_number":232,"context_line":"            LOG.debug(\"User not permitted to download image \u0027%s\u0027\" % image)"},{"line_number":233,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":234,"context_line":"        # NOTE(saschpe): \"response.app_iter \u003d ...\" currently resets Content-MD5"},{"line_number":235,"context_line":"        # (https://github.com/Pylons/webob/issues/86), so it should be set"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_36a5ab03","side":"PARENT","line":232,"in_reply_to":"7a016987_4bcd475c","updated":"2015-05-28 14:49:09.000000000","message":"Add a follow up patch to this one fixing it. :)","commit_id":"7896c006353426348c88938fc72ecf1df57d88e4"}]}
