)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1872,"name":"therese-mchale","email":"therese.mchale@hp.com","username":"therese-mchale"},"change_message_id":"6eebce14d7c3652fb4d5904db0c459a6ffc272f7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2012-12-13 13:34:19 +0000"},{"line_number":4,"context_line":"Commit:     Therese McHale \u003ctherese.mchale@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-12-13 16:42:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use one wsgi app, one dbengine worker."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Return to using one wsgi application but use one database engine"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAMX%2F%2F0%2FQ%3D","line":6,"updated":"2012-12-13 18:25:27.000000000","message":"recheck","commit_id":"efc2ffa75c2844966a059fca4cfeea9040afc77e"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"1cd5cc093f9aed658e88348564ce40d5ad37cd08","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    register the models."},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":"    setup_db_env()"},{"line_number":105,"context_line":"    _ENGINE \u003d get_engine()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def check_mutate_authorization(context, image_ref):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2Fzwk%3D","line":105,"updated":"2012-12-14 18:28:59.000000000","message":"is _ENGINE here just a throwaway variable or does it need to be identified as a global as well?","commit_id":"efc2ffa75c2844966a059fca4cfeea9040afc77e"},{"author":{"_account_id":1872,"name":"therese-mchale","email":"therese.mchale@hp.com","username":"therese-mchale"},"change_message_id":"27a2676dcfd384226d39233266231974601fabc3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    register the models."},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":"    setup_db_env()"},{"line_number":105,"context_line":"    _ENGINE \u003d get_engine()"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def check_mutate_authorization(context, image_ref):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2F%2FnQ%3D","line":105,"in_reply_to":"AAAAMX%2F%2Fzwk%3D","updated":"2012-12-17 11:00:12.000000000","message":"It\u0027s a throwaway as get_engine populates the _ENGINE global .   I will remove _ENGINE\u003d to make this clear, but I will leave the return _ENGINE on get_engine there in the interests of removing the globals later.    As per Jays comment the globals need to be factored out later, we are already using  _CONNECTION global  and nova uses globals here but they are not very pretty and need removal as a followup  step to this patch.","commit_id":"efc2ffa75c2844966a059fca4cfeea9040afc77e"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c2cb6ae53548a57b56c5f067b9847cef99fe4a2e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                pass"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            LOG.info(_(\u0027not auto-creating glance registry DB\u0027))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    return _ENGINE"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F8w8%3D","line":177,"updated":"2012-12-19 10:53:20.000000000","message":"I don\u0027t see this return value (_ENGINE) being consumed by any of the current callers -- is that intended?","commit_id":"a452dd77b23bb055d080c44ba67f88ac25a90153"},{"author":{"_account_id":1872,"name":"therese-mchale","email":"therese.mchale@hp.com","username":"therese-mchale"},"change_message_id":"39ec1a28bccb95b7cac30f2916b367c17d9b2cd5","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                pass"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            LOG.info(_(\u0027not auto-creating glance registry DB\u0027))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    return _ENGINE"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2F8ws%3D","line":177,"in_reply_to":"AAAAM3%2F%2F8w8%3D","updated":"2012-12-19 10:57:01.000000000","message":"This is intended ...the return value is there to facilitate removal of globals later.  .Please see previous reply to Mark Washenbergs question on previous patchset.","commit_id":"a452dd77b23bb055d080c44ba67f88ac25a90153"}]}