)]}'
{"etc/metadefs/compute-vmware.json":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"57f1a47dc721d3b9e98fbf802c1a9eb72c452e28","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \"title\": \"OS Type\","},{"line_number":39,"context_line":"            \"description\": \"A VMware GuestID which describes the operating system installed in the image. This value is passed to the hypervisor when creating a virtual machine. If not specified, the key defaults to otherGuest. See thinkvirt.com.\","},{"line_number":40,"context_line":"            \"type\": \"string\","},{"line_number":41,"context_line":"            \"enum\": ["},{"line_number":42,"context_line":"                \"asianux3_64Guest\","},{"line_number":43,"context_line":"                \"asianux3Guest\","},{"line_number":44,"context_line":"                \"asianux4_64Guest\","}],"source_content_type":"application/json","patch_set":1,"id":"7ad8896b_5dac47ed","line":41,"updated":"2015-05-11 18:25:47.000000000","message":"Some of these values says rhel7Guest won\u0027t work on vSphere 5.1 platforms. Since we still claim to support 5.1 [1], I feel we should be using the constants from 5.1. Thoughts ?\n\n[1] http://docs.openstack.org/kilo/config-reference/content/vmware.html","commit_id":"32dae06780f417f9410b666c4acfc75ee7c996c0"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"ab6acf8b11825a155ea0f8ff1fe2063b7433ede0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \"title\": \"OS Type\","},{"line_number":39,"context_line":"            \"description\": \"A VMware GuestID which describes the operating system installed in the image. This value is passed to the hypervisor when creating a virtual machine. If not specified, the key defaults to otherGuest. See thinkvirt.com.\","},{"line_number":40,"context_line":"            \"type\": \"string\","},{"line_number":41,"context_line":"            \"enum\": ["},{"line_number":42,"context_line":"                \"asianux3_64Guest\","},{"line_number":43,"context_line":"                \"asianux3Guest\","},{"line_number":44,"context_line":"                \"asianux4_64Guest\","}],"source_content_type":"application/json","patch_set":1,"id":"7ad8896b_ddf2776f","line":41,"in_reply_to":"7ad8896b_5dac47ed","updated":"2015-05-11 18:45:33.000000000","message":"This is the vSphere 6.0 list of supported operating systems which would be a super set of 5.1.  Guess I\u0027m not too worried about types that won\u0027t work on 5.1 since before this change you get into the same situation if you pass a random string.\n\nI also feel we should drop support of 5.1 in favor of just 5.5. and 6.0, but that\u0027s a separate issue.","commit_id":"32dae06780f417f9410b666c4acfc75ee7c996c0"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"105960cf7afe64c938fac7a22590eb84d67e96af","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \"title\": \"OS Type\","},{"line_number":39,"context_line":"            \"description\": \"A VMware GuestID which describes the operating system installed in the image. This value is passed to the hypervisor when creating a virtual machine. If not specified, the key defaults to otherGuest. See thinkvirt.com.\","},{"line_number":40,"context_line":"            \"type\": \"string\","},{"line_number":41,"context_line":"            \"enum\": ["},{"line_number":42,"context_line":"                \"asianux3_64Guest\","},{"line_number":43,"context_line":"                \"asianux3Guest\","},{"line_number":44,"context_line":"                \"asianux4_64Guest\","}],"source_content_type":"application/json","patch_set":1,"id":"7ad8896b_e8be8fd3","line":41,"in_reply_to":"7ad8896b_ddf2776f","updated":"2015-05-11 18:59:10.000000000","message":"If nova accepts these as valid os types, there is no argument for these to not exist in glance metadefs. I see your patch https://review.openstack.org/#/c/182003/. So this LGTM.","commit_id":"32dae06780f417f9410b666c4acfc75ee7c996c0"}]}