)]}'
{"glance/cmd/replicator.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"584c7e5c04f55d929ea3dd1bbf4a540a1ad8623a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from __future__ import print_function"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import os"},{"line_number":22,"context_line":"from six.moves import http_client"},{"line_number":23,"context_line":"import sys"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_0ad0a2c8","line":22,"updated":"2015-05-26 14:36:23.000000000","message":"Please let\u0027s keep  all six.moves imports at  the same block.","commit_id":"4942b9a69559140e8cd549769985e160a2b76d5e"}],"glance/common/client.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"378ef4ef8a3bf0105d40d89c974c27fe9a3d9f36","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from oslo_log import log as logging"},{"line_number":43,"context_line":"from oslo_utils import encodeutils"},{"line_number":44,"context_line":"import six"},{"line_number":45,"context_line":"# NOTE(jokke): simplified transition to py3, behaves like py2 xrange"},{"line_number":46,"context_line":"from six.moves import http_client"},{"line_number":47,"context_line":"from six.moves import range"},{"line_number":48,"context_line":"import six.moves.urllib.parse as urlparse"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_bbd79122","line":45,"updated":"2015-05-26 23:47:53.000000000","message":"should we move this back one line down or generalize it?","commit_id":"aeb335c9a885f1ebe0f47c4c1f4a9f10dd04e601"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"14f02f221c516d15afaabef165a6d8f0a1fc1cb8","unresolved":false,"context_lines":[{"line_number":42,"context_line":"from oslo_log import log as logging"},{"line_number":43,"context_line":"from oslo_utils import encodeutils"},{"line_number":44,"context_line":"import six"},{"line_number":45,"context_line":"# NOTE(jokke): simplified transition to py3, behaves like py2 xrange"},{"line_number":46,"context_line":"from six.moves import http_client"},{"line_number":47,"context_line":"from six.moves import range"},{"line_number":48,"context_line":"import six.moves.urllib.parse as urlparse"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_7e7107e0","line":45,"in_reply_to":"7a016987_bbd79122","updated":"2015-05-27 00:58:21.000000000","message":"Done","commit_id":"aeb335c9a885f1ebe0f47c4c1f4a9f10dd04e601"}],"glance/tests/unit/async/flows/test_import.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"584c7e5c04f55d929ea3dd1bbf4a540a1ad8623a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import glance_store"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":"from six.moves import cStringIO"},{"line_number":23,"context_line":"from taskflow import task"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import glance.async.flows.base_import as import_flow"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_ca884ac9","line":22,"updated":"2015-05-26 14:36:23.000000000","message":"Same here.","commit_id":"4942b9a69559140e8cd549769985e160a2b76d5e"}],"glance/tests/unit/test_glance_replicator.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"584c7e5c04f55d929ea3dd1bbf4a540a1ad8623a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"from six import moves"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import uuid"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_6a7dd6b0","line":17,"updated":"2015-05-26 14:36:23.000000000","message":"we should either use the six imported below or import all more explisitely. And keep the six import in the same block.","commit_id":"4942b9a69559140e8cd549769985e160a2b76d5e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"378ef4ef8a3bf0105d40d89c974c27fe9a3d9f36","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import fixtures"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"from six import moves"},{"line_number":24,"context_line":"import webob"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from glance.cmd import replicator as glance_replicator"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_bb8c3136","line":23,"updated":"2015-05-26 23:47:53.000000000","message":"NIT(sorry for noticing it just now): for consistency we should import the metamodule like:\nfrom six.moves import UserDict\nrather than calling moves.UserDict() later on?","commit_id":"aeb335c9a885f1ebe0f47c4c1f4a9f10dd04e601"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"14f02f221c516d15afaabef165a6d8f0a1fc1cb8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import fixtures"},{"line_number":21,"context_line":"from oslo_serialization import jsonutils"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"from six import moves"},{"line_number":24,"context_line":"import webob"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from glance.cmd import replicator as glance_replicator"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a016987_de947be9","line":23,"in_reply_to":"7a016987_bb8c3136","updated":"2015-05-27 00:58:21.000000000","message":"OpenStack coding style asks to only import modules, not symbols:\nhttp://docs.openstack.org/developer/hacking/#imports\n\nsix.moves.UserDict is a class, not a module. That\u0027s why UserDict.UserDict is replaced with moves.UserDict.","commit_id":"aeb335c9a885f1ebe0f47c4c1f4a9f10dd04e601"}],"glance/tests/utils.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"584c7e5c04f55d929ea3dd1bbf4a540a1ad8623a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import os"},{"line_number":21,"context_line":"import shlex"},{"line_number":22,"context_line":"import shutil"},{"line_number":23,"context_line":"from six.moves import BaseHTTPServer"},{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import subprocess"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a016987_ea478675","line":23,"updated":"2015-05-26 14:36:23.000000000","message":"ditto","commit_id":"4942b9a69559140e8cd549769985e160a2b76d5e"}]}