)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"ba1977483fa8219f177c9d908b02090b54aa9ab9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Importing oslo.rootwrap into Glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the glance storage backend drivers like cinder require"},{"line_number":10,"context_line":"root priveleges. This patch allows them to use oslo.rootwrap"},{"line_number":11,"context_line":"as the glance-rootwrap command."},{"line_number":12,"context_line":"Command filters for glance-rootwrap are contained in glance_store"},{"line_number":13,"context_line":"repositry as they are provided by the drivers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_c667d0b5","line":10,"updated":"2015-05-28 10:30:08.000000000","message":"Can you give an example of where root privilege is unavoidable? Thanks.\n\nAlso, can you clarify why this is going into \u0027glance\u0027 rather than \u0027glance_store\u0027? Thanks.","commit_id":"3d60614195d0a2ed75d4267cf177c57af8b7ad5a"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"9475019ac6699d720d4495db2d8f4b6039992bca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Importing oslo.rootwrap into Glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the glance storage backend drivers like cinder require"},{"line_number":10,"context_line":"root priveleges. This patch allows them to use oslo.rootwrap"},{"line_number":11,"context_line":"as the glance-rootwrap command."},{"line_number":12,"context_line":"Command filters for glance-rootwrap are contained in glance_store"},{"line_number":13,"context_line":"repositry as they are provided by the drivers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_3aa15b95","line":10,"in_reply_to":"7a016987_5c316559","updated":"2015-06-05 21:24:26.000000000","message":"\u003e Also, can you clarify why this is going into \u0027glance\u0027 rather than \u0027glance_store\u0027? Thanks.\n\noslo_rootwrap needs a new config parameter \"rootwrap_config\" in the glance-api.conf. If I understand correctly, this new config option should be put in common/config.py both in glance and glance_store. This is why I\u0027m proposing this patch not only to glance_store but also to glance.\n\nIf I\u0027m missing something, please let me know. Thanks.","commit_id":"3d60614195d0a2ed75d4267cf177c57af8b7ad5a"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"f5ad140504e9c5dafc7d06dfa94a6d1b55cdc470","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Importing oslo.rootwrap into Glance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some of the glance storage backend drivers like cinder require"},{"line_number":10,"context_line":"root priveleges. This patch allows them to use oslo.rootwrap"},{"line_number":11,"context_line":"as the glance-rootwrap command."},{"line_number":12,"context_line":"Command filters for glance-rootwrap are contained in glance_store"},{"line_number":13,"context_line":"repositry as they are provided by the drivers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_5c316559","line":10,"in_reply_to":"7a016987_c667d0b5","updated":"2015-05-28 16:43:22.000000000","message":"It is required by the implementation of upload/download method for cinder backend[1], because it has to read/write/manage block devices.\n\n  [1] https://review.openstack.org/#/c/166414/\n\nAdded explanation of reasoning to the commit message. Thanks.","commit_id":"3d60614195d0a2ed75d4267cf177c57af8b7ad5a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c2a33e7c89fdb6693db3a5ac851cdc904ff14c27","unresolved":false,"context_lines":[{"line_number":11,"context_line":"as the glance-rootwrap command."},{"line_number":12,"context_line":"Command filters for glance-rootwrap are contained in glance_store"},{"line_number":13,"context_line":"repositry as they are provided by the drivers."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a6183440d107afdb4e9bf087282e8604a9eea93"},{"line_number":16,"context_line":"Partially Implements: blueprint cinder-store-upload-download"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_c3a8e279","line":14,"updated":"2015-05-28 10:14:47.000000000","message":"IMO you need to add DocImpact flag","commit_id":"3d60614195d0a2ed75d4267cf177c57af8b7ad5a"},{"author":{"_account_id":9176,"name":"Tomoki Sekiyama","email":"tomoki.sekiyama@gmail.com","username":"tsekiyama"},"change_message_id":"f5ad140504e9c5dafc7d06dfa94a6d1b55cdc470","unresolved":false,"context_lines":[{"line_number":11,"context_line":"as the glance-rootwrap command."},{"line_number":12,"context_line":"Command filters for glance-rootwrap are contained in glance_store"},{"line_number":13,"context_line":"repositry as they are provided by the drivers."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2a6183440d107afdb4e9bf087282e8604a9eea93"},{"line_number":16,"context_line":"Partially Implements: blueprint cinder-store-upload-download"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a016987_1c376d4e","line":14,"in_reply_to":"7a016987_c3a8e279","updated":"2015-05-28 16:43:22.000000000","message":"Added. Thanks.","commit_id":"3d60614195d0a2ed75d4267cf177c57af8b7ad5a"}],"doc/source/configuring.rst":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"90bb567a59c2a0bc95405565da7441caec93de6e","unresolved":false,"context_lines":[{"line_number":1515,"context_line":"Configuring rootwrap option"},{"line_number":1516,"context_line":"----------------------------------"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"Some of storage backends like cinder requires the rootwrap configuration file"},{"line_number":1519,"context_line":"and command filters for them to use for running commands as root. The location"},{"line_number":1520,"context_line":"to the rootwrap configuration file is specified in the ``glance-api.conf``"},{"line_number":1521,"context_line":"config file in the sectoin ``[DEFAULT]``."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_1f522368","line":1518,"updated":"2015-06-29 17:11:21.000000000","message":"I think \"the\" should be added: \"Some of the storage backends...\"\n\nI think \"requires\" should be replaced with \"require\" since the noun here is plural (storage backends).","commit_id":"4fb0bf80d048aa1b3c75d88b311b480ccd0b324f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"90bb567a59c2a0bc95405565da7441caec93de6e","unresolved":false,"context_lines":[{"line_number":1516,"context_line":"----------------------------------"},{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"Some of storage backends like cinder requires the rootwrap configuration file"},{"line_number":1519,"context_line":"and command filters for them to use for running commands as root. The location"},{"line_number":1520,"context_line":"to the rootwrap configuration file is specified in the ``glance-api.conf``"},{"line_number":1521,"context_line":"config file in the sectoin ``[DEFAULT]``."},{"line_number":1522,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_7fbc8f6c","line":1519,"updated":"2015-06-29 17:11:21.000000000","message":"I would rephrase this to \"the rootwrap configuration file and command filters in order for them to run commands as root.\"","commit_id":"4fb0bf80d048aa1b3c75d88b311b480ccd0b324f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"90bb567a59c2a0bc95405565da7441caec93de6e","unresolved":false,"context_lines":[{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"Some of storage backends like cinder requires the rootwrap configuration file"},{"line_number":1519,"context_line":"and command filters for them to use for running commands as root. The location"},{"line_number":1520,"context_line":"to the rootwrap configuration file is specified in the ``glance-api.conf``"},{"line_number":1521,"context_line":"config file in the sectoin ``[DEFAULT]``."},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"* ``rootwrap_config\u003dPATH``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_5fd66bc6","line":1520,"updated":"2015-06-29 17:11:21.000000000","message":"I would replace \"to\" with \"for\"","commit_id":"4fb0bf80d048aa1b3c75d88b311b480ccd0b324f"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"90bb567a59c2a0bc95405565da7441caec93de6e","unresolved":false,"context_lines":[{"line_number":1518,"context_line":"Some of storage backends like cinder requires the rootwrap configuration file"},{"line_number":1519,"context_line":"and command filters for them to use for running commands as root. The location"},{"line_number":1520,"context_line":"to the rootwrap configuration file is specified in the ``glance-api.conf``"},{"line_number":1521,"context_line":"config file in the sectoin ``[DEFAULT]``."},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"* ``rootwrap_config\u003dPATH``"},{"line_number":1524,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba3cc151_5fbbcb72","line":1521,"updated":"2015-06-29 17:11:21.000000000","message":"\"sectoin\" should be replaced with \"section\"","commit_id":"4fb0bf80d048aa1b3c75d88b311b480ccd0b324f"}]}