)]}'
{"glance/db/sqlalchemy/models_artifacts.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"7fd9149091a856f27e9eedc73541463524b398f0","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            # parts of the composite field"},{"line_number":161,"context_line":"            prefixes_to_pop \u003d [v + \"_%s\" % t"},{"line_number":162,"context_line":"                               for t in self.type_version.column_types"},{"line_number":163,"context_line":"                               for v in [\u0027type_version\u0027, \u0027version\u0027]]"},{"line_number":164,"context_line":"            if any(key.startswith(p) for p in prefixes_to_pop):"},{"line_number":165,"context_line":"                d.pop(key)"},{"line_number":166,"context_line":"        d[\u0027type_version\u0027] \u003d str(self.type_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_42054712","line":163,"updated":"2015-06-19 12:45:06.000000000","message":"prefixes_to_pop can be built before the loop, so won\u0027t be initialized for every iteration.","commit_id":"88b4c68a7e8f7a967bd63195051f43484c0ce6ba"},{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"7fd9149091a856f27e9eedc73541463524b398f0","unresolved":false,"context_lines":[{"line_number":161,"context_line":"            prefixes_to_pop \u003d [v + \"_%s\" % t"},{"line_number":162,"context_line":"                               for t in self.type_version.column_types"},{"line_number":163,"context_line":"                               for v in [\u0027type_version\u0027, \u0027version\u0027]]"},{"line_number":164,"context_line":"            if any(key.startswith(p) for p in prefixes_to_pop):"},{"line_number":165,"context_line":"                d.pop(key)"},{"line_number":166,"context_line":"        d[\u0027type_version\u0027] \u003d str(self.type_version)"},{"line_number":167,"context_line":"        d[\u0027version\u0027] \u003d str(self.version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa32b979_62540b21","line":164,"updated":"2015-06-19 12:45:06.000000000","message":"nit: startswith method accepts a tuple of strings to search for, so it can be simplified by using:\n\nif key.startswith(tuple(prefixes_to_pop)):","commit_id":"88b4c68a7e8f7a967bd63195051f43484c0ce6ba"}]}