)]}'
{"glance/tests/unit/v2/test_registry_api.py":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"a90591a3eb3aa35dc55c90b99d5fa6efdc97b504","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        db_models.unregister_models(db_api.get_engine())"},{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_length_and_uuid(self, images, uuids):"},{"line_number":116,"context_line":"        self.assertEqual(len(uuids), len(images))"},{"line_number":117,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_c5e10a9c","line":115,"updated":"2015-06-08 21:29:32.000000000","message":"I think it\u0027s better to call this function\n`_compare_images_uuids`\n\nor smth. Word `compare` suggests, that the function return boolean value, while it does not.","commit_id":"79edabb0bc0ce0dce6ffcc06cd0afbe3fdb8e3a6"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"a90591a3eb3aa35dc55c90b99d5fa6efdc97b504","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_length_and_uuid(self, images, uuids):"},{"line_number":116,"context_line":"        self.assertEqual(len(uuids), len(images))"},{"line_number":117,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_show(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_a5a28eac","line":116,"updated":"2015-06-08 21:29:32.000000000","message":"It\u0027s senseless to test both. If lists are not equal, their length would not be equal either.","commit_id":"79edabb0bc0ce0dce6ffcc06cd0afbe3fdb8e3a6"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"a90591a3eb3aa35dc55c90b99d5fa6efdc97b504","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_length_and_uuid(self, images, uuids):"},{"line_number":116,"context_line":"        self.assertEqual(len(uuids), len(images))"},{"line_number":117,"context_line":"        self.assertEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_show(self):"},{"line_number":120,"context_line":"        \"\"\"Tests that registry API endpoint returns the expected image.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_65e816b5","line":117,"updated":"2015-06-08 21:29:32.000000000","message":"Since you\u0027re testing lists here: why not use smth like assertListEqual or assertSequenceEqual (in case you\u0027re not sure, if they\u0027re lists or not).\n\nThese asserts construct much cleaner error messages.","commit_id":"79edabb0bc0ce0dce6ffcc06cd0afbe3fdb8e3a6"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"e19f56ac2286cafedef6ee3f3b46f0de3b031c7b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        db_models.unregister_models(db_api.get_engine())"},{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_and_uuids(self, images, uuids):"},{"line_number":116,"context_line":"        self.assertListEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_show(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_0970490a","line":115,"updated":"2015-06-09 10:09:09.000000000","message":"I suggest there is no need for this extra one liner. All it does is create a list comprehension and call standard library function.\n\nI do not really think that this would count as code duplication.","commit_id":"7e93dead4efaf672b50bdbdebfd4f4128c469248"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"870e1cd611b95c8c10ff4a6d4e6c19b9a16b0e4f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        db_models.unregister_models(db_api.get_engine())"},{"line_number":113,"context_line":"        db_models.register_models(db_api.get_engine())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _compare_images_and_uuids(self, images, uuids):"},{"line_number":116,"context_line":"        self.assertListEqual(uuids, [image[\u0027id\u0027] for image in images])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_show(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_bea5e647","line":115,"in_reply_to":"3afb71cf_0970490a","updated":"2015-06-09 11:00:51.000000000","message":"+1 to Kirill\u0027s proposal. I see no need for a oneliner either. But it\u0027s up to you to decide.\n\nIf you prefer to keep your variant, I\u0027d rather change the order of arguments, as long as we should have (expected, actual) in any test comparison methods.\n\n_compare_images_and_uuids(uuids, images)","commit_id":"7e93dead4efaf672b50bdbdebfd4f4128c469248"}]}