)]}'
{"glance/common/utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"830081fc71d3a9ea9e3502b64bccbaa998f991a2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import sys"},{"line_number":38,"context_line":"import uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from glance_store.common.utils import exception_to_str   # noqa"},{"line_number":41,"context_line":"from OpenSSL import crypto"},{"line_number":42,"context_line":"from oslo_config import cfg"},{"line_number":43,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_cca545a2","line":40,"updated":"2015-06-24 22:54:49.000000000","message":"Any other way we could fix this issue?\n\nI\u0027m not happy with importing this from glance_store. After seeing this, I think we should make the utils package in glance_store private.","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f489f198eee1597546baf078eb302795544dcab7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import sys"},{"line_number":38,"context_line":"import uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from glance_store.common.utils import exception_to_str   # noqa"},{"line_number":41,"context_line":"from OpenSSL import crypto"},{"line_number":42,"context_line":"from oslo_config import cfg"},{"line_number":43,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f615b6e4","line":40,"updated":"2015-07-01 16:24:58.000000000","message":"I\u0027d prefer option 3 as well Victor. There\u0027s a patch in openstack/searchlight that did the same thing.","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"9bba4a862a5294475c8b5f0d2198a3ccba23e6d5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import sys"},{"line_number":38,"context_line":"import uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from glance_store.common.utils import exception_to_str   # noqa"},{"line_number":41,"context_line":"from OpenSSL import crypto"},{"line_number":42,"context_line":"from oslo_config import cfg"},{"line_number":43,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_2ec79313","line":40,"in_reply_to":"ba3cc151_7e44f8b5","updated":"2015-07-25 09:56:20.000000000","message":"https://review.openstack.org/#/c/197916/ \"Use oslo_utils.encodeutils.exception_to_unicode()\" has been removed.\n\nI removed the line \"from glance_store.common.utils import exception_to_str\".","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"10e960262633527c04139d810f3bc7e0221e1584","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import sys"},{"line_number":38,"context_line":"import uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from glance_store.common.utils import exception_to_str   # noqa"},{"line_number":41,"context_line":"from OpenSSL import crypto"},{"line_number":42,"context_line":"from oslo_config import cfg"},{"line_number":43,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7e44f8b5","line":40,"in_reply_to":"ba3cc151_bb55c7c2","updated":"2015-07-02 10:53:35.000000000","message":"Ok, I wrote https://review.openstack.org/#/c/197916/ to replace glance.common.utils.exception_to_str() with oslo_utils.encodeutils.exception_to_unicode().","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e066112d75d7cc2139ffaeca6188a55c58368589","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import sys"},{"line_number":38,"context_line":"import uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from glance_store.common.utils import exception_to_str   # noqa"},{"line_number":41,"context_line":"from OpenSSL import crypto"},{"line_number":42,"context_line":"from oslo_config import cfg"},{"line_number":43,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_bb55c7c2","line":40,"in_reply_to":"ba3cc151_f615b6e4","updated":"2015-07-01 22:37:22.000000000","message":"So we need oslo.utils 1.6. It looks like there are issues with the latest \"Updated from global requirements\" patch:\n\nhttps://review.openstack.org/#/c/186114/","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"a7a867357ee18ff7512e71cc208fccbd12032137","unresolved":false,"context_lines":[{"line_number":37,"context_line":"import sys"},{"line_number":38,"context_line":"import uuid"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"from glance_store.common.utils import exception_to_str   # noqa"},{"line_number":41,"context_line":"from OpenSSL import crypto"},{"line_number":42,"context_line":"from oslo_config import cfg"},{"line_number":43,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_c31dfd62","line":40,"in_reply_to":"fa32b979_cca545a2","updated":"2015-06-25 10:51:00.000000000","message":"Ah, I expected comments on this change :-) There are different options:\n\n1) fix exception_to_str() in glance\n\n2) remove exception_to_str() from glance.common.utils, and use glance_store.common.utils.exception_to_str() instead\n\n3) remove exception_to_str() from glance.common.utils, and use oslo_utils.encodeutils.exception_to_unicode() instead\n\nI prefer the option (3), Oslo is well tested and I prefer to reuse Oslo code than fixing issues in each project. What do you prefer?\n\nFor (3), I see that glance currently requires oslo.utils\u003e\u003d1.4.0. It needs to update requirements to global requirements which uses oslo.utils\u003e\u003d1.6.0. exception_to_unicode() is available in oslo.utils 1.6, but not in oslo.utils 1.4.","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"}],"glance/tests/unit/test_artifact_type_definition_framework.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"f489f198eee1597546baf078eb302795544dcab7","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.assertEqual(True, tt.address[2])"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # On Python 3, sort() fails because int (1) and string (\"20\") are not"},{"line_number":406,"context_line":"        # comparable"},{"line_number":407,"context_line":"        if six.PY2:"},{"line_number":408,"context_line":"            self.assertRaises(exc.InvalidArtifactPropertyValue,"},{"line_number":409,"context_line":"                              tt.address.sort)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_d618b220","line":406,"updated":"2015-07-01 16:24:58.000000000","message":"On Python 2 the comparison isn\u0027t correct either. Is there a bug filed for this? If not would you do the honors?","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b91673dd50c0790fb5e3962c9e7bf3a339d754a3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.assertEqual(True, tt.address[2])"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # On Python 3, sort() fails because int (1) and string (\"20\") are not"},{"line_number":406,"context_line":"        # comparable"},{"line_number":407,"context_line":"        if six.PY2:"},{"line_number":408,"context_line":"            self.assertRaises(exc.InvalidArtifactPropertyValue,"},{"line_number":409,"context_line":"                              tt.address.sort)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_14a34bb3","line":406,"in_reply_to":"ba3cc151_d618b220","updated":"2015-07-02 11:39:20.000000000","message":"\u003e On Python 2 the comparison isn\u0027t correct either.\n\nWell, technically, it *is* possible to compare integers and strings. Example of sort:\n\n\u003e\u003e\u003e sorted([1, \"2\", 3])\n[1, 3, \u00272\u0027]\n\nI\u0027m not sure that I understood your concern. Would you like to remove this test (the line currently only skipped on Python 3 in my test)?\n\nOr do you want to try to convert items into comparable types?","commit_id":"d14ba5310085cd8834798b939df0b3f6fa54c808"}]}