)]}'
{"glance/tests/unit/common/test_location_strategy.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"dbff9cc129b72de4735b3ad35ca193900a849ae9","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        loaded_modules \u003d location_strategy._load_strategies()"},{"line_number":70,"context_line":"        self.assertEqual(1, len(loaded_modules))"},{"line_number":71,"context_line":"        self.assertEqual(\u0027module_name\u0027, list(loaded_modules.keys())[0])"},{"line_number":72,"context_line":"        # Skipped module #2, duplicated one."},{"line_number":73,"context_line":"        self.assertEqual(\u0027module1\u0027, loaded_modules[\u0027module_name\u0027].__name__)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_9691ca49","line":71,"updated":"2015-07-01 16:27:13.000000000","message":"Wouldn\u0027t this test be better written as \n\n    self.assertIn(\u0027module_name\u0027, loaded_modules)\n\nIf we\u0027re asserting the length of the dictionary is 1, then asserting it\u0027s in there is better than this, no?","commit_id":"8ac16f1df93034338b6a7d3658b20c78329e37fb"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e950259ed6555bdde124493f4a23289b149204fb","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        loaded_modules \u003d location_strategy._load_strategies()"},{"line_number":70,"context_line":"        self.assertEqual(1, len(loaded_modules))"},{"line_number":71,"context_line":"        self.assertEqual(\u0027module_name\u0027, list(loaded_modules.keys())[0])"},{"line_number":72,"context_line":"        # Skipped module #2, duplicated one."},{"line_number":73,"context_line":"        self.assertEqual(\u0027module1\u0027, loaded_modules[\u0027module_name\u0027].__name__)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_884426b7","line":71,"in_reply_to":"ba3cc151_9691ca49","updated":"2015-07-02 10:10:22.000000000","message":"Sorry, I\u0027m a dumb robot! I don\u0027t read what I\u0027m writing :-p\n\nYou are completly read, the current code is overkill, assertIn() makes more sense, it\u0027s more readable, etc. And the previous line already checks the size of the dictionary.\n\nFixed in my new patchset.","commit_id":"8ac16f1df93034338b6a7d3658b20c78329e37fb"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"dbff9cc129b72de4735b3ad35ca193900a849ae9","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        loaded_modules \u003d location_strategy._load_strategies()"},{"line_number":100,"context_line":"        self.assertEqual(1, len(loaded_modules))"},{"line_number":101,"context_line":"        self.assertEqual(\u0027module_good\u0027, list(loaded_modules.keys())[0])"},{"line_number":102,"context_line":"        # Skipped module #1, initialize failed one."},{"line_number":103,"context_line":"        self.assertEqual(\u0027module_good\u0027, loaded_modules[\u0027module_good\u0027].__name__)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_b6964e3d","line":101,"updated":"2015-07-01 16:27:13.000000000","message":"Same here","commit_id":"8ac16f1df93034338b6a7d3658b20c78329e37fb"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e950259ed6555bdde124493f4a23289b149204fb","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        loaded_modules \u003d location_strategy._load_strategies()"},{"line_number":100,"context_line":"        self.assertEqual(1, len(loaded_modules))"},{"line_number":101,"context_line":"        self.assertEqual(\u0027module_good\u0027, list(loaded_modules.keys())[0])"},{"line_number":102,"context_line":"        # Skipped module #1, initialize failed one."},{"line_number":103,"context_line":"        self.assertEqual(\u0027module_good\u0027, loaded_modules[\u0027module_good\u0027].__name__)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_e8093285","line":101,"in_reply_to":"ba3cc151_b6964e3d","updated":"2015-07-02 10:10:22.000000000","message":"Done","commit_id":"8ac16f1df93034338b6a7d3658b20c78329e37fb"}]}