)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"03c5c369bb60c8f810b78ff328c696c722c110fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use more accurate message in image_date, image_memebers and image_tags v2 api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"glance v2 api is uses multiple proxies, the exceptions is thrown from those proxies and be handled in v2 api. The original message in exception is more accurate, we should show that original message to user, instead of making a common message which is not useful for end user. For example: when user attempts to create membership to a public image, currently he will get a message \"Not allowed to create members for image\", user doesn\u0027t get useful information. If we use the message from the original exception, it will show \"Public images do not have members\", it is more accurate."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug: 1469356"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a41bdd9_76ae8499","line":9,"updated":"2015-07-14 20:45:29.000000000","message":"Please break this long line into multiple separate lines that are wrapped at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"095fd0e40f9fc636dba3e01f6af4b171fcfa1ab9"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"24c47e0fc6d6152ec9fb4d8a2e263f54dc5f622b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use more accurate message in image_date, image_memebers and image_tags v2 api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"glance v2 api is uses multiple proxies, the exceptions is thrown from those proxies and be handled in v2 api. The original message in exception is more accurate, we should show that original message to user, instead of making a common message which is not useful for end user. For example: when user attempts to create membership to a public image, currently he will get a message \"Not allowed to create members for image\", user doesn\u0027t get useful information. If we use the message from the original exception, it will show \"Public images do not have members\", it is more accurate."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug: 1469356"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a41bdd9_f49cc2c1","line":9,"in_reply_to":"9a41bdd9_76ae8499","updated":"2015-07-15 02:08:50.000000000","message":"Done","commit_id":"095fd0e40f9fc636dba3e01f6af4b171fcfa1ab9"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"03c5c369bb60c8f810b78ff328c696c722c110fc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"glance v2 api is uses multiple proxies, the exceptions is thrown from those proxies and be handled in v2 api. The original message in exception is more accurate, we should show that original message to user, instead of making a common message which is not useful for end user. For example: when user attempts to create membership to a public image, currently he will get a message \"Not allowed to create members for image\", user doesn\u0027t get useful information. If we use the message from the original exception, it will show \"Public images do not have members\", it is more accurate."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug: 1469356"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifef05ed2eeb279c61fdbf6b777effae502f708f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a41bdd9_7612040b","line":11,"updated":"2015-07-14 20:45:29.000000000","message":"Please use \"Closes-Bug: #######\" instead.\n\nhttp://docs.openstack.org/infra/manual/developers.html#working-on-bugs","commit_id":"095fd0e40f9fc636dba3e01f6af4b171fcfa1ab9"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"24c47e0fc6d6152ec9fb4d8a2e263f54dc5f622b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"glance v2 api is uses multiple proxies, the exceptions is thrown from those proxies and be handled in v2 api. The original message in exception is more accurate, we should show that original message to user, instead of making a common message which is not useful for end user. For example: when user attempts to create membership to a public image, currently he will get a message \"Not allowed to create members for image\", user doesn\u0027t get useful information. If we use the message from the original exception, it will show \"Public images do not have members\", it is more accurate."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug: 1469356"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ifef05ed2eeb279c61fdbf6b777effae502f708f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a41bdd9_14a286fd","line":11,"in_reply_to":"9a41bdd9_7612040b","updated":"2015-07-15 02:08:50.000000000","message":"Done","commit_id":"095fd0e40f9fc636dba3e01f6af4b171fcfa1ab9"}],"glance/api/v2/image_data.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f0d5af75d8f9858efa11389476a70adb94e4b5f3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                image.set_data(data, size)"},{"line_number":75,"context_line":"                image_repo.save(image, from_state\u003d\u0027saving\u0027)"},{"line_number":76,"context_line":"            except (exception.ImageNotFound, exception.Conflict) as e:"},{"line_number":77,"context_line":"                msg \u003d (_(\"Image %s could not be found after upload. \""},{"line_number":78,"context_line":"                         \"The image may have been deleted during the \""},{"line_number":79,"context_line":"                         \"upload, cleaning up the chunks uploaded.\") %"},{"line_number":80,"context_line":"                       image_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_8ccd4c33","line":77,"updated":"2015-07-27 23:48:28.000000000","message":"This would not be anymore exception message so the translation priority needs to change (applies to every one of these changes).","commit_id":"c0caf499e5beeaaaaeff62aeb3cd06bee7cee18b"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"e13b16f3b737074c05de8934703bebbff55ccfb9","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                image.set_data(data, size)"},{"line_number":75,"context_line":"                image_repo.save(image, from_state\u003d\u0027saving\u0027)"},{"line_number":76,"context_line":"            except (exception.ImageNotFound, exception.Conflict) as e:"},{"line_number":77,"context_line":"                msg \u003d (_(\"Image %s could not be found after upload. \""},{"line_number":78,"context_line":"                         \"The image may have been deleted during the \""},{"line_number":79,"context_line":"                         \"upload, cleaning up the chunks uploaded.\") %"},{"line_number":80,"context_line":"                       image_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_61730581","line":77,"in_reply_to":"3a50d1a3_8ccd4c33","updated":"2015-07-28 15:11:01.000000000","message":"Thanks for your comments. I went through v2/medadef_*.py,  they are well done in exception, I could use it same way in image_data.py. I think it\u0027s better to use message from the lower level api where the exception occurs, it is easy to maintain just one copy of message.  It may be not necessary to log this kinds of message, I can remove the logs , do you think so ?","commit_id":"c0caf499e5beeaaaaeff62aeb3cd06bee7cee18b"}]}