)]}'
{"glance/db/sqlalchemy/migrate_repo/versions/042_add_task_trigger_table.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1a22dcbb9b517cb57484adce6a2afa33ff604c5d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_a6605ea6","line":3,"updated":"2015-08-05 18:42:45.000000000","message":"Super Nit: Copyright 2013 IBM Corp- Need it ?","commit_id":"d4cad725e83913851f60bb4b57a5835f84460c77"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1a22dcbb9b517cb57484adce6a2afa33ff604c5d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                         nullable\u003dFalse,"},{"line_number":36,"context_line":"                         default\u003dFalse),"},{"line_number":37,"context_line":"                  mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":38,"context_line":"                  extend_existing\u003dTrue)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    Index(\u0027ix_task_trigger_type\u0027, tasks.c.type)"},{"line_number":41,"context_line":"    Index(\u0027ix_task_trigger_owner\u0027, tasks.c.owner)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_0302640b","line":38,"updated":"2015-08-05 18:42:45.000000000","message":"can you add mysql_charset to utf8 ?. I don\u0027t think it will pass the tests on the next run. So heads-up :)","commit_id":"d4cad725e83913851f60bb4b57a5835f84460c77"}],"glance/db/sqlalchemy/models.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"ad069d9889ad1998c506ea001869dd1a044b0079","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    type \u003d Column(String(30), nullable\u003dFalse)"},{"line_number":262,"context_line":"    owner \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":263,"context_line":"    input \u003d Column(JSONEncodedDict())"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def register_models(engine):"},{"line_number":267,"context_line":"    \"\"\"Create database tables for all models with the given engine.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_d00ffd36","line":264,"updated":"2015-07-09 17:11:17.000000000","message":"Per the spec, don\u0027t we need an \u0027action\u0027 field in the TaskTrigger ? \n\nAlso, how do we associate a trigger task with multiple actions like \u0027image_create\u0027, \u0027image_delete\u0027 etc. ?","commit_id":"176989fc6c0a0b75c2495a0edc202efb7c4eaf36"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"ae97b6a24961e6c4620a6bc454fc1081255007c8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    type \u003d Column(String(30), nullable\u003dFalse)"},{"line_number":262,"context_line":"    owner \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":263,"context_line":"    input \u003d Column(JSONEncodedDict())"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def register_models(engine):"},{"line_number":267,"context_line":"    \"\"\"Create database tables for all models with the given engine.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_4695da3c","line":264,"in_reply_to":"1a4dcd0f_3a41f1a9","updated":"2015-08-05 18:43:35.000000000","message":"ok, I thought it would be type of the \u0027Task\u0027 that it\u0027s supposed to trigger. I assume that information will be part of the input json ?","commit_id":"176989fc6c0a0b75c2495a0edc202efb7c4eaf36"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7ada68da17b7ad9b5a0c4a91d0feef18f126388b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    type \u003d Column(String(30), nullable\u003dFalse)"},{"line_number":262,"context_line":"    owner \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":263,"context_line":"    input \u003d Column(JSONEncodedDict())"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def register_models(engine):"},{"line_number":267,"context_line":"    \"\"\"Create database tables for all models with the given engine.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_0853cf6d","line":264,"in_reply_to":"1a4dcd0f_4695da3c","updated":"2015-08-14 08:41:23.000000000","message":"actually, you\u0027re right. We need a action (I prefer trigger) field here. type must reflect the `Task` type.","commit_id":"176989fc6c0a0b75c2495a0edc202efb7c4eaf36"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"851a98eeed43c54506d97bd5c2ca851274079ca8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    type \u003d Column(String(30), nullable\u003dFalse)"},{"line_number":262,"context_line":"    owner \u003d Column(String(255), nullable\u003dFalse)"},{"line_number":263,"context_line":"    input \u003d Column(JSONEncodedDict())"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"def register_models(engine):"},{"line_number":267,"context_line":"    \"\"\"Create database tables for all models with the given engine.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_3a41f1a9","line":264,"in_reply_to":"ba3cc151_d00ffd36","updated":"2015-08-05 01:25:24.000000000","message":"That\u0027d be `type`. We\u0027re using that field for the task \u0027type/action\u0027 in `Task` and I kept the name to be consistent.","commit_id":"176989fc6c0a0b75c2495a0edc202efb7c4eaf36"}]}
