)]}'
{"glance/tests/functional/test_wsgi.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"88586ef449df974b62703e78bd650a3fb0c217f7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        server \u003d wsgi.Server()"},{"line_number":42,"context_line":"        server.start(hello_world, 0)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        def create_new_connection_with_delay(delay\u003d0.0):"},{"line_number":45,"context_line":"            sock \u003d socket.socket()"},{"line_number":46,"context_line":"            sock.connect((\u0027127.0.0.1\u0027, server.sock.getsockname()[1]))"},{"line_number":47,"context_line":"            time.sleep(delay)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_46a10945","line":44,"updated":"2015-07-03 00:02:40.000000000","message":"This name isn\u0027t exactly accurate. You\u0027re not creating a connection and returning it. Why not call it\n\n    def get_request_with_delay(delay\u003d0.0):\n        # ...\n        if delay \u003e 0:\n            time.sleep(delay)\n        # ...","commit_id":"b22c03c807132270ff16db959ed936cb35b61d08"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8312483fcaf72df7a18d1fafd9e6dbdace24fddc","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        server \u003d wsgi.Server()"},{"line_number":43,"context_line":"        server.start(hello_world, 0)"},{"line_number":44,"context_line":"        port \u003d server.sock.getsockname()[1]"},{"line_number":45,"context_line":"        sock1 \u003d socket.socket()"},{"line_number":46,"context_line":"        sock1.connect((\"127.0.0.1\", port))"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_996be11d","side":"PARENT","line":44,"updated":"2015-07-03 11:10:20.000000000","message":"This was much more readable.","commit_id":"737be8dd51466b93149d032e57933020beef9b97"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8312483fcaf72df7a18d1fafd9e6dbdace24fddc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return sock.recv(1024)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Should succeed - no timeout"},{"line_number":52,"context_line":"        self.assertTrue(greetings in get_request_with_delay())"},{"line_number":53,"context_line":"        # Should fail - connection timed out so we get nothing from the server"},{"line_number":54,"context_line":"        self.assertFalse(get_request_with_delay(0.2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_b99d850b","line":52,"updated":"2015-07-03 11:10:20.000000000","message":"I\u0027m not convinced about the function name and the reaadability here. We call get_request_with_delay() which per default does not have delay.","commit_id":"e5e360c5880b5f00372371cdd8b4893332b42f63"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"585f65e1e7024712e5c12cd86231c4101c14ca41","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return sock.recv(1024)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Should succeed - no timeout"},{"line_number":52,"context_line":"        self.assertTrue(greetings in get_request_with_delay())"},{"line_number":53,"context_line":"        # Should fail - connection timed out so we get nothing from the server"},{"line_number":54,"context_line":"        self.assertFalse(get_request_with_delay(0.2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_54d7f0be","line":52,"in_reply_to":"ba3cc151_8392809e","updated":"2015-07-07 13:00:17.000000000","message":"The current naming does not specify where the delay is either.","commit_id":"e5e360c5880b5f00372371cdd8b4893332b42f63"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"6a945dfb2219115101651e90634e06e62ee312ae","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            return sock.recv(1024)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        # Should succeed - no timeout"},{"line_number":52,"context_line":"        self.assertTrue(greetings in get_request_with_delay())"},{"line_number":53,"context_line":"        # Should fail - connection timed out so we get nothing from the server"},{"line_number":54,"context_line":"        self.assertFalse(get_request_with_delay(0.2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_8392809e","line":52,"in_reply_to":"ba3cc151_b99d850b","updated":"2015-07-03 16:49:50.000000000","message":"Ok, but if we call this function like this: \"get_request(delay\u003d0.0)\", as the name is not clear exactly where there is a delay, in any case, have to see that the method code to understand how it works, I think this does not make sense to rename this function.","commit_id":"e5e360c5880b5f00372371cdd8b4893332b42f63"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8312483fcaf72df7a18d1fafd9e6dbdace24fddc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        # Should succeed - no timeout"},{"line_number":52,"context_line":"        self.assertTrue(greetings in get_request_with_delay())"},{"line_number":53,"context_line":"        # Should fail - connection timed out so we get nothing from the server"},{"line_number":54,"context_line":"        self.assertFalse(get_request_with_delay(0.2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_19c271e9","line":54,"updated":"2015-07-03 11:10:20.000000000","message":"at least call it get_request_with_delay(delay\u003d0.2) for clarity \u0026 readability.","commit_id":"e5e360c5880b5f00372371cdd8b4893332b42f63"},{"author":{"_account_id":16683,"name":"Alexey Galkin","email":"agalkin@mirantis.com","username":"agalkin"},"change_message_id":"6a945dfb2219115101651e90634e06e62ee312ae","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        # Should succeed - no timeout"},{"line_number":52,"context_line":"        self.assertTrue(greetings in get_request_with_delay())"},{"line_number":53,"context_line":"        # Should fail - connection timed out so we get nothing from the server"},{"line_number":54,"context_line":"        self.assertFalse(get_request_with_delay(0.2))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_836e0095","line":54,"in_reply_to":"ba3cc151_19c271e9","updated":"2015-07-03 16:49:50.000000000","message":"I think that this method has a single argument, and on the basis of the current title is obvious that the argument is delay.","commit_id":"e5e360c5880b5f00372371cdd8b4893332b42f63"}]}