)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"afd7749977426518a45b96b840dbc9fb83cea90d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the image is not active, there is no data for download. Glance will throw an exception."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug 1472449"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie5d7eff8142f1824b880bbff723d6204eeb391c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_cb1d1a63","line":11,"updated":"2015-07-09 15:04:54.000000000","message":"The correct syntax is\n\n    Closes-bug: 1472449","commit_id":"8b6b02478da981c7f3167fe857df7ca57ad81225"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"20541b18e9e369a391690521e23c6989c780e954","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the image is not active, there is no data for download. Glance will throw an exception."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Fixes Bug 1472449"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie5d7eff8142f1824b880bbff723d6204eeb391c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba3cc151_eee82c7d","line":11,"in_reply_to":"ba3cc151_cb1d1a63","updated":"2015-07-15 02:09:56.000000000","message":"Done","commit_id":"8b6b02478da981c7f3167fe857df7ca57ad81225"}],"glance/api/v2/image_data.py":[{"author":{"_account_id":13747,"name":"Kuo-tung Kao","email":"jelly.k@inwinstack.com","username":"coding1314"},"change_message_id":"ee14ca1cc93116a8fd3694d1dca8b4d6f7670b4f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                raise exception.Forbidden(message\u003dmsg)"},{"line_number":176,"context_line":"            elif image.status !\u003d \u0027active\u0027:"},{"line_number":177,"context_line":"                msg \u003d _(\"Image %s is not active\") % image_id"},{"line_number":178,"context_line":"                raise exception.NotFound(message\u003dmsg)"},{"line_number":179,"context_line":"            if not image.locations:"},{"line_number":180,"context_line":"                raise exception.ImageDataNotFound()"},{"line_number":181,"context_line":"        except exception.ImageDataNotFound as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_e2f9784f","line":178,"updated":"2015-07-08 09:19:27.000000000","message":"IMO. What about exception.ImageDataNotFound instead of exception.NotFound?","commit_id":"8b6b02478da981c7f3167fe857df7ca57ad81225"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"afd7749977426518a45b96b840dbc9fb83cea90d","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                raise exception.Forbidden(message\u003dmsg)"},{"line_number":176,"context_line":"            elif image.status !\u003d \u0027active\u0027:"},{"line_number":177,"context_line":"                msg \u003d _(\"Image %s is not active\") % image_id"},{"line_number":178,"context_line":"                raise exception.NotFound(message\u003dmsg)"},{"line_number":179,"context_line":"            if not image.locations:"},{"line_number":180,"context_line":"                raise exception.ImageDataNotFound()"},{"line_number":181,"context_line":"        except exception.ImageDataNotFound as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_eb201e9c","line":178,"updated":"2015-07-09 15:04:54.000000000","message":"That\u0027s a good point. I\u0027m not sure which exactly is more correct. Glance could have the image data but may not have updated the status yet. If that\u0027s the case, ImageDataNotFound isn\u0027t exactly correct.","commit_id":"8b6b02478da981c7f3167fe857df7ca57ad81225"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"20541b18e9e369a391690521e23c6989c780e954","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                raise exception.Forbidden(message\u003dmsg)"},{"line_number":176,"context_line":"            elif image.status !\u003d \u0027active\u0027:"},{"line_number":177,"context_line":"                msg \u003d _(\"Image %s is not active\") % image_id"},{"line_number":178,"context_line":"                raise exception.NotFound(message\u003dmsg)"},{"line_number":179,"context_line":"            if not image.locations:"},{"line_number":180,"context_line":"                raise exception.ImageDataNotFound()"},{"line_number":181,"context_line":"        except exception.ImageDataNotFound as e:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba3cc151_a8c83123","line":178,"in_reply_to":"ba3cc151_e2f9784f","updated":"2015-07-15 02:09:56.000000000","message":"Thanks for your comments. I just follow the v1 api which use HTTPNotFound, it is consistent with v1. If use ImageDataNotFound, it will then return HTTPNoContent, the means the request is successful, just without body content. While HTTPNotFound is an error, it means the request is failed,\nuser can\u0027t download image data when the image is not active.","commit_id":"8b6b02478da981c7f3167fe857df7ca57ad81225"}]}