)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f1e86fbf57a43b4fd42dfd2e9ab498c0187f5c4c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix wrong check with locations in api v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create a image with api v2, the parameter \u0027locations\u0027"},{"line_number":10,"context_line":"is in the \u0027extra_properties\u0027 dict.So,we should get them from"},{"line_number":11,"context_line":"extra_properties."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I237935c311ccfb3298b3809029730a5104bc737f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a50d1a3_a898df78","line":10,"updated":"2015-07-23 10:57:43.000000000","message":"Add a single space after completion of sentence.","commit_id":"d3256a2030c779e468edbc4de62b79eb5dbb8aa2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"accc5e34c5b3bf059f9d336f62d9083b609df465","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix wrong check with locations in api v2"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When create a image with api v2, the parameter \u0027locations\u0027"},{"line_number":10,"context_line":"is in the \u0027extra_properties\u0027 dict.So,we should get them from"},{"line_number":11,"context_line":"extra_properties."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I237935c311ccfb3298b3809029730a5104bc737f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a50d1a3_6bbdf100","line":10,"in_reply_to":"3a50d1a3_a898df78","updated":"2015-07-23 11:11:48.000000000","message":"I\u0027ll fix it later.Thanks very much.","commit_id":"d3256a2030c779e468edbc4de62b79eb5dbb8aa2"}],"glance/location.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f1e86fbf57a43b4fd42dfd2e9ab498c0187f5c4c","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def new_image(self, **kwargs):"},{"line_number":136,"context_line":"        locations \u003d []"},{"line_number":137,"context_line":"        extra_properties \u003d kwargs.get(\u0027extra_properties\u0027, [])"},{"line_number":138,"context_line":"        if extra_properties:"},{"line_number":139,"context_line":"            locations \u003d extra_properties.pop(\u0027locations\u0027, [])"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_c87a0b24","line":137,"updated":"2015-07-23 10:57:43.000000000","message":"default should be {} IMO","commit_id":"d3256a2030c779e468edbc4de62b79eb5dbb8aa2"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3fa47f89e91ed6652adb607c2c51c4a6ff041e47","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def new_image(self, **kwargs):"},{"line_number":136,"context_line":"        locations \u003d []"},{"line_number":137,"context_line":"        extra_properties \u003d kwargs.get(\u0027extra_properties\u0027, [])"},{"line_number":138,"context_line":"        if extra_properties:"},{"line_number":139,"context_line":"            locations \u003d extra_properties.pop(\u0027locations\u0027, [])"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_eb6b41ef","line":137,"in_reply_to":"3a50d1a3_ab445949","updated":"2015-07-23 11:22:13.000000000","message":"you are getting \u0027extra_properties\u0027 from kwargs at line #137 which is dict.","commit_id":"d3256a2030c779e468edbc4de62b79eb5dbb8aa2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"accc5e34c5b3bf059f9d336f62d9083b609df465","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def new_image(self, **kwargs):"},{"line_number":136,"context_line":"        locations \u003d []"},{"line_number":137,"context_line":"        extra_properties \u003d kwargs.get(\u0027extra_properties\u0027, [])"},{"line_number":138,"context_line":"        if extra_properties:"},{"line_number":139,"context_line":"            locations \u003d extra_properties.pop(\u0027locations\u0027, [])"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_ab445949","line":137,"in_reply_to":"3a50d1a3_c87a0b24","updated":"2015-07-23 11:11:48.000000000","message":"https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L912\nFrom the code, I think locations is a array. It may contain some locations dict.","commit_id":"d3256a2030c779e468edbc4de62b79eb5dbb8aa2"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"295c769018022d81a552417b9cd18b9a03bc35fd","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def new_image(self, **kwargs):"},{"line_number":136,"context_line":"        locations \u003d []"},{"line_number":137,"context_line":"        extra_properties \u003d kwargs.get(\u0027extra_properties\u0027, [])"},{"line_number":138,"context_line":"        if extra_properties:"},{"line_number":139,"context_line":"            locations \u003d extra_properties.pop(\u0027locations\u0027, [])"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_11701aa3","line":137,"in_reply_to":"3a50d1a3_eb6b41ef","updated":"2015-07-23 11:45:33.000000000","message":"Right, It\u0027s my mistake. Thanks very much","commit_id":"d3256a2030c779e468edbc4de62b79eb5dbb8aa2"}]}