)]}'
{"glance/api/v2/tasks.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"965003cba09306be8abe1cc8ea1edbc9a94281d9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            LOG.warn(msg)"},{"line_number":77,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":78,"context_line":"        except exception.InvalidParameterValue as e:"},{"line_number":79,"context_line":"            msg \u003d (_LW(\"Invalid parameter values for creating task : \""},{"line_number":80,"context_line":"                   \"%(reason)s\")"},{"line_number":81,"context_line":"                   % {\u0027reason\u0027: utils.exception_to_str(e)})"},{"line_number":82,"context_line":"            LOG.warn(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_c4d3e75e","line":79,"updated":"2015-07-15 16:50:27.000000000","message":"Same.","commit_id":"e332815f3391514f2e2063bfde9aaa56a0482e9b"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"60e2a97236b1e8d2bd0969c4a0c36be5d08ffaf1","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            LOG.warn(msg)"},{"line_number":77,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"},{"line_number":78,"context_line":"        except exception.InvalidParameterValue as e:"},{"line_number":79,"context_line":"            msg \u003d (_LW(\"Invalid parameter values for creating task : \""},{"line_number":80,"context_line":"                   \"%(reason)s\")"},{"line_number":81,"context_line":"                   % {\u0027reason\u0027: utils.exception_to_str(e)})"},{"line_number":82,"context_line":"            LOG.warn(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_86e1502c","line":79,"in_reply_to":"9a41bdd9_c4d3e75e","updated":"2015-07-16 02:34:35.000000000","message":"but this code does capture the exception, and the error message is returned to glance client.","commit_id":"e332815f3391514f2e2063bfde9aaa56a0482e9b"}],"glance/common/scripts/utils.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"965003cba09306be8abe1cc8ea1edbc9a94281d9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    for key in [\"import_from\", \"import_from_format\", \"image_properties\"]:"},{"line_number":63,"context_line":"        if key not in task_input:"},{"line_number":64,"context_line":"            msg \u003d _(\"Input does not contain \u0027%(key)s\u0027 field\") % {\"key\": key}"},{"line_number":65,"context_line":"            raise exception.InvalidParameterValue(msg)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return task_input"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_449a77ba","line":65,"updated":"2015-07-15 16:50:27.000000000","message":"This is more of a missing parameter than \u0027invalid\u0027 parameter. And, it is also not about the parameter value as such. \n\nThe validation here is to ensure task input contains certain necessary parameters.","commit_id":"e332815f3391514f2e2063bfde9aaa56a0482e9b"},{"author":{"_account_id":15501,"name":"Long Quan Sha","email":"shalq@cn.ibm.com","username":"shalq"},"change_message_id":"60e2a97236b1e8d2bd0969c4a0c36be5d08ffaf1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    for key in [\"import_from\", \"import_from_format\", \"image_properties\"]:"},{"line_number":63,"context_line":"        if key not in task_input:"},{"line_number":64,"context_line":"            msg \u003d _(\"Input does not contain \u0027%(key)s\u0027 field\") % {\"key\": key}"},{"line_number":65,"context_line":"            raise exception.InvalidParameterValue(msg)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return task_input"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_86b3904c","line":65,"in_reply_to":"9a41bdd9_449a77ba","updated":"2015-07-16 02:34:35.000000000","message":"I can create another exception with appropriate name . Done","commit_id":"e332815f3391514f2e2063bfde9aaa56a0482e9b"}]}