)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"07e73ba1c50e11c87b4b6f027a398166c1ccd844","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix default value with postgreSQL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When use \u0027sort-key\u003dsize\u0027 for muti-pages searching with postgreSQL"},{"line_number":10,"context_line":"DB, it will rasie an error: HTTPInternalServerError (HTTP 500)."},{"line_number":11,"context_line":"The reason is that postgreSQL doesn\u0027t support the size\u0027s default value"},{"line_number":12,"context_line":"to be string. This patch set the size\u0027s default value to zero."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_39c159e5","line":9,"updated":"2015-09-14 08:51:20.000000000","message":"multi","commit_id":"e5af8eaea66c3f81be1a9a35a835c36c76a7bd2f"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"07e73ba1c50e11c87b4b6f027a398166c1ccd844","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix default value with postgreSQL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When use \u0027sort-key\u003dsize\u0027 for muti-pages searching with postgreSQL"},{"line_number":10,"context_line":"DB, it will rasie an error: HTTPInternalServerError (HTTP 500)."},{"line_number":11,"context_line":"The reason is that postgreSQL doesn\u0027t support the size\u0027s default value"},{"line_number":12,"context_line":"to be string. This patch set the size\u0027s default value to zero."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba15a1d1_d9b5bd7e","line":10,"updated":"2015-09-14 08:51:20.000000000","message":"raise","commit_id":"e5af8eaea66c3f81be1a9a35a835c36c76a7bd2f"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"45e5c4d76afcd636bca367eaa277e498fab993e1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix default value with postgreSQL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When use \u0027sort-key\u003dsize\u0027 for multi-pages searching with postgreSQL"},{"line_number":10,"context_line":"DB, it will raise an error: HTTPInternalServerError (HTTP 500)."},{"line_number":11,"context_line":"The reason is that postgreSQL doesn\u0027t support the size\u0027s default value"},{"line_number":12,"context_line":"to be string. This patch set the size\u0027s default value to zero."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a740942_99e2ce9e","line":10,"updated":"2015-12-03 22:50:32.000000000","message":"Technically, DB wrapper (here sqlalchemy) will raise a type error. This will be caught at some layer in the stack that will result into 500 (HTTPInternalServerError).","commit_id":"0d772cbc4d302fa6d0bcac8b8ae4d4ee6c200e43"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3f4a3a36c254d97808860d44480f5c520c4c1d01","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix default value with postgreSQL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When use \u0027sort-key\u003dsize\u0027 for multi-pages searching with postgreSQL"},{"line_number":10,"context_line":"DB, it will raise an error: HTTPInternalServerError (HTTP 500)."},{"line_number":11,"context_line":"The reason is that postgreSQL doesn\u0027t support the size\u0027s default value"},{"line_number":12,"context_line":"to be string. This patch set the size\u0027s default value to zero."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a740942_f268c4bc","line":10,"in_reply_to":"7a740942_99e2ce9e","updated":"2015-12-04 01:34:49.000000000","message":"Yes, In this case, It raised DBError(psycopg2.DataError--psycopg2 is a postgreDB lib). I will update the commit message later. And I think we could handle DBError in another patch to fix this kind of 500 Error .","commit_id":"0d772cbc4d302fa6d0bcac8b8ae4d4ee6c200e43"}],"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"af20d0841ac29477abbc126210120581e1019480","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                default \u003d None if isinstance("},{"line_number":376,"context_line":"                    model_attr.property.columns[0].type,"},{"line_number":377,"context_line":"                    sqlalchemy.DateTime) else 0 if isinstance("},{"line_number":378,"context_line":"                    model_attr.property.columns[0].type,"},{"line_number":379,"context_line":"                    sqlalchemy.BigInteger) else \u0027\u0027"},{"line_number":380,"context_line":"                attr \u003d sa_sql.expression.case([(model_attr !\u003d None,"},{"line_number":381,"context_line":"                                              model_attr), ],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_9ab70ef5","line":378,"updated":"2015-08-14 15:41:39.000000000","message":"I wouldn\u0027t recommend to use ternary operation here because it decreases code readability. Could you please changes this to more readable approach:\nif ..\n\nelif\n\nelse:\n\nAlso it had better to comment why we introduced this default value here because other folks will spend some time to realizing this.","commit_id":"85898413718c9a66c61aef4a39b691932e3af9e2"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"5fab4b80f88a443fe2f841d09b3e8178074c3cc8","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                          sqlalchemy.DateTime):"},{"line_number":391,"context_line":"                default \u003d None"},{"line_number":392,"context_line":"            elif isinstance(model_attr.property.columns[0].type,"},{"line_number":393,"context_line":"                            sqlalchemy.BigInteger):"},{"line_number":394,"context_line":"                default \u003d 0"},{"line_number":395,"context_line":"            attr \u003d sa_sql.expression.case([(model_attr !\u003d None,"},{"line_number":396,"context_line":"                                          model_attr), ],"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_2aba5d72","line":393,"updated":"2015-09-08 15:15:31.000000000","message":"Shouldn\u0027t we do the same for sqlalchemy.Integer here ?","commit_id":"061dd3ac9eab65f437c582d104f4c2c7e0ae6410"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"89e09f97642e8efdf03d3356fed568c44aa84d9a","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                          sqlalchemy.DateTime):"},{"line_number":391,"context_line":"                default \u003d None"},{"line_number":392,"context_line":"            elif isinstance(model_attr.property.columns[0].type,"},{"line_number":393,"context_line":"                            sqlalchemy.BigInteger):"},{"line_number":394,"context_line":"                default \u003d 0"},{"line_number":395,"context_line":"            attr \u003d sa_sql.expression.case([(model_attr !\u003d None,"},{"line_number":396,"context_line":"                                          model_attr), ],"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_ea676fb5","line":393,"in_reply_to":"da20952f_2aba5d72","updated":"2015-09-09 01:27:15.000000000","message":"because sort-key only support : \u0027name\u0027, \u0027status\u0027, \u0027container_format\u0027, \u0027disk_format\u0027, \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027. Only size is BigInteger,others are string or datatime. So I think it\u0027s no need for sqlalchemy.Integer.","commit_id":"061dd3ac9eab65f437c582d104f4c2c7e0ae6410"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"443d396a6af6f4fb47d16d76ff66a4236225f989","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                default \u003d None"},{"line_number":392,"context_line":"            elif isinstance(model_attr.property.columns[0].type,"},{"line_number":393,"context_line":"                            sqlalchemy.BigInteger):"},{"line_number":394,"context_line":"                default \u003d 0"},{"line_number":395,"context_line":"            attr \u003d sa_sql.expression.case([(model_attr !\u003d None,"},{"line_number":396,"context_line":"                                          model_attr), ],"},{"line_number":397,"context_line":"                                          else_\u003ddefault)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a2fa921_3d8f1077","line":394,"updated":"2015-10-12 07:37:25.000000000","message":"to avoid duplication, adding a new private method _get_default_value will be beneficial IMO","commit_id":"aae515e523f3e5b0bb17697b852f72893339d749"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d635d1d938b40aa9f353797b9162f3116a5da199","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    return False"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def _get_default_column_value(column_type):"},{"line_number":297,"context_line":"    \"\"\"Return the default value of the columns from DB table\"\"\""},{"line_number":298,"context_line":"    if isinstance(column_type, sqlalchemy.DateTime):"},{"line_number":299,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba8a016a_b725675d","line":296,"updated":"2015-11-16 11:46:15.000000000","message":"Can we have a constant dict w/ all the default values instead of this function with `if` statements?\n\nI\u0027d guess in the future more things will be added.","commit_id":"8df3f716735fd9f540ff5abb2ce2bab844538f11"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"45e5c4d76afcd636bca367eaa277e498fab993e1","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def _get_default_column_value(column_type):"},{"line_number":297,"context_line":"    \"\"\"Return the default value of the columns from DB table\"\"\""},{"line_number":298,"context_line":"    type_schema \u003d {"},{"line_number":299,"context_line":"        \u0027datetime\u0027: None,"},{"line_number":300,"context_line":"        \u0027big_integer\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_f982f2c7","line":297,"updated":"2015-12-03 22:50:32.000000000","message":"Can you please add a note here to explain why such defaults are being set?\n\nI would feel bad for someone who has no context around this to come here and check these defaults without knowing about postgres. They may even bother to revert it or get confused it it doesn\u0027t work with their \u003cAdd a random DB type\u003e database.","commit_id":"0d772cbc4d302fa6d0bcac8b8ae4d4ee6c200e43"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"3f4a3a36c254d97808860d44480f5c520c4c1d01","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def _get_default_column_value(column_type):"},{"line_number":297,"context_line":"    \"\"\"Return the default value of the columns from DB table\"\"\""},{"line_number":298,"context_line":"    type_schema \u003d {"},{"line_number":299,"context_line":"        \u0027datetime\u0027: None,"},{"line_number":300,"context_line":"        \u0027big_integer\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a740942_d25fc80c","line":297,"in_reply_to":"7a740942_f982f2c7","updated":"2015-12-04 01:34:49.000000000","message":"Done","commit_id":"0d772cbc4d302fa6d0bcac8b8ae4d4ee6c200e43"}]}