)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"9cd7e9364b6388911e5d0a7a10e339b30c53d61f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Horizon dashboard). If the file is loaded successfully, a log message like"},{"line_number":12,"context_line":"the following is printed:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2015-08-09 11:48:34.713 INFO glance.db.sqlalchemy.metadata [-]"},{"line_number":15,"context_line":"File /etc/glance/metadefs/operating-system.json loaded to database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"However, if there is an error loading the file, we get a log message like:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_d75edb11","line":14,"updated":"2015-08-10 06:14:23.000000000","message":"Timestamps is unneeded details. Please remove them.","commit_id":"4e4613ef1337d8b0042944010507399edb4b75b6"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"225fa5c983d31033848d600b27dbee74a6f6e199","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Horizon dashboard). If the file is loaded successfully, a log message like"},{"line_number":12,"context_line":"the following is printed:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2015-08-09 11:48:34.713 INFO glance.db.sqlalchemy.metadata [-]"},{"line_number":15,"context_line":"File /etc/glance/metadefs/operating-system.json loaded to database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"However, if there is an error loading the file, we get a log message like:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_3a5aebf2","line":14,"in_reply_to":"1a4dcd0f_d75edb11","updated":"2015-08-21 00:25:39.000000000","message":"Listing the entire log line rather than just a part of it makes it more clear IMO.","commit_id":"4e4613ef1337d8b0042944010507399edb4b75b6"}],"glance/db/sqlalchemy/metadata.py":[{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"81646163ed5de3d51d428cefe262b6b61ed2db81","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            with open(file) as json_file:"},{"line_number":209,"context_line":"                metadata \u003d json.load(json_file)"},{"line_number":210,"context_line":"        except Exception as e:"},{"line_number":211,"context_line":"            LOG.error(_LE(\"File %(file_path)s: %(error_msg)s\"),"},{"line_number":212,"context_line":"                      {\"file_path\": file,"},{"line_number":213,"context_line":"                       \"error_msg\": encodeutils.exception_to_unicode(e)})"},{"line_number":214,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_d747bb49","line":211,"updated":"2015-08-10 06:12:48.000000000","message":"\"Couldn\u0027t encode file %(file_path)s during populating metadata due to: %(error_msg)s\" I thing such message would be better.","commit_id":"4e4613ef1337d8b0042944010507399edb4b75b6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ca4750a2045fdf3ae5bcf24b6ab59a1f03fd4dc9","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            with open(file) as json_file:"},{"line_number":209,"context_line":"                metadata \u003d json.load(json_file)"},{"line_number":210,"context_line":"        except Exception as e:"},{"line_number":211,"context_line":"            LOG.error(_LE(\"File %(file_path)s: %(error_msg)s\"),"},{"line_number":212,"context_line":"                      {\"file_path\": file,"},{"line_number":213,"context_line":"                       \"error_msg\": encodeutils.exception_to_unicode(e)})"},{"line_number":214,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_5c95bee1","line":211,"in_reply_to":"1a4dcd0f_d747bb49","updated":"2015-08-11 13:33:07.000000000","message":"+1","commit_id":"4e4613ef1337d8b0042944010507399edb4b75b6"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"225fa5c983d31033848d600b27dbee74a6f6e199","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            with open(file) as json_file:"},{"line_number":209,"context_line":"                metadata \u003d json.load(json_file)"},{"line_number":210,"context_line":"        except Exception as e:"},{"line_number":211,"context_line":"            LOG.error(_LE(\"File %(file_path)s: %(error_msg)s\"),"},{"line_number":212,"context_line":"                      {\"file_path\": file,"},{"line_number":213,"context_line":"                       \"error_msg\": encodeutils.exception_to_unicode(e)})"},{"line_number":214,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_9a5457ca","line":211,"in_reply_to":"1a4dcd0f_d747bb49","updated":"2015-08-21 00:25:39.000000000","message":"Done","commit_id":"4e4613ef1337d8b0042944010507399edb4b75b6"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"e81f29cda802147a9467d0b5701fc36ac8434e7f","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            with open(file) as json_file:"},{"line_number":209,"context_line":"                metadata \u003d json.load(json_file)"},{"line_number":210,"context_line":"        except Exception as e:"},{"line_number":211,"context_line":"            LOG.error(_LE(\"File %(file_path)s: %(error_msg)s\"),"},{"line_number":212,"context_line":"                      {\"file_path\": file,"},{"line_number":213,"context_line":"                       \"error_msg\": encodeutils.exception_to_unicode(e)})"},{"line_number":214,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_e39ac661","line":211,"in_reply_to":"1a4dcd0f_d747bb49","updated":"2015-08-12 04:35:46.000000000","message":"s/during/while","commit_id":"4e4613ef1337d8b0042944010507399edb4b75b6"}]}