)]}'
{"glance/api/authorization.py":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"fbf39089c9899eac832c994deab203c9ec8edb45","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        raise exception.Forbidden(message)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def deactivate(self, *args, **kwargs):"},{"line_number":333,"context_line":"        message \u003d _(\"You are not permitted to deactivate this image.\")"},{"line_number":334,"context_line":"        raise exception.Forbidden(message)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def activate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_735eadea","line":333,"updated":"2015-08-25 11:16:11.000000000","message":"Wouldn\u0027t it be a better idea to return 200 in case it is already deactivated and 403 otherwise?","commit_id":"85c65f514abae3c9a29f418ab429b4121c9db880"},{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"6c084d5c6f011ae9ad9b16cf97fa9143146c1620","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        raise exception.Forbidden(message)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def deactivate(self, *args, **kwargs):"},{"line_number":333,"context_line":"        message \u003d _(\"You are not permitted to deactivate this image.\")"},{"line_number":334,"context_line":"        raise exception.Forbidden(message)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def activate(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_09d700c0","line":333,"in_reply_to":"fa1b9901_735eadea","updated":"2015-08-25 12:14:16.000000000","message":"I don\u0027t think a user should ever receive a 200, when trying to modify somebody else\u0027s image. As the user is always forbidden from editing it, I think the 200 would be confusing.","commit_id":"85c65f514abae3c9a29f418ab429b4121c9db880"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"fbf39089c9899eac832c994deab203c9ec8edb45","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        raise exception.Forbidden(message)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def activate(self, *args, **kwargs):"},{"line_number":337,"context_line":"        message \u003d _(\"You are not permitted to activate this image.\")"},{"line_number":338,"context_line":"        raise exception.Forbidden(message)"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_335835fa","line":337,"updated":"2015-08-25 11:16:11.000000000","message":"same question here.","commit_id":"85c65f514abae3c9a29f418ab429b4121c9db880"}]}