)]}'
{"glance/api/v3/artifacts.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ac42ac17e1000e48b5e01d6761352ff8aa94f989","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            return artifact"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        except ValueError as e:"},{"line_number":317,"context_line":"            LOG.debug(\"Cannot save data for artifact %(id)s: %(e)s\","},{"line_number":318,"context_line":"                      {\u0027id\u0027: id, \u0027e\u0027: encodeutils.exception_to_unicode(e)})"},{"line_number":319,"context_line":"            self._restore(artifact_repo, artifact)"},{"line_number":320,"context_line":"            raise webob.exc.HTTPBadRequest("}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_c4ccc863","line":317,"updated":"2015-09-02 15:37:39.000000000","message":"Nit: Why encode the exception twice here. Maybe use a variable to hold the encoding?","commit_id":"47dfa8adf61c5646f6e10f3820c971875a4b6833"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"8c4915d2505c8f8cd807bf79df6c56e6bcbca5b0","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            return artifact"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        except ValueError as e:"},{"line_number":317,"context_line":"            LOG.debug(\"Cannot save data for artifact %(id)s: %(e)s\","},{"line_number":318,"context_line":"                      {\u0027id\u0027: id, \u0027e\u0027: encodeutils.exception_to_unicode(e)})"},{"line_number":319,"context_line":"            self._restore(artifact_repo, artifact)"},{"line_number":320,"context_line":"            raise webob.exc.HTTPBadRequest("}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_59c8e356","line":317,"in_reply_to":"da20952f_c4ccc863","updated":"2015-09-08 09:15:55.000000000","message":"Done","commit_id":"47dfa8adf61c5646f6e10f3820c971875a4b6833"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"ac42ac17e1000e48b5e01d6761352ff8aa94f989","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        except (glance_store.Duplicate,"},{"line_number":332,"context_line":"                exception.InvalidImageStatusTransition) as e:"},{"line_number":333,"context_line":"            msg \u003d encodeutils.exception_to_unicode(e)"},{"line_number":334,"context_line":"            LOG.exception(msg)"},{"line_number":335,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.msg, request\u003dreq)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        except exception.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_64c85c75","line":334,"updated":"2015-09-02 15:37:39.000000000","message":"Nit: Why not the following? \n\nLOG.exception(encodeutils.exception_to_unicode(e))","commit_id":"47dfa8adf61c5646f6e10f3820c971875a4b6833"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"8c4915d2505c8f8cd807bf79df6c56e6bcbca5b0","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        except (glance_store.Duplicate,"},{"line_number":332,"context_line":"                exception.InvalidImageStatusTransition) as e:"},{"line_number":333,"context_line":"            msg \u003d encodeutils.exception_to_unicode(e)"},{"line_number":334,"context_line":"            LOG.exception(msg)"},{"line_number":335,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003de.msg, request\u003dreq)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        except exception.Forbidden as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_793a8736","line":334,"in_reply_to":"da20952f_64c85c75","updated":"2015-09-08 09:15:55.000000000","message":"Done","commit_id":"47dfa8adf61c5646f6e10f3820c971875a4b6833"}]}