)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"4cc15cf2b88eed1ae3ab4f6fa11a309445009002","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        # check for a special header value to be false in order to force"},{"line_number":510,"context_line":"        # properties NOT to be purged. However we also disable purging of"},{"line_number":511,"context_line":"        # properties if an image file is being uploaded..."},{"line_number":512,"context_line":"        purge_props \u003d req.headers.get(\u0027x-glance-registry-purge-props\u0027, \"true\")"},{"line_number":513,"context_line":"        purge_props \u003d (purge_props.lower() \u003d\u003d \u0027true\u0027 and image_data is None)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if image_data is not None and orig_status !\u003d \u0027queued\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2BGk%3D","line":512,"updated":"2011-12-09 14:19:40.000000000","message":"Would it make sense to use glance.common.utils.bool_from_string here to allow a little more flexibility? I\u0027m just thinking about what happens when you cast True to a string... It\u0027s also better to use existing logic than recode it (looking at the line below).","commit_id":"1116baa64ecd985ceb31676d7bc9561edaa63011"},{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"e255e4de71a03ee02953d81356e114b2d0f858a1","unresolved":false,"context_lines":[{"line_number":509,"context_line":"        # check for a special header value to be false in order to force"},{"line_number":510,"context_line":"        # properties NOT to be purged. However we also disable purging of"},{"line_number":511,"context_line":"        # properties if an image file is being uploaded..."},{"line_number":512,"context_line":"        purge_props \u003d req.headers.get(\u0027x-glance-registry-purge-props\u0027, \"true\")"},{"line_number":513,"context_line":"        purge_props \u003d (purge_props.lower() \u003d\u003d \u0027true\u0027 and image_data is None)"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        if image_data is not None and orig_status !\u003d \u0027queued\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F%2BGc%3D","line":512,"in_reply_to":"AAAAC3%2F%2F%2BGk%3D","updated":"2011-12-09 14:22:36.000000000","message":"Sorry, you couldn\u0027t get rid of the whole line! I\u0027m not sure how I missed that half of the logic. You could remove the \".lower() \u003d\u003d \u0027true\u0027\" part, though.","commit_id":"1116baa64ecd985ceb31676d7bc9561edaa63011"},{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"a2937ed68901ef4a662c7a6a3834ada1d660eb02","unresolved":false,"context_lines":[{"line_number":516,"context_line":"            raise HTTPConflict(_(\"Cannot upload to an unqueued image\"))"},{"line_number":517,"context_line":""},{"line_number":518,"context_line":"        try:"},{"line_number":519,"context_line":"            image_meta \u003d registry.update_image_metadata(req.context, id,"},{"line_number":520,"context_line":"                                                        image_meta,"},{"line_number":521,"context_line":"                                                        purge_props)"},{"line_number":522,"context_line":"            if image_data is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9oM%3D","line":519,"updated":"2011-12-12 20:54:40.000000000","message":"should this be on the next line down? also, id is the name of a builtin, perhaps name it after the kind of id it is? (image_id?)","commit_id":"1116baa64ecd985ceb31676d7bc9561edaa63011"}],"glance/tests/unit/test_api.py":[{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"a2937ed68901ef4a662c7a6a3834ada1d660eb02","unresolved":false,"context_lines":[{"line_number":2096,"context_line":"        \"\"\""},{"line_number":2097,"context_line":"        Test that the process of registering an image with"},{"line_number":2098,"context_line":"        some metadata, then uploading an image file with some"},{"line_number":2099,"context_line":"        more metadata doesn\u0027t mark the original metadata deleted"},{"line_number":2100,"context_line":"        :see LP Bug#901534"},{"line_number":2101,"context_line":"        \"\"\""},{"line_number":2102,"context_line":"        fixture_headers \u003d {\u0027x-image-meta-store\u0027: \u0027file\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9qc%3D","line":2099,"updated":"2011-12-12 20:54:40.000000000","message":".","commit_id":"1116baa64ecd985ceb31676d7bc9561edaa63011"}]}