)]}'
{"glance/api/v2/metadef_objects.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"408a48077b5c6526f55328ae5a47fee653eadff2","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        return filters"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _validate_limit(self, limit):"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            limit \u003d int(limit)"},{"line_number":299,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_73c4d03f","line":296,"updated":"2015-09-14 07:10:53.000000000","message":"_validate_limit is also defined in v2/images.py\n\nhttps://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L566\n\nIMO this should be moved to common place to avoid code duplication,","commit_id":"969411affc2c4e0153e46456acf8a9fee3d4746e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"cbcafb40db2d176623e71e023685c930554d5966","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        return filters"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def _validate_limit(self, limit):"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            limit \u003d int(limit)"},{"line_number":299,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_de560306","line":296,"in_reply_to":"ba15a1d1_73c4d03f","updated":"2015-09-14 07:32:03.000000000","message":"Not only images.py ,but aslo metadef_namespaces.py, metadef_tags.py and tasks.py defined. The same as _get_request_body,_get_filters and so on. \nBut I\u0027m not sure it\u0027s right to move them into a common place. Although it can avoid code duplication, it will be high coupling. IMO, each object should has its own deserializer.","commit_id":"969411affc2c4e0153e46456acf8a9fee3d4746e"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"2a76ca604d7693e3a42bc5adfd82f71bda4f3cd5","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            msg \u003d _(\"limit param must be an integer\")"},{"line_number":301,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if limit \u003c\u003d 0:"},{"line_number":304,"context_line":"            msg \u003d _(\"limit param must be positive\")"},{"line_number":305,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_ba85045a","line":303,"updated":"2015-10-05 10:30:45.000000000","message":"I think the server should be responsible of validating the API. Optimizing the client is nice to have.","commit_id":"5e5e0346baedb7691d62ea5a425a5d9384fc3d6a"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"ff675d3ef451e01fff9507ecdb8d0caaf3732c9d","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            msg \u003d _(\"limit param must be an integer\")"},{"line_number":301,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        if limit \u003c\u003d 0:"},{"line_number":304,"context_line":"            msg \u003d _(\"limit param must be positive\")"},{"line_number":305,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_df4d539a","line":303,"updated":"2015-09-22 13:21:34.000000000","message":"The interesting thing here that we do not validate maximal limit somewhere.\nEven when I looked at the client there were not pagination in it. Perhaps, we need to validate this on client side.","commit_id":"5e5e0346baedb7691d62ea5a425a5d9384fc3d6a"}]}