)]}'
{"glance/api/v1/images.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"8b50060119e2682cee8902287d84a0f8354f1e6c","unresolved":false,"context_lines":[{"line_number":934,"context_line":"            # Once an image is \u0027active\u0027 only an admin can"},{"line_number":935,"context_line":"            # modify certain core metadata keys"},{"line_number":936,"context_line":"            for key in ACTIVE_IMMUTABLE:"},{"line_number":937,"context_line":"                if (orig_status \u003d\u003d \u0027active\u0027 and image_meta.get(key) is not None"},{"line_number":938,"context_line":"                        and image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":939,"context_line":"                    msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of active image.\") % key"},{"line_number":940,"context_line":"                    raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_dc4eb6c0","line":937,"updated":"2015-09-22 16:11:55.000000000","message":"We do the same thing here.","commit_id":"34f9f037136061f7437761e86ea9f0864b297619"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"541a8e67817a931db08f542074fcd37612e72d8b","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                        content_type\u003d\"text/plain\")"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        for key in IMMUTABLE:"},{"line_number":945,"context_line":"            if (image_meta.get(key) is not None and"},{"line_number":946,"context_line":"                    image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":947,"context_line":"                msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of image.\") % key"},{"line_number":948,"context_line":"                raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_83cd41b9","line":945,"updated":"2015-09-22 15:11:40.000000000","message":"Is it going to support the case when image_meta key is None?\nIn this case we could potentially change the value from \"some value\" to None because it will pass validation.\nAm I correct?","commit_id":"34f9f037136061f7437761e86ea9f0864b297619"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"cec3bcde84a693ebb8b35368810db5b860d7b7c5","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                        content_type\u003d\"text/plain\")"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        for key in IMMUTABLE:"},{"line_number":945,"context_line":"            if (image_meta.get(key) is not None and"},{"line_number":946,"context_line":"                    image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":947,"context_line":"                msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of image.\") % key"},{"line_number":948,"context_line":"                raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_7ccd2ab6","line":945,"in_reply_to":"ba15a1d1_4685f7aa","updated":"2015-09-22 16:06:26.000000000","message":"Hemanth, I agree with you, but proposed solution is code optimization and it doesn\u0027t affect the final result.","commit_id":"34f9f037136061f7437761e86ea9f0864b297619"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"28b04ff0e88da80ecfc2eec920a08eada0d99465","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                        content_type\u003d\"text/plain\")"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        for key in IMMUTABLE:"},{"line_number":945,"context_line":"            if (image_meta.get(key) is not None and"},{"line_number":946,"context_line":"                    image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":947,"context_line":"                msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of image.\") % key"},{"line_number":948,"context_line":"                raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_4685f7aa","line":945,"in_reply_to":"ba15a1d1_83cd41b9","updated":"2015-09-22 15:38:10.000000000","message":"+1\nWhy do we care whether the immutable image metadata is None or not?\nAll that we care if whether or not a new value of image metadata is passed.\nThe \u0027get\u0027 operation returns None anyway if the key is not present in the dict.\n\nSo, can we reduce the if condition to this:\n\nif image_meta.get(key) !\u003d orig_image_meta.get(key):\n\nLet me know if I\u0027m missing anything here.","commit_id":"34f9f037136061f7437761e86ea9f0864b297619"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"734f5f84b658b6b6735080678cf053fc73ab5f3c","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                        content_type\u003d\"text/plain\")"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        for key in IMMUTABLE:"},{"line_number":945,"context_line":"            if (image_meta.get(key) is not None and"},{"line_number":946,"context_line":"                    image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":947,"context_line":"                msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of image.\") % key"},{"line_number":948,"context_line":"                raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_266ec32f","line":945,"in_reply_to":"ba15a1d1_83cd41b9","updated":"2015-09-22 15:35:27.000000000","message":"I think it\u0027s impossible to pass None in request. It means that if image_meta.get(key) is None, that it doesn\u0027t present in image_meta.","commit_id":"34f9f037136061f7437761e86ea9f0864b297619"}]}