)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e9565737169b7ca45e9db2a87c93dbfa6a49e922","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     itisha \u003cishadewan07@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-24 21:19:20 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Redundant check for None value:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using has_key, a  more explicit way of checking if the immutable image"},{"line_number":10,"context_line":"metadata is None or not."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_e0a3334e","line":7,"updated":"2015-09-24 16:06:54.000000000","message":"It\u0027s not a redundant check any more.\nHow about saying something like:\nAn explicit check for the presence of a property?","commit_id":"d3ea4685c7b16163cfefab9be7a9952906627a66"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e9565737169b7ca45e9db2a87c93dbfa6a49e922","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Redundant check for None value:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using has_key, a  more explicit way of checking if the immutable image"},{"line_number":10,"context_line":"metadata is None or not."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I72d372b8c2894cd3f8f0a3eebeae68886d4e0d65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_20c12be5","line":10,"updated":"2015-09-24 16:06:54.000000000","message":"We are not really checking whether the immutable metadata is None or not. We are checking for the presence of immutable metadata in the request by using has_key operation.","commit_id":"d3ea4685c7b16163cfefab9be7a9952906627a66"},{"author":{"_account_id":9096,"name":"Cindy Pallares","email":"u1@cindy.sh","username":"cpallares"},"change_message_id":"378c990b71d3dcac43d9463f680132c7b935b1c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"An explicit check for the presence of a property:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using has_key, a  more explicit way of checking if the immutable image"},{"line_number":10,"context_line":"metadata is present or not."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I72d372b8c2894cd3f8f0a3eebeae68886d4e0d65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_99d8aef1","line":10,"updated":"2015-09-24 18:29:05.000000000","message":"Please add: Closes-Bug: #1499038","commit_id":"75f366ee670565953a60904ebdf106662424a410"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"17936925fa8512429b2d97980f1f84960b023a77","unresolved":false,"context_lines":[{"line_number":7,"context_line":"An explicit check for the presence of a property:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using has_key, a  more explicit way of checking if the immutable image"},{"line_number":10,"context_line":"metadata is present or not."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I72d372b8c2894cd3f8f0a3eebeae68886d4e0d65"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_fdb8ade7","line":10,"in_reply_to":"9a1a9d01_99d8aef1","updated":"2015-09-24 20:38:35.000000000","message":"Cindy, it\u0027s probably not required.\nThis patch really isn\u0027t addressing that bug, which claims that the None check is redundant. The None check is not necessarily redundant as it\u0027s really checking for the presence of immutable image metadata in the request.\n\nThis patch is more or less just re-factoring the way in which the presence of immutable metadata is checked. \nSo, from the way I see it, \n1. The reported bug is not really a bug. \n2. This patch is not addressing the reported bug\n\nLet me know what you think.","commit_id":"75f366ee670565953a60904ebdf106662424a410"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"f85838e215d0b56d9db4f0c3893eab50796ccfd9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"An explicit check for the presence of a property:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using has_key, a  more explicit way of checking if the immutable image"},{"line_number":10,"context_line":"metadata is present or not."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1499038"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_62f3750b","line":9,"updated":"2015-09-25 18:42:04.000000000","message":"has_key is not used, IMO need to modify commit message","commit_id":"138bd14cc03555073347022b4ea576e6b4fac857"}],"glance/api/v1/images.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e9565737169b7ca45e9db2a87c93dbfa6a49e922","unresolved":false,"context_lines":[{"line_number":934,"context_line":"            # Once an image is \u0027active\u0027 only an admin can"},{"line_number":935,"context_line":"            # modify certain core metadata keys"},{"line_number":936,"context_line":"            for key in ACTIVE_IMMUTABLE:"},{"line_number":937,"context_line":"                if (orig_status \u003d\u003d \u0027active\u0027 and image_meta.has_key(key) "},{"line_number":938,"context_line":"                        and image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":939,"context_line":"                    msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of active image.\") % key"},{"line_number":940,"context_line":"                    raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_604ba3b1","line":937,"updated":"2015-09-24 16:06:54.000000000","message":"let\u0027s get rid of the extra white space here","commit_id":"d3ea4685c7b16163cfefab9be7a9952906627a66"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"e9565737169b7ca45e9db2a87c93dbfa6a49e922","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                                        content_type\u003d\"text/plain\")"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        for key in IMMUTABLE:"},{"line_number":945,"context_line":"            if (image_meta.has_key(key) and "},{"line_number":946,"context_line":"                    image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":947,"context_line":"                msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of image.\") % key"},{"line_number":948,"context_line":"                raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_00c74713","line":945,"updated":"2015-09-24 16:06:54.000000000","message":"same","commit_id":"d3ea4685c7b16163cfefab9be7a9952906627a66"},{"author":{"_account_id":17976,"name":"Drew Varner","email":"avarner@linux.vnet.ibm.com","username":"avarner"},"change_message_id":"cdf2b01b00a5a1683a1a900d79bedb02d36b88df","unresolved":false,"context_lines":[{"line_number":934,"context_line":"            # Once an image is \u0027active\u0027 only an admin can"},{"line_number":935,"context_line":"            # modify certain core metadata keys"},{"line_number":936,"context_line":"            for key in ACTIVE_IMMUTABLE:"},{"line_number":937,"context_line":"                if (orig_status \u003d\u003d \u0027active\u0027 and image_meta.has_key(key)"},{"line_number":938,"context_line":"                        and image_meta.get(key) !\u003d orig_image_meta.get(key)):"},{"line_number":939,"context_line":"                    msg \u003d _(\"Forbidden to modify \u0027%s\u0027 of active image.\") % key"},{"line_number":940,"context_line":"                    raise HTTPForbidden(explanation\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_65c5ed59","line":937,"updated":"2015-09-24 18:46:54.000000000","message":"This appears to cause `tox -e pep8` to fail - maybe try: \n\nif (orig_status \u003d\u003d \u0027active\u0027 and key in image_meta","commit_id":"75f366ee670565953a60904ebdf106662424a410"}]}