)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"5c3a51c9fdc3ab381bd532948f71c02aabe5f6db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add migration 021 set_engine_mysql_innodb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migration 018 neglected to set the mysql engine to InnoDB when"},{"line_number":10,"context_line":"it added the image_locations table. This commit adds a new"},{"line_number":11,"context_line":"migration to set the image_locations to the InnoDB engine."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2Bot0%3D","line":9,"updated":"2013-02-24 10:44:55.000000000","message":"Could you also add the migration\u0027s change-id here?","commit_id":"f232c3156cd3197f7667cd8792e99affcc714543"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1ab07cd720fea78fe6193bb59c459eaf7873827b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add migration 021 set_engine_mysql_innodb"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Migration 018 neglected to set the mysql engine to InnoDB when"},{"line_number":10,"context_line":"it added the image_locations table. This commit adds a new"},{"line_number":11,"context_line":"migration to set the image_locations to the InnoDB engine."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAM3%2F%2Bn7g%3D","line":9,"in_reply_to":"AAAAM3%2F%2Bot0%3D","updated":"2013-02-25 14:29:26.000000000","message":"Done","commit_id":"f232c3156cd3197f7667cd8792e99affcc714543"}],"glance/db/sqlalchemy/migrate_repo/versions/021_set_engine_mysql_innodb.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"bb2fbe6f89ed8b7c21c0b1d6e9b1a43950e83d50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bo28%3D","line":3,"updated":"2013-02-23 21:48:43.000000000","message":"I believe this needs the Openstack Foundation copyright as well, though I could be wrong.","commit_id":"f232c3156cd3197f7667cd8792e99affcc714543"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1ab07cd720fea78fe6193bb59c459eaf7873827b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bn7c%3D","line":3,"in_reply_to":"AAAAM3%2F%2Bo28%3D","updated":"2013-02-25 14:29:26.000000000","message":"Done","commit_id":"f232c3156cd3197f7667cd8792e99affcc714543"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"bb2fbe6f89ed8b7c21c0b1d6e9b1a43950e83d50","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        d \u003d migrate_engine.execute(\"SHOW TABLE STATUS WHERE Engine!\u003d\u0027InnoDB\u0027;\")"},{"line_number":27,"context_line":"        for row in d.fetchall():"},{"line_number":28,"context_line":"            table_name \u003d row[0]"},{"line_number":29,"context_line":"            if table_name in tables:"},{"line_number":30,"context_line":"                migrate_engine.execute(\"ALTER TABLE %s Engine\u003dInnoDB\" %"},{"line_number":31,"context_line":"                                       table_name)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bo24%3D","line":29,"updated":"2013-02-23 21:48:43.000000000","message":"This logic seems a bit contorted considering len(tables) \u003d\u003d 1. But I suppose it does no harm.","commit_id":"f232c3156cd3197f7667cd8792e99affcc714543"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"1ab07cd720fea78fe6193bb59c459eaf7873827b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        d \u003d migrate_engine.execute(\"SHOW TABLE STATUS WHERE Engine!\u003d\u0027InnoDB\u0027;\")"},{"line_number":27,"context_line":"        for row in d.fetchall():"},{"line_number":28,"context_line":"            table_name \u003d row[0]"},{"line_number":29,"context_line":"            if table_name in tables:"},{"line_number":30,"context_line":"                migrate_engine.execute(\"ALTER TABLE %s Engine\u003dInnoDB\" %"},{"line_number":31,"context_line":"                                       table_name)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bn7M%3D","line":29,"in_reply_to":"AAAAM3%2F%2Bo24%3D","updated":"2013-02-25 14:29:26.000000000","message":"I made the logic here for the case where there was more than one table for future proofing. This way if another table gets added without the engine set to innodb you could just move this migration forward and add the new table to the list.\n\nAlthough thinking about it now, with the new testing that shouldn\u0027t be able to happen. I can rework the logic to make it simpler if you\u0027d like.","commit_id":"f232c3156cd3197f7667cd8792e99affcc714543"}]}