)]}'
{"glance/api/middleware/version_negotiation.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1a8d85f2d428c785a7639af092e4492f2913d940","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def process_request(self, req):"},{"line_number":43,"context_line":"        \"\"\"Try to find a version first in the accept header, then the URL\"\"\""},{"line_number":44,"context_line":"        msg \u003d _(\"Determining version of request: %(method)s %(path)s\""},{"line_number":45,"context_line":"                \" Accept: %(accept)s\")"},{"line_number":46,"context_line":"        args \u003d {\u0027method\u0027: req.method, \u0027path\u0027: req.path, \u0027accept\u0027: req.accept}"},{"line_number":47,"context_line":"        LOG.debug(msg, args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_842f3e87","line":44,"updated":"2015-09-29 21:21:30.000000000","message":"Off topic: This is debug log and there is no need for the marker function.","commit_id":"a2ff197aab0a21276adc743b20924725f631eb42"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"c850d5fa7b1a9f80c7b3a0a77b33f8139d71fd99","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def process_request(self, req):"},{"line_number":43,"context_line":"        \"\"\"Try to find a version first in the accept header, then the URL\"\"\""},{"line_number":44,"context_line":"        msg \u003d _(\"Determining version of request: %(method)s %(path)s\""},{"line_number":45,"context_line":"                \" Accept: %(accept)s\")"},{"line_number":46,"context_line":"        args \u003d {\u0027method\u0027: req.method, \u0027path\u0027: req.path, \u0027accept\u0027: req.accept}"},{"line_number":47,"context_line":"        LOG.debug(msg, args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_aafb29c0","line":44,"in_reply_to":"9a1a9d01_842f3e87","updated":"2015-09-29 23:20:55.000000000","message":"Agree. Although, it was made earlier definitely need to fix.","commit_id":"a2ff197aab0a21276adc743b20924725f631eb42"}],"glance/api/v1/upload_utils.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1a8d85f2d428c785a7639af092e4492f2913d940","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                else:"},{"line_number":173,"context_line":"                    raise"},{"line_number":174,"context_line":"        except exception.ImageNotFound:"},{"line_number":175,"context_line":"            msg \u003d _LI(\"Image %s could not be found after upload. The image may\""},{"line_number":176,"context_line":"                      \" have been deleted during the upload.\") % image_id"},{"line_number":177,"context_line":"            LOG.info(msg)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_a4dfe267","side":"PARENT","line":175,"updated":"2015-09-29 21:21:30.000000000","message":"This should probably use _() and rest of the changes can be discared. You can use _() when msg is sent to both log \u0026 exception. This will make sure the str is translated only once.","commit_id":"e4930fd20bf9cd52e5da9ba08c444cbd1d92fd55"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"c850d5fa7b1a9f80c7b3a0a77b33f8139d71fd99","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                else:"},{"line_number":173,"context_line":"                    raise"},{"line_number":174,"context_line":"        except exception.ImageNotFound:"},{"line_number":175,"context_line":"            msg \u003d _LI(\"Image %s could not be found after upload. The image may\""},{"line_number":176,"context_line":"                      \" have been deleted during the upload.\") % image_id"},{"line_number":177,"context_line":"            LOG.info(msg)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_cae69d14","side":"PARENT","line":175,"in_reply_to":"9a1a9d01_a4dfe267","updated":"2015-09-29 23:20:55.000000000","message":"Thanks, will do.","commit_id":"e4930fd20bf9cd52e5da9ba08c444cbd1d92fd55"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"eecc433b8628af041815be20d6dc6f309233d165","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                else:"},{"line_number":173,"context_line":"                    raise"},{"line_number":174,"context_line":"        except exception.ImageNotFound:"},{"line_number":175,"context_line":"            msg \u003d _(\"Image %s could not be found after upload. The image may\""},{"line_number":176,"context_line":"                    \" have been deleted during the upload.\") % image_id"},{"line_number":177,"context_line":"            LOG.info(msg)"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_d7476949","line":175,"updated":"2015-10-07 19:23:00.000000000","message":"Why did you remove LI?","commit_id":"37fa0fca8319e128cdd248edaf68f968e28dab08"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a11396da80f322e6a3330533871ac08fc85e3a36","unresolved":false,"context_lines":[{"line_number":183,"context_line":"            # exceptions that occur there handle this same issue internally,"},{"line_number":184,"context_line":"            # Since this is store-agnostic, should apply to all stores."},{"line_number":185,"context_line":"            initiate_deletion(req, location_data, image_id)"},{"line_number":186,"context_line":"            raise webob.exc.HTTPPreconditionFailed(explanation\u003dmsg,"},{"line_number":187,"context_line":"                                                   request\u003dreq,"},{"line_number":188,"context_line":"                                                   content_type\u003d\u0027text/plain\u0027)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_17cba173","line":186,"updated":"2015-10-07 19:25:27.000000000","message":"Mike, the message is used here again ^. Therefore the _LI is wrong. See oslo.i18n documentation for full explanation.","commit_id":"37fa0fca8319e128cdd248edaf68f968e28dab08"}],"glance/common/scripts/image_import/main.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1a8d85f2d428c785a7639af092e4492f2913d940","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        image.set_data(data_iter)"},{"line_number":156,"context_line":"    except Exception as e:"},{"line_number":157,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"            LOG.warn(_LW(\"Task %(task_id)s failed with exception %(error)s\") %"},{"line_number":159,"context_line":"                     {\"error\": encodeutils.exception_to_unicode(e),"},{"line_number":160,"context_line":"                      \"task_id\": task_id})"},{"line_number":161,"context_line":"            LOG.info(_LI(\"Task %(task_id)s: Could not import image file\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_24a3d2b3","line":158,"updated":"2015-09-29 21:21:30.000000000","message":"The interpolation can be delayed here too.","commit_id":"a2ff197aab0a21276adc743b20924725f631eb42"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"c850d5fa7b1a9f80c7b3a0a77b33f8139d71fd99","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        image.set_data(data_iter)"},{"line_number":156,"context_line":"    except Exception as e:"},{"line_number":157,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"            LOG.warn(_LW(\"Task %(task_id)s failed with exception %(error)s\") %"},{"line_number":159,"context_line":"                     {\"error\": encodeutils.exception_to_unicode(e),"},{"line_number":160,"context_line":"                      \"task_id\": task_id})"},{"line_number":161,"context_line":"            LOG.info(_LI(\"Task %(task_id)s: Could not import image file\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_eab12102","line":158,"in_reply_to":"9a1a9d01_24a3d2b3","updated":"2015-09-29 23:20:55.000000000","message":"Disagree, we need a separate patch for warnings.","commit_id":"a2ff197aab0a21276adc743b20924725f631eb42"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"aad8e2d427a1a33fb8203bd6f4afaa8dd8874201","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        image.set_data(data_iter)"},{"line_number":156,"context_line":"    except Exception as e:"},{"line_number":157,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":158,"context_line":"            LOG.warn(_LW(\"Task %(task_id)s failed with exception %(error)s\") %"},{"line_number":159,"context_line":"                     {\"error\": encodeutils.exception_to_unicode(e),"},{"line_number":160,"context_line":"                      \"task_id\": task_id})"},{"line_number":161,"context_line":"            LOG.info(_LI(\"Task %(task_id)s: Could not import image file\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_01aebb97","line":158,"in_reply_to":"9a1a9d01_eab12102","updated":"2015-09-29 23:36:19.000000000","message":"Ah, failed to notice that you were targeting a separate patch for Warnings.","commit_id":"a2ff197aab0a21276adc743b20924725f631eb42"}],"glance/registry/api/v1/images.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"1a8d85f2d428c785a7639af092e4492f2913d940","unresolved":false,"context_lines":[{"line_number":367,"context_line":"        \"\"\""},{"line_number":368,"context_line":"        try:"},{"line_number":369,"context_line":"            deleted_image \u003d self.db_api.image_destroy(req.context, id)"},{"line_number":370,"context_line":"            LOG.info(_LI(\"Successfully deleted image %(id)s\"), {\u0027id\u0027: id})"},{"line_number":371,"context_line":"            return dict(image\u003dmake_image_dict(deleted_image))"},{"line_number":372,"context_line":"        except exception.ForbiddenPublicImage:"},{"line_number":373,"context_line":"            LOG.info(_LI(\"Delete denied for public image %(id)s\"), {\u0027id\u0027: id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_04ea4eac","line":370,"updated":"2015-09-29 21:21:30.000000000","message":"Not necessary for named interpolation for 1 variable but it\u0027s okay - not related to your change :)","commit_id":"a2ff197aab0a21276adc743b20924725f631eb42"}]}