)]}'
{"glance/api/middleware/version_negotiation.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6af307cf83c3c705e190b9050850667f8799424a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        msg \u003d (\"Determining version of request: %(method)s %(path)s \""},{"line_number":45,"context_line":"               \"Accept: %(accept)s\")"},{"line_number":46,"context_line":"        args \u003d {\u0027method\u0027: req.method, \u0027path\u0027: req.path, \u0027accept\u0027: req.accept}"},{"line_number":47,"context_line":"        LOG.debug(msg, args)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # If the request is for /versions, just return the versions container"},{"line_number":50,"context_line":"        # TODO(bcwaldon): deprecate this behavior"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c61edb62","line":47,"updated":"2015-11-05 14:14:39.000000000","message":"For consistency we should remove the usage of msg variable here as well.","commit_id":"1435b2fed355034fc35bc05489402adac820b224"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"278f9a2a37eb38bc837fde9a757090df3e9cc3af","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        msg \u003d (\"Determining version of request: %(method)s %(path)s \""},{"line_number":45,"context_line":"               \"Accept: %(accept)s\")"},{"line_number":46,"context_line":"        args \u003d {\u0027method\u0027: req.method, \u0027path\u0027: req.path, \u0027accept\u0027: req.accept}"},{"line_number":47,"context_line":"        LOG.debug(msg, args)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # If the request is for /versions, just return the versions container"},{"line_number":50,"context_line":"        # TODO(bcwaldon): deprecate this behavior"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_d7917d48","line":47,"in_reply_to":"fa80f949_4aef3e87","updated":"2015-11-06 12:18:50.000000000","message":"So are many of the rest ones changed.","commit_id":"1435b2fed355034fc35bc05489402adac820b224"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"dadd8e07c46d4887e18fc2aa40d7dca96b2844eb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        msg \u003d (\"Determining version of request: %(method)s %(path)s \""},{"line_number":45,"context_line":"               \"Accept: %(accept)s\")"},{"line_number":46,"context_line":"        args \u003d {\u0027method\u0027: req.method, \u0027path\u0027: req.path, \u0027accept\u0027: req.accept}"},{"line_number":47,"context_line":"        LOG.debug(msg, args)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # If the request is for /versions, just return the versions container"},{"line_number":50,"context_line":"        # TODO(bcwaldon): deprecate this behavior"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_4aef3e87","line":47,"in_reply_to":"fa80f949_c61edb62","updated":"2015-11-05 21:08:28.000000000","message":"no need for that IMHO - it\u0027s not translated and it uses lazy evaluation.\n\nThe string is rather long, so the above looks fine to me.","commit_id":"1435b2fed355034fc35bc05489402adac820b224"}],"glance/api/v1/controller.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6af307cf83c3c705e190b9050850667f8799424a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                msg, request\u003drequest, content_type\u003d\u0027text/plain\u0027)"},{"line_number":48,"context_line":"        except exception.Forbidden:"},{"line_number":49,"context_line":"            msg \u003d \"Forbidden image access\""},{"line_number":50,"context_line":"            LOG.debug(msg)"},{"line_number":51,"context_line":"            raise webob.exc.HTTPForbidden(msg,"},{"line_number":52,"context_line":"                                          request\u003drequest,"},{"line_number":53,"context_line":"                                          content_type\u003d\u0027text/plain\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_0615c33e","line":50,"updated":"2015-11-05 14:14:39.000000000","message":"Ditto.","commit_id":"1435b2fed355034fc35bc05489402adac820b224"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"6af307cf83c3c705e190b9050850667f8799424a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        except exception.Forbidden:"},{"line_number":49,"context_line":"            msg \u003d \"Forbidden image access\""},{"line_number":50,"context_line":"            LOG.debug(msg)"},{"line_number":51,"context_line":"            raise webob.exc.HTTPForbidden(msg,"},{"line_number":52,"context_line":"                                          request\u003drequest,"},{"line_number":53,"context_line":"                                          content_type\u003d\u0027text/plain\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2610074e","line":51,"updated":"2015-11-05 14:14:39.000000000","message":"Bit unrelated but the msg here should be translated.","commit_id":"1435b2fed355034fc35bc05489402adac820b224"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8c73b298c22ab3b9a85afef8603d3c2e81c74576","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            return registry.get_image_metadata(context, image_id)"},{"line_number":43,"context_line":"        except exception.NotFound:"},{"line_number":44,"context_line":"            LOG.debug(\"Image with identifier %s not found\", image_id)"},{"line_number":45,"context_line":"            msg \u003d _(\"Image with identifier %s not found\") % image_id"},{"line_number":46,"context_line":"            raise webob.exc.HTTPNotFound("},{"line_number":47,"context_line":"                msg, request\u003drequest, content_type\u003d\u0027text/plain\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_a1390ed9","line":44,"updated":"2015-11-26 19:12:53.000000000","message":"What about:\n\n     msg \u003d \"Image with identifier %s not found\"\n     LOG.debug(...., ....)\n     msg \u003d _(msg) % image_id","commit_id":"e2c8b23129bc32ad1ebe5ed19864f84f334c6616"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"1cebe7b26d9d4180706317bb0619db39af0e59c4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            return registry.get_image_metadata(context, image_id)"},{"line_number":43,"context_line":"        except exception.NotFound:"},{"line_number":44,"context_line":"            LOG.debug(\"Image with identifier %s not found\", image_id)"},{"line_number":45,"context_line":"            msg \u003d _(\"Image with identifier %s not found\") % image_id"},{"line_number":46,"context_line":"            raise webob.exc.HTTPNotFound("},{"line_number":47,"context_line":"                msg, request\u003drequest, content_type\u003d\u0027text/plain\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_af1da367","line":44,"in_reply_to":"9a8ffd7b_a1390ed9","updated":"2015-12-02 08:15:43.000000000","message":"Strings for translations must be literals. \nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html\nThe marker functions are used to mark the translatable strings in the code. The strings are extracted into catalogs using a tool that looks for these specific markers, so the function argument must just be a string.","commit_id":"e2c8b23129bc32ad1ebe5ed19864f84f334c6616"}],"glance/api/v1/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8c73b298c22ab3b9a85afef8603d3c2e81c74576","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            try:"},{"line_number":554,"context_line":"                backend \u003d store.get_store_from_location(location)"},{"line_number":555,"context_line":"            except (store.UnknownScheme, store.BadStoreUri):"},{"line_number":556,"context_line":"                LOG.debug(\"Invalid location %s\", location)"},{"line_number":557,"context_line":"                msg \u003d _(\"Invalid location %s\") % location"},{"line_number":558,"context_line":"                raise HTTPBadRequest(explanation\u003dmsg,"},{"line_number":559,"context_line":"                                     request\u003dreq,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_21543efd","line":556,"updated":"2015-11-26 19:12:53.000000000","message":"ditto","commit_id":"e2c8b23129bc32ad1ebe5ed19864f84f334c6616"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"1cebe7b26d9d4180706317bb0619db39af0e59c4","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            try:"},{"line_number":554,"context_line":"                backend \u003d store.get_store_from_location(location)"},{"line_number":555,"context_line":"            except (store.UnknownScheme, store.BadStoreUri):"},{"line_number":556,"context_line":"                LOG.debug(\"Invalid location %s\", location)"},{"line_number":557,"context_line":"                msg \u003d _(\"Invalid location %s\") % location"},{"line_number":558,"context_line":"                raise HTTPBadRequest(explanation\u003dmsg,"},{"line_number":559,"context_line":"                                     request\u003dreq,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_ef3acbcc","line":556,"in_reply_to":"9a8ffd7b_21543efd","updated":"2015-12-02 08:15:43.000000000","message":"The translation string must be literal not variable.","commit_id":"e2c8b23129bc32ad1ebe5ed19864f84f334c6616"}],"glance/api/v2/metadef_namespaces.py":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"9e68e5d0b860389a99b5e44d1d00bde92442977e","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                          {\u0027namespace\u0027: namespace.namespace})"},{"line_number":207,"context_line":"            except exception:"},{"line_number":208,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s \") %"},{"line_number":209,"context_line":"                       {\u0027namespace\u0027: namespace.namespace})"},{"line_number":210,"context_line":"                LOG.error(msg)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    def show(self, req, namespace, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_db04997f","line":209,"updated":"2015-10-07 07:23:55.000000000","message":"This could be handled the same way with lazy evaluation - but outside the scope of this patch.","commit_id":"f141fa56d5609742a983c2eab03812a5b9f2bf17"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"ea966fe8e444efc1dd48e13cef3d0d6b1796f5ce","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                namespace_obj.delete()"},{"line_number":204,"context_line":"                namespace_repo.remove(namespace_obj)"},{"line_number":205,"context_line":"                LOG.debug(\"Cleaned up namespace %(namespace)s \","},{"line_number":206,"context_line":"                          {\u0027namespace\u0027: namespace.namespace})"},{"line_number":207,"context_line":"            except exception:"},{"line_number":208,"context_line":"                msg \u003d (_LE(\"Failed to delete namespace %(namespace)s \") %"},{"line_number":209,"context_line":"                       {\u0027namespace\u0027: namespace.namespace})"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_18aed12e","line":206,"updated":"2015-12-04 02:07:07.000000000","message":"I think the dictionary is not needed here but that\u0027s ok (already there and doesn\u0027t matter much).","commit_id":"e2c8b23129bc32ad1ebe5ed19864f84f334c6616"}]}