)]}'
{"glance/domain.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"737ecc876e4be16a7a175e2f512fa3fb4d9ff0a8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @status.setter"},{"line_number":96,"context_line":"    def status(self, status):"},{"line_number":97,"context_line":"        if (hasattr(self, \u0027_status\u0027) and self._status \u003d\u003d \u0027queued\u0027 and"},{"line_number":98,"context_line":"                status in (\u0027saving\u0027, \u0027active\u0027)):"},{"line_number":99,"context_line":"            missing \u003d [k for k in [\u0027disk_format\u0027, \u0027container_format\u0027]"},{"line_number":100,"context_line":"                       if not getattr(self, k)]"},{"line_number":101,"context_line":"            if len(missing) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2B8w%3D","line":98,"updated":"2013-03-04 18:10:33.000000000","message":"hey. Wouldn\u0027t it be better to check if status is in (\u0027saving\u0027, \u0027active\u0027) ? \n\nTBH, I don\u0027t know which one is more common, if it is not having _status or passing a status that isn\u0027t saving or active but it looks to me that the later is more common.","commit_id":"50d1013b4a54336a16c54e4cc090be69bcae14ec"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"a104524111f279a3a1dcf9eb492eba24fdafbcb7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @status.setter"},{"line_number":96,"context_line":"    def status(self, status):"},{"line_number":97,"context_line":"        if (hasattr(self, \u0027_status\u0027) and self._status \u003d\u003d \u0027queued\u0027 and"},{"line_number":98,"context_line":"                status in (\u0027saving\u0027, \u0027active\u0027)):"},{"line_number":99,"context_line":"            missing \u003d [k for k in [\u0027disk_format\u0027, \u0027container_format\u0027]"},{"line_number":100,"context_line":"                       if not getattr(self, k)]"},{"line_number":101,"context_line":"            if len(missing) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Bcg%3D","line":98,"in_reply_to":"AAAAN3%2F%2F%2B8w%3D","updated":"2013-03-04 21:00:17.000000000","message":"I\u0027m not sure which is more common. Status changes in general are very infrequent--there are probably only a handful per image over its entire lifetime. Are you worried about performance?\n\nI think an unambiguous performance boost might be to turn the _status access into one call\n\n  if getattr(self, \u0027_status\u0027, None) \u003d\u003d \u0027queued\u0027 and\n     status in (\u0027saving\u0027, \u0027active\u0027):","commit_id":"50d1013b4a54336a16c54e4cc090be69bcae14ec"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b0b91789f636ba9bd2390bbf430b5bf6b6ebac41","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @status.setter"},{"line_number":96,"context_line":"    def status(self, status):"},{"line_number":97,"context_line":"        if (hasattr(self, \u0027_status\u0027) and self._status \u003d\u003d \u0027queued\u0027 and"},{"line_number":98,"context_line":"                status in (\u0027saving\u0027, \u0027active\u0027)):"},{"line_number":99,"context_line":"            missing \u003d [k for k in [\u0027disk_format\u0027, \u0027container_format\u0027]"},{"line_number":100,"context_line":"                       if not getattr(self, k)]"},{"line_number":101,"context_line":"            if len(missing) \u003e 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F9Vg%3D","line":98,"in_reply_to":"AAAAN3%2F%2F%2Bcg%3D","updated":"2013-03-05 08:29:24.000000000","message":"Yep. that sounds good as well but, since you said status changes are very infrequent I guess we shouldn\u0027t care that much here.","commit_id":"50d1013b4a54336a16c54e4cc090be69bcae14ec"}]}