)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0c9462d93038629e9c5bfd762e769b044c34d8c6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to registry for fetching image metadata. However, when registry"},{"line_number":11,"context_line":"is deployed in trusted-auth mode, appropriate admin role needs to be"},{"line_number":12,"context_line":"set in context to gain admin context on registry."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ida3f0d586602ca86bd5bd05ddab1e424fa8ddd4a"},{"line_number":15,"context_line":"Closes-bug: #1502991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_2ca54eb4","line":13,"updated":"2015-10-07 09:37:30.000000000","message":"Should be marked with DocImpact flag","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1f0f079d6eabbe5e3d52e252ec6b29178d2233ea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to registry for fetching image metadata. However, when registry"},{"line_number":11,"context_line":"is deployed in trusted-auth mode, appropriate admin role needs to be"},{"line_number":12,"context_line":"set in context to gain admin context on registry."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ida3f0d586602ca86bd5bd05ddab1e424fa8ddd4a"},{"line_number":15,"context_line":"Closes-bug: #1502991"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_b7455bb4","line":13,"in_reply_to":"7a2fa921_2ca54eb4","updated":"2015-10-12 21:27:48.000000000","message":"+1, thanks abhishek!","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"}],"glance/image_cache/prefetcher.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0c9462d93038629e9c5bfd762e769b044c34d8c6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            roles \u003d [CONF.admin_role]"},{"line_number":48,"context_line":"            ctx \u003d context.RequestContext(user\u003dCONF.admin_user,"},{"line_number":49,"context_line":"                                         tenant\u003dCONF.admin_tenant_name,"},{"line_number":50,"context_line":"                                         auth_token\u003dNone, roles\u003droles,"},{"line_number":51,"context_line":"                                         show_deleted\u003dTrue)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            ctx \u003d context.RequestContext(is_admin\u003dTrue, show_deleted\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0c0652ce","line":50,"updated":"2015-10-07 09:37:30.000000000","message":"No need to pass auth_token\u003dNone as in oslo_context default value for auth_token is None","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1f0f079d6eabbe5e3d52e252ec6b29178d2233ea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            roles \u003d [CONF.admin_role]"},{"line_number":48,"context_line":"            ctx \u003d context.RequestContext(user\u003dCONF.admin_user,"},{"line_number":49,"context_line":"                                         tenant\u003dCONF.admin_tenant_name,"},{"line_number":50,"context_line":"                                         auth_token\u003dNone, roles\u003droles,"},{"line_number":51,"context_line":"                                         show_deleted\u003dTrue)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            ctx \u003d context.RequestContext(is_admin\u003dTrue, show_deleted\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_571167ae","line":50,"in_reply_to":"7a2fa921_0c0652ce","updated":"2015-10-12 21:27:48.000000000","message":"+1, thanks abhishek!","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"}],"glance/registry/client/__init__.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"70c5e5d3deca97af91d6353c1a93343ed5d74494","unresolved":false,"context_lines":[{"line_number":68,"context_line":"               help\u003d_(\u0027The administrators password. \u0027"},{"line_number":69,"context_line":"                      \u0027If \"use_user_token\" is not in effect, then \u0027"},{"line_number":70,"context_line":"                      \u0027admin credentials can be specified.\u0027)),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027admin_role\u0027, default\u003d\u0027admin\u0027,"},{"line_number":72,"context_line":"               help\u003d_(\u0027Role used to identify an authenticated user as \u0027"},{"line_number":73,"context_line":"                      \u0027administrator.\u0027)),"},{"line_number":74,"context_line":"    cfg.StrOpt(\u0027admin_tenant_name\u0027, secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_08d7db4b","line":71,"updated":"2015-10-21 13:25:19.000000000","message":"mmh, I honestly don\u0027t like the fact that this fix depends on a new config option that holds some data that belongs to keystone.\n\nAlso, the context middleware already has this config option. Wouldn\u0027t it be confusing to have it in 2 different places?","commit_id":"5490d31c3a677acebf0a7ff90d6972312ac27c8f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"51d6d6c05c63973ae293171fdc771b4add08f4e5","unresolved":false,"context_lines":[{"line_number":68,"context_line":"               help\u003d_(\u0027The administrators password. \u0027"},{"line_number":69,"context_line":"                      \u0027If \"use_user_token\" is not in effect, then \u0027"},{"line_number":70,"context_line":"                      \u0027admin credentials can be specified.\u0027)),"},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027admin_role\u0027, default\u003d\u0027admin\u0027,"},{"line_number":72,"context_line":"               help\u003d_(\u0027Role used to identify an authenticated user as \u0027"},{"line_number":73,"context_line":"                      \u0027administrator.\u0027)),"},{"line_number":74,"context_line":"    cfg.StrOpt(\u0027admin_tenant_name\u0027, secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_dda19b47","line":71,"in_reply_to":"3a29b11f_08d7db4b","updated":"2015-11-04 16:21:15.000000000","message":"It\u0027s really not a new config option. Like you said, it\u0027s something we already have. And, that leads to your second point about having it declared in two places. How about moving it to glance/common/config.py?\n\nAlso, I agree with you about this fix being a tad hacky. But, the bigger problem here is, registry can be deployed in multiple ways (no-auth, trusted-auth, keystone etc). And, it is expected that whoever is talking to registry should know how it\u0027s deployed. And, depending on that, one needs to create the request with appropriate information. Like the admin_role in this case. This isn\u0027t really very clean. \n\nThe context middleware actually expects to see the admin_role in request context to elevate the context to admin [0]. That\u0027s what makes all this look very hacky, especially in trusted-auth mode.\n\nWhat do you think?\n\n[0] https://github.com/openstack/glance/blob/master/glance/api/middleware/context.py#L133","commit_id":"5490d31c3a677acebf0a7ff90d6972312ac27c8f"}],"glance/tests/functional/__init__.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"39d99ef930cfe3d3bcf026da977f502552f89ce4","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"[pipeline:glance-api-fakeauth-cachemanagement]"},{"line_number":390,"context_line":"pipeline \u003d"},{"line_number":391,"context_line":"    healthcheck"},{"line_number":392,"context_line":"    versionnegotiation"},{"line_number":393,"context_line":"    gzip"},{"line_number":394,"context_line":"    fakeauth"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_9c56f0d0","line":391,"updated":"2015-10-07 22:35:03.000000000","message":"do you really need this one?","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"},{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"1f0f079d6eabbe5e3d52e252ec6b29178d2233ea","unresolved":false,"context_lines":[{"line_number":388,"context_line":""},{"line_number":389,"context_line":"[pipeline:glance-api-fakeauth-cachemanagement]"},{"line_number":390,"context_line":"pipeline \u003d"},{"line_number":391,"context_line":"    healthcheck"},{"line_number":392,"context_line":"    versionnegotiation"},{"line_number":393,"context_line":"    gzip"},{"line_number":394,"context_line":"    fakeauth"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_d73ed728","line":391,"in_reply_to":"7a2fa921_9c56f0d0","updated":"2015-10-12 21:27:48.000000000","message":"You meant \u0027healthcheck\u0027 or the pipeline itself?\n\nI don\u0027t necessarily need healthcheck middleware in there .. just adhering to what\u0027s been used in other pipelines.","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"39d99ef930cfe3d3bcf026da977f502552f89ce4","unresolved":false,"context_lines":[{"line_number":494,"context_line":"workers \u003d %(workers)s"},{"line_number":495,"context_line":"user_storage_quota \u003d %(user_storage_quota)s"},{"line_number":496,"context_line":"metadata_encryption_key \u003d %(metadata_encryption_key)s"},{"line_number":497,"context_line":"use_user_token \u003d %(use_user_token)s"},{"line_number":498,"context_line":"[oslo_policy]"},{"line_number":499,"context_line":"policy_file \u003d %(policy_file)s"},{"line_number":500,"context_line":"policy_default_rule \u003d %(policy_default_rule)s"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_3ce1dcfe","line":497,"updated":"2015-10-07 22:35:03.000000000","message":"hmm, I wonder if there would stick","commit_id":"8033dbd518dcb54a51e05297c2413b8433de3f3f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"70c5e5d3deca97af91d6353c1a93343ed5d74494","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    fakeauth"},{"line_number":395,"context_line":"    cache"},{"line_number":396,"context_line":"    cache_manage"},{"line_number":397,"context_line":"    rootapp"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"[pipeline:glance-api-fakeauth]"},{"line_number":400,"context_line":"pipeline \u003d healthcheck versionnegotiation gzip fakeauth context rootapp"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_a8410765","line":397,"updated":"2015-10-21 13:25:19.000000000","message":"shouldn\u0027t this also have the context middleware?","commit_id":"5490d31c3a677acebf0a7ff90d6972312ac27c8f"}]}
