)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"change_message_id":"cc3b696df64300681a554d958db62f9b473a4d9f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For now use a \u0027size_checked_iter\u0027 to generate a"},{"line_number":11,"context_line":"notification. The future cache rework will allow"},{"line_number":12,"context_line":"us to remove this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fix for bug 1132755."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iec01efb93d7a1853973d355221d06fad9631afd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAN3%2F%2F%2BxQ%3D","line":13,"updated":"2013-03-04 18:50:52.000000000","message":"Is there a blueprint for this rework or some additional information that could be referenced?","commit_id":"04425606911302ce408ecd3359f85b3068048477"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"c4b11dd854f3e8e8d3352ffd7cc45e3f04fadc14","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For now use a \u0027size_checked_iter\u0027 to generate a"},{"line_number":11,"context_line":"notification. The future cache rework will allow"},{"line_number":12,"context_line":"us to remove this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fix for bug 1132755."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iec01efb93d7a1853973d355221d06fad9631afd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAN3%2F%2F%2BFg%3D","line":13,"in_reply_to":"AAAAN3%2F%2F%2Bt4%3D","updated":"2013-03-05 00:37:05.000000000","message":"I don\u0027t imagine so, but only because this work is targeted to a bug fix, and isn\u0027t directly related to the blueprint. But then again it wouldn\u0027t hurt, nor would it likely hurt to simply remove the forward-looking statement from the commit message entirely.","commit_id":"04425606911302ce408ecd3359f85b3068048477"},{"author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"change_message_id":"e5b940f1b060a697d8d20ebd8c8a9943198af798","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For now use a \u0027size_checked_iter\u0027 to generate a"},{"line_number":11,"context_line":"notification. The future cache rework will allow"},{"line_number":12,"context_line":"us to remove this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fix for bug 1132755."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iec01efb93d7a1853973d355221d06fad9631afd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAN3%2F%2F%2Bt4%3D","line":13,"in_reply_to":"AAAAN3%2F%2F%2BvU%3D","updated":"2013-03-04 19:08:05.000000000","message":"Thanks!  Should that be referenced in the commit message?","commit_id":"04425606911302ce408ecd3359f85b3068048477"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"4e4008f3e53f21d68c7870acce7bc18682b8dd63","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For now use a \u0027size_checked_iter\u0027 to generate a"},{"line_number":11,"context_line":"notification. The future cache rework will allow"},{"line_number":12,"context_line":"us to remove this."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Fix for bug 1132755."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iec01efb93d7a1853973d355221d06fad9631afd7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAN3%2F%2F%2BvU%3D","line":13,"in_reply_to":"AAAAN3%2F%2F%2BxQ%3D","updated":"2013-03-04 19:01:48.000000000","message":"I think this is what you\u0027re looking for:\nhttps://blueprints.launchpad.net/glance/+spec/move-caching-out-of-middleware","commit_id":"04425606911302ce408ecd3359f85b3068048477"}],"glance/api/middleware/cache.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"e01db0712deedd39c8cf0b93a68c37b427eb1ecf","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return self.serializer.show(response, raw_response)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _process_v2_request(self, request, image_id, image_iterator):"},{"line_number":158,"context_line":"        image_meta \u003d self._get_image_meta(request, image_id)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        response \u003d webob.Response(request\u003drequest)"},{"line_number":161,"context_line":"        # TODO(mclaren): For now use size_checked_iter in order"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2Bsg%3D","line":158,"updated":"2013-02-28 19:11:06.000000000","message":"I don\u0027t think it is safe to rely on the existence of the registry in a v2 context.","commit_id":"a3cd1c28ec125dc64a37ef60d320fe93671e356d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"27479f31d64db1bd3e7cf72648d7c61e289002b8","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return self.serializer.show(response, raw_response)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _process_v2_request(self, request, image_id, image_iterator):"},{"line_number":158,"context_line":"        image_meta \u003d self._get_image_meta(request, image_id)"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        response \u003d webob.Response(request\u003drequest)"},{"line_number":161,"context_line":"        # TODO(mclaren): For now use size_checked_iter in order"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FmE%3D","line":158,"in_reply_to":"AAAANH%2F%2F%2Bsg%3D","updated":"2013-03-04 10:18:17.000000000","message":"Yes -- thanks for pointing this out.","commit_id":"a3cd1c28ec125dc64a37ef60d320fe93671e356d"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"e01db0712deedd39c8cf0b93a68c37b427eb1ecf","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # to generate a notification. The cache rework blueprint"},{"line_number":163,"context_line":"        # \u0027move-caching-out-of-middleware\u0027 should remove the"},{"line_number":164,"context_line":"        # need to call size_checked_iter here."},{"line_number":165,"context_line":"        response.app_iter \u003d size_checked_iter(response, image_meta,"},{"line_number":166,"context_line":"                                              image_meta[\u0027size\u0027],"},{"line_number":167,"context_line":"                                              image_iterator,"},{"line_number":168,"context_line":"                                              notifier.Notifier())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BsE%3D","line":165,"updated":"2013-02-28 19:11:06.000000000","message":"Maybe we can get image meta a different way without the registry? It might be okay to just cheat:\n\n  db_api \u003d ...\n  image_repo \u003d glance.db.ImageRepo(request.context, db_api)\n  image \u003d image_repo.get(image_id)\n  image_meta \u003d glance.notifier.format_image_notification(image)","commit_id":"a3cd1c28ec125dc64a37ef60d320fe93671e356d"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"27479f31d64db1bd3e7cf72648d7c61e289002b8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # to generate a notification. The cache rework blueprint"},{"line_number":163,"context_line":"        # \u0027move-caching-out-of-middleware\u0027 should remove the"},{"line_number":164,"context_line":"        # need to call size_checked_iter here."},{"line_number":165,"context_line":"        response.app_iter \u003d size_checked_iter(response, image_meta,"},{"line_number":166,"context_line":"                                              image_meta[\u0027size\u0027],"},{"line_number":167,"context_line":"                                              image_iterator,"},{"line_number":168,"context_line":"                                              notifier.Notifier())"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FmA%3D","line":165,"in_reply_to":"AAAANH%2F%2F%2BsE%3D","updated":"2013-03-04 10:18:17.000000000","message":"Useful hint Mark -- thanks.","commit_id":"a3cd1c28ec125dc64a37ef60d320fe93671e356d"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"576a57696edb41412be31d24cbb4c95841a8e0a6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        return self.serializer.show(response, raw_response)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def _process_v2_request(self, request, image_id, image_iterator):"},{"line_number":160,"context_line":"        # We do some contortions to get the image_metadata so"},{"line_number":161,"context_line":"        # that we can provide it to \u0027size_checked_iter\u0027 which"},{"line_number":162,"context_line":"        # will generate a notification. We will do this more"},{"line_number":163,"context_line":"        # naturally once caching is part of the domain model."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F%2FGo%3D","line":160,"updated":"2013-03-04 16:49:12.000000000","message":"perhaps you should use TODO(nick) here so that it can be grepped or whatever if needed.","commit_id":"a086fdd4ab5104808c8ed846bcb9af4d509362fd"}]}