)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"e846b7081b7e83c3350657c8e3b92874599f51c4","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                    image_view[\u0027direct_url\u0027] \u003d l[\u0027url\u0027]"},{"line_number":753,"context_line":"                else:"},{"line_number":754,"context_line":"                    # The same as show_multiple_locations does."},{"line_number":755,"context_line":"                    image_view[\u0027direct_url\u0027] \u003d \u0027\u0027"},{"line_number":756,"context_line":"                    LOG.debug(\"There is not available location \""},{"line_number":757,"context_line":"                              \"for image %s\", image.image_id)"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_77205f4a","line":755,"updated":"2015-11-16 11:46:18.000000000","message":"I don\u0027t think we can just add this and be happy :(\n\nThere could be scripts that check whether `direct_url` is present and decide what to do based on that.\n\nFWIW, I\u0027d prefer having it and make the API consistent. We could, perhaps, bump the minor number of the API as there will be other changes that will need a version bump anyways.\n\nAlso, should the value be `None` instead of an empty string?","commit_id":"573cc160449ede3b3fea9814643f2aa7cfdb0a8b"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"8b670ca3b11bb38eefdc5350e211c15c99e6a760","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                    image_view[\u0027direct_url\u0027] \u003d l[\u0027url\u0027]"},{"line_number":753,"context_line":"                else:"},{"line_number":754,"context_line":"                    # The same as show_multiple_locations does."},{"line_number":755,"context_line":"                    image_view[\u0027direct_url\u0027] \u003d \u0027\u0027"},{"line_number":756,"context_line":"                    LOG.debug(\"There is not available location \""},{"line_number":757,"context_line":"                              \"for image %s\", image.image_id)"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_9197d68f","line":755,"in_reply_to":"ba8a016a_77205f4a","updated":"2015-11-17 10:48:16.000000000","message":"Set to None looks bad, because the type of the schema[\u0027properties\u0027][\u0027direct_url\u0027] is string.\n\nSo you mean that we need introduce micro-version to Glance like Nova does for every APIImpact change? or just need a version bump for this patch here?","commit_id":"573cc160449ede3b3fea9814643f2aa7cfdb0a8b"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"ffc2da7106e0e0c1401692445ae2623593ff0a2f","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                    image_view[\u0027direct_url\u0027] \u003d l[\u0027url\u0027]"},{"line_number":753,"context_line":"                else:"},{"line_number":754,"context_line":"                    # The same as show_multiple_locations does."},{"line_number":755,"context_line":"                    image_view[\u0027direct_url\u0027] \u003d \u0027\u0027"},{"line_number":756,"context_line":"                    LOG.debug(\"There is not available location \""},{"line_number":757,"context_line":"                              \"for image %s\", image.image_id)"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_c30ca63d","line":755,"in_reply_to":"ba8a016a_9197d68f","updated":"2015-11-17 15:26:05.000000000","message":"I see that locations attribute logic is the same. I think in order to be consistent we should direct_url in the same way.","commit_id":"573cc160449ede3b3fea9814643f2aa7cfdb0a8b"}]}