)]}'
{"glance/tests/unit/common/scripts/test_scripts_utils.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"4bb4301a4570ed7875518e8e4a17212f5c301b92","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          script_utils.validate_location_uri, location)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_get_image_data_http(self):"},{"line_number":140,"context_line":"        uri \u003d \"http://example.com\""},{"line_number":141,"context_line":"        response \u003d urllib.request.urlopen(uri)"},{"line_number":142,"context_line":"        expected \u003d response.read()"},{"line_number":143,"context_line":"        self.assertEqual(expected,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_f1c5de3b","line":140,"updated":"2015-12-17 23:17:07.000000000","message":"Drew, example.com will be around as long as IANA is around (https://www.iana.org/domains/reserved). If IANA ever disappears, I\u0027d be willing to bet that OpenStack had disappeared long before.","commit_id":"04784f397258e7d5ac2e806cbfb4089c45f2dd5b"},{"author":{"_account_id":17976,"name":"Drew Varner","email":"avarner@linux.vnet.ibm.com","username":"avarner"},"change_message_id":"87fbc10bf49fb39713eebf3e5ab3a91d6ccd7936","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          script_utils.validate_location_uri, location)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_get_image_data_http(self):"},{"line_number":140,"context_line":"        uri \u003d \"http://example.com\""},{"line_number":141,"context_line":"        response \u003d urllib.request.urlopen(uri)"},{"line_number":142,"context_line":"        expected \u003d response.read()"},{"line_number":143,"context_line":"        self.assertEqual(expected,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_f044f1b7","line":140,"updated":"2015-11-23 21:39:59.000000000","message":"We still shouldn\u0027t be sending requests to http://example.com since there is no guarantee that that server will always exist.","commit_id":"04784f397258e7d5ac2e806cbfb4089c45f2dd5b"},{"author":{"_account_id":17976,"name":"Drew Varner","email":"avarner@linux.vnet.ibm.com","username":"avarner"},"change_message_id":"1507d080794386d1a558414402b93c5b8cfbf0ee","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                          script_utils.validate_location_uri, location)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_get_image_data_http(self):"},{"line_number":140,"context_line":"        uri \u003d \"http://example.com\""},{"line_number":141,"context_line":"        response \u003d urllib.request.urlopen(uri)"},{"line_number":142,"context_line":"        expected \u003d response.read()"},{"line_number":143,"context_line":"        self.assertEqual(expected,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_76d1ce56","line":140,"in_reply_to":"3a7e1126_f1c5de3b","updated":"2016-01-04 17:56:09.000000000","message":"But example.com might someday close its HTTP server. I don\u0027t believe example.com is even guaranteed to resolve to an IP address. It\u0027s just guaranteed to be owned by IANA, and not resolve to some random person\u0027s server.","commit_id":"04784f397258e7d5ac2e806cbfb4089c45f2dd5b"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"d37f5a4b10cda09f1ce251454e21caf454f302b2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        response \u003d urllib.request.urlopen(uri)"},{"line_number":142,"context_line":"        expected \u003d response.read()"},{"line_number":143,"context_line":"        self.assertEqual(expected,"},{"line_number":144,"context_line":"                         script_utils.get_image_data_iter(uri).read())"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_get_image_data_https(self):"},{"line_number":147,"context_line":"        uri \u003d \"https://example.com\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_b6774439","line":144,"updated":"2015-11-10 14:03:50.000000000","message":"This doesn\u0027t test any custom code in Glance.\nIMO, this usually singalises that test is not needed.\nIt is either too detailed (so not needed) or tests case is incorrect.\nThat\u0027s why it was deleted in original fix.","commit_id":"04784f397258e7d5ac2e806cbfb4089c45f2dd5b"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"1b99ea6308918349f80e1acba60e5146a1eb3df4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        response \u003d urllib.request.urlopen(uri)"},{"line_number":142,"context_line":"        expected \u003d response.read()"},{"line_number":143,"context_line":"        self.assertEqual(expected,"},{"line_number":144,"context_line":"                         script_utils.get_image_data_iter(uri).read())"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_get_image_data_https(self):"},{"line_number":147,"context_line":"        uri \u003d \"https://example.com\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_8dcb071e","line":144,"in_reply_to":"da85f559_b6774439","updated":"2015-11-10 15:28:41.000000000","message":"This tests that our scripts_utils returns urllib equal iterator of the provided http-uri, the next one does the same with https, the last one is the only questionable test here and it was also the one that was totally unrelated to the rest of the change.\n\nIf we would stop testing all of our components that utilizes some 3rd party modules we could throw away most of our tests. I\u0027d like to re-empathize that we\u0027re testing get_image_data_iter() here which most definitely is glance code.","commit_id":"04784f397258e7d5ac2e806cbfb4089c45f2dd5b"}],"glance/tests/utils.py":[{"author":{"_account_id":17976,"name":"Drew Varner","email":"avarner@linux.vnet.ibm.com","username":"avarner"},"change_message_id":"87fbc10bf49fb39713eebf3e5ab3a91d6ccd7936","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                return"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"            def do_HEAD(self):"},{"line_number":447,"context_line":"                self.send_response(200)"},{"line_number":448,"context_line":"                self.send_header(\u0027Content-Length\u0027, str(len(fixture)))"},{"line_number":449,"context_line":"                self.end_headers()"},{"line_number":450,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b092e949","line":447,"updated":"2015-11-23 21:39:59.000000000","message":"If we do want to keep this, I thing it should be changed to a test for equality (since there could theoretically be legitimate URLs containing \u0027non_existing_image_path\u0027) \n\nIt also needs to behave identically in HEAD and GET.","commit_id":"04784f397258e7d5ac2e806cbfb4089c45f2dd5b"}]}