)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d32cbdc1681d2ee8ab2733acb003283ff7a5f272","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Starting with opsrofiler 0.3.1 release there is no need to set HMAC_KEYS"},{"line_number":10,"context_line":"and ENABLED arguments in the glance-api-paste.ini and"},{"line_number":11,"context_line":"glance-registry-paste.ini files, this can be set in the glance.conf"},{"line_number":12,"context_line":"configuration file."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I068504913c93be0f506262930eadc2e40879ce0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_8efd3e3c","line":11,"updated":"2015-12-07 11:36:33.000000000","message":"We do not have glance.conf config file.","commit_id":"8de704d5b004d424d26fea0f23bd8b1079a6e0d4"}],"etc/glance-api-paste.ini":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d32cbdc1681d2ee8ab2733acb003283ff7a5f272","unresolved":false,"context_lines":[{"line_number":83,"context_line":"[filter:osprofiler]"},{"line_number":84,"context_line":"paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory"},{"line_number":85,"context_line":"hmac_keys \u003d SECRET_KEY"},{"line_number":86,"context_line":"enabled \u003d yes"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7a740942_09270865","side":"PARENT","line":86,"updated":"2015-12-07 11:36:33.000000000","message":"These should not be removed, but marked as deprecated for now as per normal deprecation policy.","commit_id":"ec2e889f4d5277618ff822e6bfdcb21edbaf974c"}],"etc/glance-registry-paste.ini":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d32cbdc1681d2ee8ab2733acb003283ff7a5f272","unresolved":false,"context_lines":[{"line_number":32,"context_line":"[filter:osprofiler]"},{"line_number":33,"context_line":"paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory"},{"line_number":34,"context_line":"hmac_keys \u003d SECRET_KEY"},{"line_number":35,"context_line":"enabled \u003d yes"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7a740942_e91cfc14","side":"PARENT","line":35,"updated":"2015-12-07 11:36:33.000000000","message":"Ditto","commit_id":"ec2e889f4d5277618ff822e6bfdcb21edbaf974c"}],"glance/common/wsgi.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d32cbdc1681d2ee8ab2733acb003283ff7a5f272","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                help\u003d_(\u0027If False fully disable profiling feature.\u0027)),"},{"line_number":111,"context_line":"    cfg.BoolOpt(\"trace_sqlalchemy\", default\u003dFalse,"},{"line_number":112,"context_line":"                help\u003d_(\"If False doesn\u0027t trace SQL requests.\")),"},{"line_number":113,"context_line":"    cfg.StrOpt(\"api_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":114,"context_line":"               help\u003d_(\"Secret key to use to sign Glance API \""},{"line_number":115,"context_line":"                      \"tracing messages.\")),"},{"line_number":116,"context_line":"    cfg.StrOpt(\"registry_hmac_keys\", default\u003d\"SECRET_KEY\","}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_698c8c35","line":113,"updated":"2015-12-07 11:36:33.000000000","message":"Why should glance-registry.conf have api_hmac_keys?","commit_id":"8de704d5b004d424d26fea0f23bd8b1079a6e0d4"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d32cbdc1681d2ee8ab2733acb003283ff7a5f272","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    cfg.StrOpt(\"api_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":114,"context_line":"               help\u003d_(\"Secret key to use to sign Glance API \""},{"line_number":115,"context_line":"                      \"tracing messages.\")),"},{"line_number":116,"context_line":"    cfg.StrOpt(\"registry_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":117,"context_line":"               help\u003d_(\"Secret key to use to sign Glance Registry \""},{"line_number":118,"context_line":"                      \"tracing messages.\")),"},{"line_number":119,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_a9727447","line":116,"updated":"2015-12-07 11:36:33.000000000","message":"Same other way around, why should we put registry_hmac_keys to glance-api.conf? Can we just use single hmac_keys option?","commit_id":"8de704d5b004d424d26fea0f23bd8b1079a6e0d4"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5d6c8237e21a1532c1093808309363423c0fa6f6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    cfg.StrOpt(\"api_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":114,"context_line":"               help\u003d_(\"Secret key to use to sign Glance API \""},{"line_number":115,"context_line":"                      \"tracing messages.\")),"},{"line_number":116,"context_line":"    cfg.StrOpt(\"registry_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":117,"context_line":"               help\u003d_(\"Secret key to use to sign Glance Registry \""},{"line_number":118,"context_line":"                      \"tracing messages.\")),"},{"line_number":119,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_a59ccd0f","line":116,"in_reply_to":"7a740942_93f0feff","updated":"2015-12-07 14:22:58.000000000","message":"One key set for each service ... as pointed out in the commit message, we do not have glance.conf ... the conf will be populated for glance-api and glance-registry from different config files and even they share the code and variable names there is nothing preventing the keys being different for the two different services.\n\nIt just makes your life unnecessary difficult if you want to name them for registry and api as then you need to build the profiler opts here separately for each service to avoid them having both in both config files.","commit_id":"8de704d5b004d424d26fea0f23bd8b1079a6e0d4"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"df59e2a191a8f7d50b83e0a2bcf630630e4ba5c5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    cfg.StrOpt(\"api_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":114,"context_line":"               help\u003d_(\"Secret key to use to sign Glance API \""},{"line_number":115,"context_line":"                      \"tracing messages.\")),"},{"line_number":116,"context_line":"    cfg.StrOpt(\"registry_hmac_keys\", default\u003d\"SECRET_KEY\","},{"line_number":117,"context_line":"               help\u003d_(\"Secret key to use to sign Glance Registry \""},{"line_number":118,"context_line":"                      \"tracing messages.\")),"},{"line_number":119,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_93f0feff","line":116,"in_reply_to":"7a740942_a9727447","updated":"2015-12-07 13:58:46.000000000","message":"if it\u0027s enough to have one keys set for all glance services - yep, sure. I can change this","commit_id":"8de704d5b004d424d26fea0f23bd8b1079a6e0d4"}],"glance/opts.py":[{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"236605cf431b35b1972f77c4c600d07a7b657405","unresolved":false,"context_lines":[{"line_number":66,"context_line":"     glance.async.taskflow_executor.taskflow_executor_opts),"},{"line_number":67,"context_line":"    (\u0027store_type_location_strategy\u0027,"},{"line_number":68,"context_line":"     glance.common.location_strategy.store_type.store_type_opts),"},{"line_number":69,"context_line":"    (\u0027profiler\u0027, glance.common.wsgi.profiler_opts),"},{"line_number":70,"context_line":"    (\u0027paste_deploy\u0027, glance.common.config.paste_deploy_opts)"},{"line_number":71,"context_line":"]"},{"line_number":72,"context_line":"_registry_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_97fff5a9","line":69,"updated":"2015-12-09 19:42:07.000000000","message":"Ah, good catch!","commit_id":"c30041c8b8235b75f1f836018ae02c303b87f860"}],"releasenotes/notes/remove-osprofiler-paste-ini-options-c620dedc8f9728ff.yaml":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"140db5f4c4f4006cd2ab1418589567317da4992a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the corresponding configuration files)."},{"line_number":9,"context_line":"    OSprofiler 0.3.1 and higher supports passing this information"},{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the following *-paste.ini section to look like:"},{"line_number":12,"context_line":"    | ``[filter:osprofiler]``"},{"line_number":13,"context_line":"    | ``paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":14,"context_line":"    | and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a710552_7c223703","line":11,"updated":"2015-12-15 22:50:03.000000000","message":"So having a \u0027:\u0027 in here is invalid syntax. You may want to do something like\n\n    deprecations:\n      - \u003e\n          OSprofiler ...\n          ...\n          modify the ``[filter:osprofiler]`` section in  *-paste.ini  to look like:\n          ``paste.filter_factor \u003d osprofiler.web:WsgiMiddleware.factory``\n          and ...","commit_id":"7bafae17a7928e50a7bfdee5fa40aebe69bde7da"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"5c66448606703f22b5d583a77906959cd0242806","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the corresponding configuration files)."},{"line_number":9,"context_line":"    OSprofiler 0.3.1 and higher supports passing this information"},{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the following *-paste.ini section to look like:"},{"line_number":12,"context_line":"    | ``[filter:osprofiler]``"},{"line_number":13,"context_line":"    | ``paste.filter_factory \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":14,"context_line":"    | and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a710552_88bd466a","line":11,"in_reply_to":"5a710552_7c223703","updated":"2015-12-16 09:56:27.000000000","message":"oh, thank you sir!","commit_id":"7bafae17a7928e50a7bfdee5fa40aebe69bde7da"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fe954bb04dd98659e049e103cd0bcd22155afc59","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the corresponding configuration files)."},{"line_number":9,"context_line":"    OSprofiler 0.3.1 and higher supports passing this information"},{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the ``[filter:osprofiler]`` section in  *-paste.ini to look like"},{"line_number":12,"context_line":"    ``paste.filter_factor \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":13,"context_line":"    and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa69d971_2fd93f57","line":11,"updated":"2016-01-07 01:58:28.000000000","message":"\\* \n\nThis is causing the text between *-paste.ini \u0026 *.conf to be emphasized in italic.","commit_id":"5cae10fa4e55ff699942c739273f87162021e1aa"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"22350cd8dfef7459aafbc4763592afc01d7a6564","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the corresponding configuration files)."},{"line_number":9,"context_line":"    OSprofiler 0.3.1 and higher supports passing this information"},{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the ``[filter:osprofiler]`` section in  *-paste.ini to look like"},{"line_number":12,"context_line":"    ``paste.filter_factor \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":13,"context_line":"    and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa69d971_d29ebc06","line":11,"in_reply_to":"fa69d971_2fd93f57","updated":"2016-01-08 05:43:35.000000000","message":"Good catch Sabari!","commit_id":"5cae10fa4e55ff699942c739273f87162021e1aa"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"50461c559d2c074c06d86147b82897f99180a86b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the corresponding configuration files)."},{"line_number":9,"context_line":"    OSprofiler 0.3.1 and higher supports passing this information"},{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the ``[filter:osprofiler]`` section in  *-paste.ini to look like"},{"line_number":12,"context_line":"    ``paste.filter_factor \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":13,"context_line":"    and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa69d971_e237ffad","line":11,"in_reply_to":"fa69d971_4f2f7a3e","updated":"2016-01-11 14:56:28.000000000","message":"Done","commit_id":"5cae10fa4e55ff699942c739273f87162021e1aa"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ad1c836241d92d9e9494be2a716acff51f15756d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    the corresponding configuration files)."},{"line_number":9,"context_line":"    OSprofiler 0.3.1 and higher supports passing this information"},{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the ``[filter:osprofiler]`` section in  *-paste.ini to look like"},{"line_number":12,"context_line":"    ``paste.filter_factor \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":13,"context_line":"    and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa69d971_4f2f7a3e","line":11,"in_reply_to":"fa69d971_d29ebc06","updated":"2016-01-08 07:53:19.000000000","message":"Dina is in middle of great Russian new year holidays\u003d)","commit_id":"5cae10fa4e55ff699942c739273f87162021e1aa"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"fe954bb04dd98659e049e103cd0bcd22155afc59","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    via configuration files, therefore it\u0027s recommended to"},{"line_number":11,"context_line":"    modify the ``[filter:osprofiler]`` section in  *-paste.ini to look like"},{"line_number":12,"context_line":"    ``paste.filter_factor \u003d osprofiler.web:WsgiMiddleware.factory``"},{"line_number":13,"context_line":"    and set the ``hmac_keys`` option in the glance-*.conf files."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa69d971_cfb2e305","line":13,"updated":"2016-01-07 01:58:28.000000000","message":"\\*","commit_id":"5cae10fa4e55ff699942c739273f87162021e1aa"}]}