)]}'
{"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6b5971b6c8b7a4a093775944c7cb8e3f326018a0","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                threshold \u003d timeutils.normalize_time(parsed_time)"},{"line_number":482,"context_line":"            except ValueError:"},{"line_number":483,"context_line":"                msg \u003d (_(\"The format of the time %s is not valid. \""},{"line_number":484,"context_line":"                         \"Use ISO 8601 DateTime notation.\") % isotime)"},{"line_number":485,"context_line":"                raise exception.InvalidParameterValue(msg)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"            comparison \u003d utils.evaluate_filter_op(attr_value, operator,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_3d773fa1","line":484,"updated":"2015-11-19 20:07:48.000000000","message":"I wonder whether it\u0027s really necessary to output the user\u0027s input here (though I admit it could be helpful when the user\u0027s trying to figure out what\u0027s wrong).  Maybe I\u0027m being stupid, but using unfiltered user input gives me a queasy feeling.  I realize we\u0027re not writing javascript, but still ...","commit_id":"2341f65617df9085ad92b14af3ada1ace8a6c79a"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"c7db4b36e0a033025841c3b6ae5e4e10b925aa43","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                threshold \u003d timeutils.normalize_time(parsed_time)"},{"line_number":482,"context_line":"            except ValueError:"},{"line_number":483,"context_line":"                msg \u003d (_(\"The format of the time %s is not valid. \""},{"line_number":484,"context_line":"                         \"Use ISO 8601 DateTime notation.\") % isotime)"},{"line_number":485,"context_line":"                raise exception.InvalidParameterValue(msg)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"            comparison \u003d utils.evaluate_filter_op(attr_value, operator,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_cdca851a","line":484,"in_reply_to":"ba8a016a_3d773fa1","updated":"2015-11-23 17:24:45.000000000","message":"I\u0027ve no problem with this being taken out. Rather than just removing it, it may be helpful to be more specific that it\u0027s the query filter rather than some other unrelated \u0027time\u0027 that\u0027s causing a problem. Maybe:\n\n\t                msg \u003d (_(\"Bad \\\"%s\\\" query filter format. \"\n                         \"Use ISO 8601 DateTime notation.\") % k)\n\nie Bad \"created_at\" query filter format...","commit_id":"2341f65617df9085ad92b14af3ada1ace8a6c79a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e0ca727a421d1385d87ade15c9a77100f1a5fcaa","unresolved":false,"context_lines":[{"line_number":481,"context_line":"                threshold \u003d timeutils.normalize_time(parsed_time)"},{"line_number":482,"context_line":"            except ValueError:"},{"line_number":483,"context_line":"                msg \u003d (_(\"The format of the time %s is not valid. \""},{"line_number":484,"context_line":"                         \"Use ISO 8601 DateTime notation.\") % isotime)"},{"line_number":485,"context_line":"                raise exception.InvalidParameterValue(msg)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"            comparison \u003d utils.evaluate_filter_op(attr_value, operator,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d9024309","line":484,"in_reply_to":"ba8a016a_cdca851a","updated":"2015-11-23 18:20:30.000000000","message":"That\u0027s a good suggestion.  It will definitely make the error message helpful to the user.","commit_id":"2341f65617df9085ad92b14af3ada1ace8a6c79a"}]}