)]}'
{"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b03987d7d3f35b5fd52f5d4902383ed488770e6d","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    \"\"\"Find all members that meet the given criteria"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    :param image_id: identifier of image entity"},{"line_number":718,"context_line":"    :param member: tenant to which membership has been granted"},{"line_number":719,"context_line":"    \"\"\""},{"line_number":720,"context_line":"    session \u003d session or get_session()"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8X0%3D","line":718,"updated":"2013-03-19 23:08:53.000000000","message":"hey,\n\nperhaps we should document show_deleted here (and session)?","commit_id":"98b79d5ea2356e0312f0352f73e69a565219cd7c"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"33c0ac454eabb897a4212f21ec1ff168523ba054","unresolved":false,"context_lines":[{"line_number":715,"context_line":"    \"\"\"Find all members that meet the given criteria"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"    :param image_id: identifier of image entity"},{"line_number":718,"context_line":"    :param member: tenant to which membership has been granted"},{"line_number":719,"context_line":"    \"\"\""},{"line_number":720,"context_line":"    session \u003d session or get_session()"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8WM%3D","line":718,"in_reply_to":"AAAAOH%2F%2F8X0%3D","updated":"2013-03-19 23:20:18.000000000","message":"Fair point.","commit_id":"98b79d5ea2356e0312f0352f73e69a565219cd7c"}],"glance/tests/unit/v1/test_api.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b03987d7d3f35b5fd52f5d4902383ed488770e6d","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        res \u003d req.get_response(self.api)"},{"line_number":1940,"context_line":"        self.assertEquals(res.status_int, webob.exc.HTTPNotFound.code)"},{"line_number":1941,"context_line":"        self.assertTrue(\u0027Membership could not be found\u0027 in res.body)"},{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":"class TestGlanceAPI(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8Xg%3D","line":1941,"updated":"2013-03-19 23:08:53.000000000","message":"Hey,\n\nIt would be better to use assertIn in these cases (not mandatory, though): \n\nself.assertIn(\u0027.......\u0027, res.body)","commit_id":"98b79d5ea2356e0312f0352f73e69a565219cd7c"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8a7d347bbd8cb64f3cb1b3b6c847492930bbcabb","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        res \u003d req.get_response(self.api)"},{"line_number":1940,"context_line":"        self.assertEquals(res.status_int, webob.exc.HTTPNotFound.code)"},{"line_number":1941,"context_line":"        self.assertTrue(\u0027Membership could not be found\u0027 in res.body)"},{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":"class TestGlanceAPI(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F75w%3D","line":1941,"in_reply_to":"AAAAOH%2F%2F8Wo%3D","updated":"2013-03-20 09:51:57.000000000","message":"Yes, but testtools support it (also for py26). I\u0027m ok with both but I guess assertIn is more readable in this case","commit_id":"98b79d5ea2356e0312f0352f73e69a565219cd7c"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"33c0ac454eabb897a4212f21ec1ff168523ba054","unresolved":false,"context_lines":[{"line_number":1938,"context_line":""},{"line_number":1939,"context_line":"        res \u003d req.get_response(self.api)"},{"line_number":1940,"context_line":"        self.assertEquals(res.status_int, webob.exc.HTTPNotFound.code)"},{"line_number":1941,"context_line":"        self.assertTrue(\u0027Membership could not be found\u0027 in res.body)"},{"line_number":1942,"context_line":""},{"line_number":1943,"context_line":""},{"line_number":1944,"context_line":"class TestGlanceAPI(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F8Wo%3D","line":1941,"in_reply_to":"AAAAOH%2F%2F8Xg%3D","updated":"2013-03-19 23:20:18.000000000","message":"Well, unittest.TestCase.assertIn is new python 2.7:\n\n  http://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIn\n\nwhereas these tests need to run against py26 also.","commit_id":"98b79d5ea2356e0312f0352f73e69a565219cd7c"}]}
