)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"change_message_id":"ca6dbe573059c77841f48789ded1603f0f785619","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flaper Fesp \u003cflaper87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-21 13:36:13 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check if creds are presend and not None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, KeystoneStrategy checks whether the required credentials are"},{"line_number":10,"context_line":"present in the creds dict but it doesn\u0027t check whether they are valid or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOH%2F%2F59U%3D","line":7,"updated":"2013-03-21 14:20:37.000000000","message":"s/presend/present/","commit_id":"e749d5806011f3b357acdfbeb80d8f722da7638b"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"370e009c3dfbd82b90f88dbdce116895e6e99a0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flaper Fesp \u003cflaper87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-21 13:36:13 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check if creds are presend and not None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, KeystoneStrategy checks whether the required credentials are"},{"line_number":10,"context_line":"present in the creds dict but it doesn\u0027t check whether they are valid or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOH%2F%2F5rU%3D","line":7,"in_reply_to":"AAAAOH%2F%2F59U%3D","updated":"2013-03-21 17:05:04.000000000","message":"Done","commit_id":"e749d5806011f3b357acdfbeb80d8f722da7638b"}],"glance/common/auth.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"7e24d0d8eb496dfcf0708d075375e7baa1df2811","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                            received\u003dself.creds[\u0027strategy\u0027])"},{"line_number":93,"context_line":"        # For v2.0 also check tenant is present"},{"line_number":94,"context_line":"        if self.creds[\u0027auth_url\u0027].rstrip(\u0027/\u0027).endswith(\u0027v2.0\u0027):"},{"line_number":95,"context_line":"            if self.creds.get(required) is None:"},{"line_number":96,"context_line":"                raise exception.MissingCredentialError(required\u003d\u0027tenant\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def authenticate(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6JA%3D","line":95,"updated":"2013-03-21 11:52:27.000000000","message":"I\u0027m struggling to see the equivalence between the old and now logic here, seeing as the \u0027tenant\u0027 mapping is no longer checked for.\n\nShould this be:\n\n -  if self.creds.get(required) is None:\n +  if self.creds.get(\u0027tenant\u0027) is None:","commit_id":"2d075dd99092c0ebd55b662746c552b5b4525434"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"b27a2760e14cf2dc0cacae447d6929682cfb885b","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                                            received\u003dself.creds[\u0027strategy\u0027])"},{"line_number":93,"context_line":"        # For v2.0 also check tenant is present"},{"line_number":94,"context_line":"        if self.creds[\u0027auth_url\u0027].rstrip(\u0027/\u0027).endswith(\u0027v2.0\u0027):"},{"line_number":95,"context_line":"            if self.creds.get(required) is None:"},{"line_number":96,"context_line":"                raise exception.MissingCredentialError(required\u003d\u0027tenant\u0027)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def authenticate(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6GE%3D","line":95,"in_reply_to":"AAAAOH%2F%2F6JA%3D","updated":"2013-03-21 12:34:56.000000000","message":"mhh, (facepalm), that\u0027s actually a bug and since required was already defined in the above loop, I didn\u0027t notice it.\n\nSorry about that and really good catch!","commit_id":"2d075dd99092c0ebd55b662746c552b5b4525434"}]}