)]}'
{"glance/common/client.py":[{"author":{"_account_id":17116,"name":"Niall Bunting","email":"niall.bunting@hpe.com","username":"NiallBunting"},"change_message_id":"867bda13ff11faa09ca44fed88f58b54271bf47f","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                body \u003d res.read()"},{"line_number":516,"context_line":"                if six.PY3:"},{"line_number":517,"context_line":"                    body \u003d body.decode(\u0027utf-8\u0027)"},{"line_number":518,"context_line":"                return body"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"            status_code \u003d self.get_status_code(res)"},{"line_number":521,"context_line":"            if status_code in self.OK_RESPONSE_CODES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_13fc3a3d","line":518,"updated":"2015-12-01 17:53:59.000000000","message":"Should be a private method? To keep it encapsulated?","commit_id":"4b80fa55a7c9dc47ecbb2d91427a81c3507b8c24"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"e2c727c518a0143d102351e4ff9316c76211b534","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                body \u003d res.read()"},{"line_number":516,"context_line":"                if six.PY3:"},{"line_number":517,"context_line":"                    body \u003d body.decode(\u0027utf-8\u0027)"},{"line_number":518,"context_line":"                return body"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"            status_code \u003d self.get_status_code(res)"},{"line_number":521,"context_line":"            if status_code in self.OK_RESPONSE_CODES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ec9af0c4","line":518,"in_reply_to":"9a8ffd7b_13fc3a3d","updated":"2015-12-01 20:20:23.000000000","message":"It\u0027s not a method, it\u0027s a nested function defined in a method ;-) See the indentation level.","commit_id":"4b80fa55a7c9dc47ecbb2d91427a81c3507b8c24"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"f8b5c10f58f5aba5be06cd1c83a660dc66f3ba98","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                body \u003d res.read()"},{"line_number":516,"context_line":"                if six.PY3:"},{"line_number":517,"context_line":"                    body \u003d body.decode(\u0027utf-8\u0027)"},{"line_number":518,"context_line":"                return body"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"            status_code \u003d self.get_status_code(res)"},{"line_number":521,"context_line":"            if status_code in self.OK_RESPONSE_CODES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_fbaf3fe1","line":518,"in_reply_to":"9a8ffd7b_ec9af0c4","updated":"2015-12-04 02:11:17.000000000","message":"I think he just meant similar to line 473 but I think what you wrote is fine. The method can\u0027t be static to be used outside of the module and so that differentiation doesn\u0027t matter much.","commit_id":"4b80fa55a7c9dc47ecbb2d91427a81c3507b8c24"}]}