)]}'
{"glance/tests/functional/test_scrubber.py":[{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"11a0be595b05f4d2eac4a5045ba40c10603a6104","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        loc \u003d StoreLocation({})"},{"line_number":250,"context_line":"        loc.parse_uri(decrypted_uri)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertTrue((loc.scheme \u003d\u003d \"swift+http\") or"},{"line_number":253,"context_line":"                        (loc.scheme \u003d\u003d \"swift+https\"))"},{"line_number":254,"context_line":"        self.assertEqual(image[\u0027id\u0027], loc.obj)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fz4k%3D","line":252,"updated":"2013-03-26 17:36:56.000000000","message":"I usually like to do these as\n\n  self.assertTrue(loc.scheme in (\"swift+http\", \"swift+https\"))\n\nor even use assertIn if we support it","commit_id":"e9804a2448b0f5f6a933ae2e06a6cea11a822650"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"763f3e31b7eadc32e6137b15731c7bc86510a060","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        loc \u003d StoreLocation({})"},{"line_number":250,"context_line":"        loc.parse_uri(decrypted_uri)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertTrue(loc.scheme in (\"swift+http\", \"swift+https\"))"},{"line_number":253,"context_line":"        self.assertEqual(image[\u0027id\u0027], loc.obj)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        wait_for_scrub(path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2F8kA%3D","line":252,"updated":"2013-04-10 17:32:20.000000000","message":"Is there a reason you didn\u0027t use self.assertIn() here?","commit_id":"ce21232731b3996e5570a6d29bd8de061857142f"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"d9006404617343791257c9dfd45e614d4e306279","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        loc \u003d StoreLocation({})"},{"line_number":250,"context_line":"        loc.parse_uri(decrypted_uri)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertTrue(loc.scheme in (\"swift+http\", \"swift+https\"))"},{"line_number":253,"context_line":"        self.assertEqual(image[\u0027id\u0027], loc.obj)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        wait_for_scrub(path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2F7FA%3D","line":252,"in_reply_to":"AAAAOn%2F%2F7S8%3D","updated":"2013-04-11 13:57:39.000000000","message":"Hey,\n\nIt\u0027s true that python 2.6 doesn\u0027t support assertIn, however, Glance\u0027s tests use testtools, which does support it.\n\nWould you mind changing this?","commit_id":"ce21232731b3996e5570a6d29bd8de061857142f"},{"author":{"_account_id":1828,"name":"john-lenihan-k","email":"john.lenihan@hp.com","username":"john-lenihan-k"},"change_message_id":"0ba90685760ac0afce41d3510e58effd6ddc6c40","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        loc \u003d StoreLocation({})"},{"line_number":250,"context_line":"        loc.parse_uri(decrypted_uri)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        self.assertTrue(loc.scheme in (\"swift+http\", \"swift+https\"))"},{"line_number":253,"context_line":"        self.assertEqual(image[\u0027id\u0027], loc.obj)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        wait_for_scrub(path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2F7S8%3D","line":252,"in_reply_to":"AAAAOn%2F%2F8kA%3D","updated":"2013-04-11 08:20:24.000000000","message":"My understanding is that this code must work on both python 2.6 and 2.7. assertIn is new to 2.7 so I chose to use assertTrue instead.","commit_id":"ce21232731b3996e5570a6d29bd8de061857142f"}]}
