)]}'
{"glance/db/sqlalchemy/api.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0d9cebc86c4c944369e51426fa84ede84264ec7c","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    :param marker: image id after which to start page"},{"line_number":496,"context_line":"    :param limit: maximum number of images to return"},{"line_number":497,"context_line":"    :param sort_key: image attribute by which results should be sorted"},{"line_number":498,"context_line":"    :param sort_dir: direction in which results should be sorted (asc, desc)"},{"line_number":499,"context_line":"    \"\"\""},{"line_number":500,"context_line":"    filters \u003d filters or {}"},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FsLI%3D","line":498,"updated":"2013-04-02 22:40:17.000000000","message":"hey,\n\nperhaps we should document is_public (and member_status) here!","commit_id":"e79d808624099777369e4ec9d95cfc5bea3499ce"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"21e18e84c9c0f0f68cc2c2c91120b382ee0b16c9","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    :param marker: image id after which to start page"},{"line_number":496,"context_line":"    :param limit: maximum number of images to return"},{"line_number":497,"context_line":"    :param sort_key: image attribute by which results should be sorted"},{"line_number":498,"context_line":"    :param sort_dir: direction in which results should be sorted (asc, desc)"},{"line_number":499,"context_line":"    \"\"\""},{"line_number":500,"context_line":"    filters \u003d filters or {}"},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FsHc%3D","line":498,"in_reply_to":"AAAAOH%2F%2FsLI%3D","updated":"2013-04-02 23:04:13.000000000","message":"Sure.","commit_id":"e79d808624099777369e4ec9d95cfc5bea3499ce"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"0d9cebc86c4c944369e51426fa84ede84264ec7c","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if is_public is not None:"},{"line_number":542,"context_line":"        query \u003d query.filter(models.Image.is_public \u003d\u003d is_public)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    if \u0027is_public\u0027 in filters:"},{"line_number":545,"context_line":"        spec \u003d models.Image.properties.any("},{"line_number":546,"context_line":"                name\u003d\u0027is_public\u0027,"},{"line_number":547,"context_line":"                value\u003dfilters.pop(\u0027is_public\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FsK0%3D","line":544,"updated":"2013-04-02 22:40:17.000000000","message":"Should the is_public passed in filters affect the is_public found in kwargs?","commit_id":"e79d808624099777369e4ec9d95cfc5bea3499ce"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"ee7f91180165043c5a5ae95ea4d9454416c11f7c","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if is_public is not None:"},{"line_number":542,"context_line":"        query \u003d query.filter(models.Image.is_public \u003d\u003d is_public)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    if \u0027is_public\u0027 in filters:"},{"line_number":545,"context_line":"        spec \u003d models.Image.properties.any("},{"line_number":546,"context_line":"                name\u003d\u0027is_public\u0027,"},{"line_number":547,"context_line":"                value\u003dfilters.pop(\u0027is_public\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOX%2F%2F%2FlI%3D","line":544,"in_reply_to":"AAAAOH%2F%2FsHg%3D","updated":"2013-04-03 09:28:33.000000000","message":"Got it! Thanks!","commit_id":"e79d808624099777369e4ec9d95cfc5bea3499ce"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"21e18e84c9c0f0f68cc2c2c91120b382ee0b16c9","unresolved":false,"context_lines":[{"line_number":541,"context_line":"    if is_public is not None:"},{"line_number":542,"context_line":"        query \u003d query.filter(models.Image.is_public \u003d\u003d is_public)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    if \u0027is_public\u0027 in filters:"},{"line_number":545,"context_line":"        spec \u003d models.Image.properties.any("},{"line_number":546,"context_line":"                name\u003d\u0027is_public\u0027,"},{"line_number":547,"context_line":"                value\u003dfilters.pop(\u0027is_public\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FsHg%3D","line":544,"in_reply_to":"AAAAOH%2F%2FsK0%3D","updated":"2013-04-02 23:04:13.000000000","message":"I don\u0027t think so. The idea behind this patch is to make is_public in kwargs independent of is_public in filters.","commit_id":"e79d808624099777369e4ec9d95cfc5bea3499ce"}],"glance/registry/api/v1/images.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c2fba19692d02420007dfce7903751bfd0d6a995","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"SUPPORTED_SORT_DIRS \u003d (\u0027asc\u0027, \u0027desc\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUPPORTED_PARAMS \u003d (\u0027limit\u0027, \u0027marker\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F1E4%3D","line":50,"updated":"2013-03-25 21:19:54.000000000","message":"Hey,\n\nShouldn\u0027t \u0027is_public\u0027 be in this tuple? (and the one in glance/api/v1/__init__.py )","commit_id":"80a919216cf75a1d28e88b6f8d11cda967dca1d7"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"791c27665f75d81fe994d41a2f33d580bf756e77","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                       \u0027size\u0027, \u0027id\u0027, \u0027created_at\u0027, \u0027updated_at\u0027)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"SUPPORTED_SORT_DIRS \u003d (\u0027asc\u0027, \u0027desc\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"SUPPORTED_PARAMS \u003d (\u0027limit\u0027, \u0027marker\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2FzxY%3D","line":50,"in_reply_to":"AAAAOH%2F%2F1E4%3D","updated":"2013-03-26 18:39:37.000000000","message":"After treading through the registry client logic, I think not. In this change I just want the registry server -\u003e db api logic to change. I don\u0027t want to reflect those changes all the way up the stack to the glance api server.","commit_id":"80a919216cf75a1d28e88b6f8d11cda967dca1d7"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"8cc3eabab175f2765734448ea21b0f1cfd983322","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # NOTE(markwash): is_public is a top-level parameter now"},{"line_number":145,"context_line":"        params[\u0027is_public\u0027] \u003d params[\u0027filters\u0027].pop(\u0027is_public\u0027, None)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            if value is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F2Lo%3D","line":145,"updated":"2013-03-25 10:00:28.000000000","message":"Hey,\n\nWouldn\u0027t it be cleaner to just call lines 166-168 here (replacing filters with params)?\n\nCheers","commit_id":"80a919216cf75a1d28e88b6f8d11cda967dca1d7"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"791c27665f75d81fe994d41a2f33d580bf756e77","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # NOTE(markwash): is_public is a top-level parameter now"},{"line_number":145,"context_line":"        params[\u0027is_public\u0027] \u003d params[\u0027filters\u0027].pop(\u0027is_public\u0027, None)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            if value is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2Fz1M%3D","line":145,"in_reply_to":"AAAAOH%2F%2F1Fk%3D","updated":"2013-03-26 18:39:37.000000000","message":"Ah yes, now I understand. Thanks--I think that would be cleaner.","commit_id":"80a919216cf75a1d28e88b6f8d11cda967dca1d7"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"c2fba19692d02420007dfce7903751bfd0d6a995","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # NOTE(markwash): is_public is a top-level parameter now"},{"line_number":145,"context_line":"        params[\u0027is_public\u0027] \u003d params[\u0027filters\u0027].pop(\u0027is_public\u0027, None)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            if value is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F1Fk%3D","line":145,"in_reply_to":"AAAAOH%2F%2F1Yw%3D","updated":"2013-03-25 21:19:54.000000000","message":"Nope, I\u0027m refering to lines 166-168:\n\nif req.context.is_admin:\n    # Only admin gets to look for non-public images\n    params[\u0027is_public\u0027] \u003d self._get_is_public(req)\n\nI replaced filters with params","commit_id":"80a919216cf75a1d28e88b6f8d11cda967dca1d7"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"0ebcaa84644caac366dda7f41c273d055d9c12a5","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        # NOTE(markwash): is_public is a top-level parameter now"},{"line_number":145,"context_line":"        params[\u0027is_public\u0027] \u003d params[\u0027filters\u0027].pop(\u0027is_public\u0027, None)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        for key, value in params.items():"},{"line_number":148,"context_line":"            if value is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOH%2F%2F1Yw%3D","line":145,"in_reply_to":"AAAAOH%2F%2F2Lo%3D","updated":"2013-03-25 18:26:40.000000000","message":"I\u0027m not sure I understand. Are you possibly referring to lines 66-68?","commit_id":"80a919216cf75a1d28e88b6f8d11cda967dca1d7"}]}