)]}'
{"glance/common/signature_utils.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"9746aba82286c59028992777111d72f5edf8e86a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            OLD_KEY_TYPE in image_properties)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def verify_signature(context, checksum_hash, image_properties):"},{"line_number":156,"context_line":"    \"\"\"Retrieve the image properties and use them to verify the signature."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    :param context: the user context for authentication"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6952e514","line":155,"updated":"2015-12-14 15:27:31.000000000","message":"Could we use debtcollector for this?\nhttp://docs.openstack.org/developer/debtcollector/","commit_id":"23518f1d6febcb0f100502d06a614acf41dcbc80"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"908d678807d84b2fbf9cd13d9e9719fca8ea9204","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            OLD_KEY_TYPE in image_properties)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def verify_signature(context, checksum_hash, image_properties):"},{"line_number":156,"context_line":"    \"\"\"Retrieve the image properties and use them to verify the signature."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    :param context: the user context for authentication"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_ef51dd0f","line":155,"in_reply_to":"7a740942_6952e514","updated":"2015-12-16 21:18:57.000000000","message":"Thank you for the recommendation -- I had not heard of debtcollector.  I will include it in an upcoming patch.","commit_id":"23518f1d6febcb0f100502d06a614acf41dcbc80"}],"glance/location.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"9746aba82286c59028992777111d72f5edf8e86a","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            size,"},{"line_number":385,"context_line":"            context\u003dself.context)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        # TODO(bpoulos): remove below if block after the Mitaka release"},{"line_number":388,"context_line":"        # Verify the signature (if correct properties are present)"},{"line_number":389,"context_line":"        if (signature_utils.should_verify_signature("},{"line_number":390,"context_line":"                self.image.extra_properties)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a9168d46","line":387,"updated":"2015-12-14 15:27:31.000000000","message":"Not reason for -1 but perhaps it is worth to encapsulate this in separate method. Then it can be easily deleted or deprecated with debtcollector.","commit_id":"23518f1d6febcb0f100502d06a614acf41dcbc80"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"908d678807d84b2fbf9cd13d9e9719fca8ea9204","unresolved":false,"context_lines":[{"line_number":384,"context_line":"            size,"},{"line_number":385,"context_line":"            context\u003dself.context)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"        # TODO(bpoulos): remove below if block after the Mitaka release"},{"line_number":388,"context_line":"        # Verify the signature (if correct properties are present)"},{"line_number":389,"context_line":"        if (signature_utils.should_verify_signature("},{"line_number":390,"context_line":"                self.image.extra_properties)):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_af5bd52d","line":387,"in_reply_to":"7a740942_a9168d46","updated":"2015-12-16 21:18:57.000000000","message":"Agreed.","commit_id":"23518f1d6febcb0f100502d06a614acf41dcbc80"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9924400f7e46f3006e8f99bc3df3c2f3a1ce2bd8","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    @debtcollector.removals.remove("},{"line_number":397,"context_line":"        message\u003d\"This will be removed in the N cycle.\")"},{"line_number":398,"context_line":"    def _verify_signature_if_needed(self, checksum):"},{"line_number":399,"context_line":"        # Verify the signature (if correct properties are present)"},{"line_number":400,"context_line":"        if (signature_utils.should_verify_signature("},{"line_number":401,"context_line":"                self.image.extra_properties)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_b22f0a87","line":398,"updated":"2015-12-20 16:16:40.000000000","message":"Since this is method is marked as private, I think it\u0027d be fine to remove the deprecation warning. Not big deal, just if you happen to upload a new PS.","commit_id":"09a0acefc7d27b85e7145611a3852bcf0765f769"}],"requirements.txt":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"9924400f7e46f3006e8f99bc3df3c2f3a1ce2bd8","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"castellan\u003e\u003d0.3.1 # Apache-2.0"},{"line_number":56,"context_line":"cryptography\u003e\u003d1.0 # Apache-2.0"},{"line_number":57,"context_line":"debtcollector\u003e\u003d0.3.0 # Apache-2.0"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"# timeutils"},{"line_number":60,"context_line":"iso8601\u003e\u003d0.1.9"}],"source_content_type":"text/plain","patch_set":4,"id":"3a7e1126_d243b640","line":57,"updated":"2015-12-20 16:16:40.000000000","message":"We\u0027ve (I have, at least) been very hesitant of adding debtcollector to Glance as it adds a, perhaps un-necessary, runtime dependency to the service. This means packages will have to add it to their packages and users will need to have it installed.\n\nThat said, I think I\u0027m OK with adding it and do it once and for all. We\u0027ll also need it in other areas.","commit_id":"09a0acefc7d27b85e7145611a3852bcf0765f769"}]}