)]}'
{"glance/api/v1/upload_utils.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"7894c0eae3c92af0bf5be76ab8f31af5dd8c8c65","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        msg \u003d (_(\"Failed to upload image data due to backend error: %s\")"},{"line_number":285,"context_line":"               % encodeutils.exception_to_unicode(e))"},{"line_number":286,"context_line":"        LOG.error(msg)"},{"line_number":287,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":288,"context_line":"    except Exception as e:"},{"line_number":289,"context_line":"        msg \u003d _(\"Failed to upload image %s\") % image_id"},{"line_number":290,"context_line":"        LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_4349d5cf","line":287,"updated":"2016-01-18 21:04:56.000000000","message":"Is 400 the right error to raise here? Did the user really send a malformed request?\n\nThis means we\u0027ll be returning 400 even when the backend has gone away (i.e: crashed). My worry is that the user may try to understand what\u0027s wrong with the request when there\u0027s nothing wrong with it.","commit_id":"d41d1cf963239f52f3a792b3e2ff27f2db183d0e"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"8bc86ff7959e638a2c055080f6cc26f4e7e333ef","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        msg \u003d (_(\"Failed to upload image data due to backend error: %s\")"},{"line_number":285,"context_line":"               % encodeutils.exception_to_unicode(e))"},{"line_number":286,"context_line":"        LOG.error(msg)"},{"line_number":287,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":288,"context_line":"    except Exception as e:"},{"line_number":289,"context_line":"        msg \u003d _(\"Failed to upload image %s\") % image_id"},{"line_number":290,"context_line":"        LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_c4ce2183","line":287,"in_reply_to":"ba63e191_4306b521","updated":"2016-01-19 03:11:37.000000000","message":"I have submitted a patch to enhance the error description some days ago:  https://review.openstack.org/#/c/261424/2\n\nOr another way is to add  more subclasses of BackendException.\nI\u0027m not sure which is better.","commit_id":"d41d1cf963239f52f3a792b3e2ff27f2db183d0e"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"bd2758fba2c9e039ee6c7cd7a1c6e9be2943cde8","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        msg \u003d (_(\"Failed to upload image data due to backend error: %s\")"},{"line_number":285,"context_line":"               % encodeutils.exception_to_unicode(e))"},{"line_number":286,"context_line":"        LOG.error(msg)"},{"line_number":287,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":288,"context_line":"    except Exception as e:"},{"line_number":289,"context_line":"        msg \u003d _(\"Failed to upload image %s\") % image_id"},{"line_number":290,"context_line":"        LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba63e191_4306b521","line":287,"in_reply_to":"ba63e191_4349d5cf","updated":"2016-01-18 21:12:24.000000000","message":"I agree. I don\u0027t believe that BadRequest is always going to be the right exception here.\n\nPerhaps we need more subclasses of BackendException so we can signal appropriately from the backend what the problem is to glance. Then we can return different error codes based on those exceptions (with this block being a fallback prior to falling back to Exception)","commit_id":"d41d1cf963239f52f3a792b3e2ff27f2db183d0e"}],"glance/api/v2/images.py":[{"author":{"_account_id":16658,"name":"Darja Shakhray","email":"damalyavkina@gmail.com","username":"dshakhray"},"change_message_id":"0d3a3818cc6247022942ab550be32dec7c9454e4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":153,"context_line":"        except (exception.Invalid, exception.BadStoreUri) as e:"},{"line_number":154,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":155,"context_line":"        except glance_store.BackendException as e:"},{"line_number":156,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dsix.text_type(e))"},{"line_number":157,"context_line":"        except exception.Forbidden as e:"},{"line_number":158,"context_line":"            LOG.debug(\"User not permitted to update image \u0027%s\u0027\", image_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_7f75a561","line":155,"range":{"start_line":155,"start_character":15,"end_line":155,"end_character":44},"updated":"2015-12-22 09:52:55.000000000","message":"I think it\u0027s better to merge with line 153","commit_id":"916ff0521d380276baae30f22b6d382f95f0c3bc"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2188aea09ff276aef36716e26473a45d25d8ebf6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003de.msg)"},{"line_number":153,"context_line":"        except (exception.Invalid, exception.BadStoreUri) as e:"},{"line_number":154,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003de.msg)"},{"line_number":155,"context_line":"        except glance_store.BackendException as e:"},{"line_number":156,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dsix.text_type(e))"},{"line_number":157,"context_line":"        except exception.Forbidden as e:"},{"line_number":158,"context_line":"            LOG.debug(\"User not permitted to update image \u0027%s\u0027\", image_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_e507c3c7","line":155,"range":{"start_line":155,"start_character":15,"end_line":155,"end_character":44},"in_reply_to":"3a7e1126_7f75a561","updated":"2015-12-22 11:39:18.000000000","message":"Done","commit_id":"916ff0521d380276baae30f22b6d382f95f0c3bc"}]}