)]}'
{"doc/source/conf.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"fbad328660ecf03a51df91912c924aba77f4b0b4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"# using the given strftime format."},{"line_number":194,"context_line":"#html_last_updated_fmt \u003d \u0027%b %d, %Y\u0027"},{"line_number":195,"context_line":"git_cmd \u003d \"git log --pretty\u003dformat:\u0027%ad, commit %h\u0027 --date\u003dlocal -n1\""},{"line_number":196,"context_line":"html_last_updated_fmt \u003d subprocess.Popen(git_cmd , \\"},{"line_number":197,"context_line":"                        stdout\u003dsubprocess.PIPE,).communicate()[0]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# If true, SmartyPants will be used to convert quotes and dashes to"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f01c5879","line":196,"range":{"start_line":196,"start_character":51,"end_line":196,"end_character":52},"updated":"2015-12-29 17:06:35.000000000","message":"You do not need the \\ and this needs to be rewritten as\n\n    html_last_updated_fmt \u003d subprocess.Popen(git_cmd,\n                                             stdout\u003dsubprocess.PIPE).communicate()[0]\n\nNote there\u0027s no space before the , and no extra , after PIPE.","commit_id":"14b4a42281ea63ca15a7223e71d34616269f1087"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"779222c01be0f0a2e94248fb1edc94bc6767a028","unresolved":false,"context_lines":[{"line_number":194,"context_line":"#html_last_updated_fmt \u003d \u0027%b %d, %Y\u0027"},{"line_number":195,"context_line":"git_cmd \u003d \"git log --pretty\u003dformat:\u0027%ad, commit %h\u0027 --date\u003dlocal -n1\""},{"line_number":196,"context_line":"html_last_updated_fmt \u003d subprocess.Popen(git_cmd,"},{"line_number":197,"context_line":"                        stdout\u003dsubprocess.PIPE).communicate()[0]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# If true, SmartyPants will be used to convert quotes and dashes to"},{"line_number":200,"context_line":"# typographically correct entities."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_53544e53","line":197,"range":{"start_line":197,"start_character":24,"end_line":197,"end_character":47},"updated":"2015-12-29 17:32:06.000000000","message":"This is still going to fail the gate tests. As I showed in my comment the \u0027s\u0027 in \u0027stdout\u0027 needs to be aligned under the \u0027g\u0027 in \u0027git_cmd\u0027.\n\nIf you run `tox -e pep8` locally you\u0027ll see that.","commit_id":"0d81bee6103e05b1f3b2dd61de50e2c24898faa2"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"1f8ec32a15a5c7a863d5bcd73e5456fcec0ded76","unresolved":false,"context_lines":[{"line_number":193,"context_line":"# using the given strftime format."},{"line_number":194,"context_line":"#html_last_updated_fmt \u003d \u0027%b %d, %Y\u0027"},{"line_number":195,"context_line":"git_cmd \u003d \"git log --pretty\u003dformat:\u0027%ad, commit %h\u0027 --date\u003dlocal -n1\""},{"line_number":196,"context_line":"html_last_updated_fmt \u003d subprocess.Popen(git_cmd,"},{"line_number":197,"context_line":"                                         stdout\u003dsubprocess.PIPE).communicate()[0]"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"# If true, SmartyPants will be used to convert quotes and dashes to"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa69d971_94e4e90d","line":196,"range":{"start_line":196,"start_character":41,"end_line":196,"end_character":48},"updated":"2015-12-29 22:01:15.000000000","message":"Popen takes a list, not a string. I tested out the following change to this patchset locally and this worked:\n\n    -git_cmd \u003d \"git log --pretty\u003dformat:\u0027%ad, commit %h\u0027 --date\u003dlocal -n1\"\n    +git_cmd \u003d [\"git\", \"log\", \"--pretty\u003dformat:\u0027%ad, commit %h\u0027\", \"--date\u003dlocal\",\n+           \"-n1\"]","commit_id":"82011152a7dcc477e976c2592b6c8fa73e77e489"}]}