)]}'
{"glance/tests/unit/test_artifact_type_definition_framework.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"567ccd4163a015143f6c05979ca30bf679f51a17","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        tt \u003d TestType(address\u003d[\"Hope Street\", 1234, True])"},{"line_number":397,"context_line":"        self.assertEqual(\"Hope Street\", tt.address[0])"},{"line_number":398,"context_line":"        self.assertEqual(1234, tt.address[1])"},{"line_number":399,"context_line":"        self.assertTrue(tt.address[2])"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        # On Python 3, sort() fails because int (1) and string (\"20\") are not"},{"line_number":402,"context_line":"        # comparable"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_65d69229","line":399,"updated":"2016-01-06 15:25:04.000000000","message":"Something to think about, because this change isn\u0027t equivalent to the old test.  It looks to me like we\u0027re checking to make sure that the 3rd element is actually a boolean.  assertTrue just tells you that for argument x, bool(x) is True.  That\u0027s not a strong enough condition if we care about the type what\u0027s being checked.  We may actually want assertEquals(True,x) here.","commit_id":"2193167191c19a793e95272761ea87d895f7fbec"}]}