)]}'
{"glance/async/flows/base_import.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"56dc0d29916cd67528f8a30682d6840e00ec9019","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # NOTE(flaper87): If something goes wrong with the load of"},{"line_number":460,"context_line":"        # import tasks, make sure we go on."},{"line_number":461,"context_line":"        msg \u003d (_LE(\u0027Bad task configuration: %(exc)s\u0027) % {\u0027exc\u0027: exc.message})"},{"line_number":462,"context_line":"        LOG.exception(msg)"},{"line_number":463,"context_line":"        flow.add(import_to_store)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    flow.add("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_62290c37","line":462,"updated":"2016-01-08 18:06:39.000000000","message":"There\u0027s been a recent discussion on the mailing list about LOG.error vs LOG.exception. Should we instead be using LOG.error here since we\u0027re not expecting LOG.exception to format the raw exception for us?","commit_id":"f6374b7f547e051ecca4f04d16bbd25912c32dc2"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"48ce870c5ef2e0a9b4e35cac27d4b821aeb9398a","unresolved":false,"context_lines":[{"line_number":458,"context_line":"    except exception.BadTaskConfiguration as exc:"},{"line_number":459,"context_line":"        # NOTE(flaper87): If something goes wrong with the load of"},{"line_number":460,"context_line":"        # import tasks, make sure we go on."},{"line_number":461,"context_line":"        msg \u003d (_LE(\u0027Bad task configuration: %(exc)s\u0027) % {\u0027exc\u0027: exc.message})"},{"line_number":462,"context_line":"        LOG.error(msg)"},{"line_number":463,"context_line":"        flow.add(import_to_store)"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_16d6284f","line":461,"range":{"start_line":461,"start_character":8,"end_line":461,"end_character":11},"updated":"2016-01-11 10:45:40.000000000","message":"Do we need to convert this to unicode explicitly?\nSee more info here: http://docs.openstack.org/developer/oslo.log/usage.html#no-more-implicit-conversion-to-unicode-str","commit_id":"a56ec15e108b9551b74accc462ad5e63859a9a07"},{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"48ce870c5ef2e0a9b4e35cac27d4b821aeb9398a","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # NOTE(flaper87): If something goes wrong with the load of"},{"line_number":460,"context_line":"        # import tasks, make sure we go on."},{"line_number":461,"context_line":"        msg \u003d (_LE(\u0027Bad task configuration: %(exc)s\u0027) % {\u0027exc\u0027: exc.message})"},{"line_number":462,"context_line":"        LOG.error(msg)"},{"line_number":463,"context_line":"        flow.add(import_to_store)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    flow.add("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_d6b5f0ec","line":462,"updated":"2016-01-11 10:45:40.000000000","message":"Do we need to do the following:\nLOG.error(_LE(\u0027Bad task configuration: %s\u0027), exc.message) \nand let the logger to decide if it needs to parse arguments and prepare the string?\nLOG.warn and LOG.info follow this way so we can also update LOG.error.","commit_id":"a56ec15e108b9551b74accc462ad5e63859a9a07"}]}