)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"af589d99dc6778c816b4138fa67801efa6e866ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Percoco \u003cflaper87@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-08 16:51:54 -0430"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make the task\u0027s API admin only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of the new image import refactor, we\u0027re moving the task API to"},{"line_number":10,"context_line":"be admin only as it is entering a deprecation path."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_87f6558d","line":7,"range":{"start_line":7,"start_character":26,"end_line":7,"end_character":30},"updated":"2016-01-11 14:55:17.000000000","message":"Maybe a little pedantic, but should we say \u0027admin only by default\u0027?","commit_id":"65864fb8a4bec1bd8f582c19627fdbfc2dbfb936"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"af589d99dc6778c816b4138fa67801efa6e866ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the task\u0027s API admin only"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of the new image import refactor, we\u0027re moving the task API to"},{"line_number":10,"context_line":"be admin only as it is entering a deprecation path."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I28cb69ea730ae58b9aed1dd43b68305dbbf132c1"},{"line_number":13,"context_line":"Closes-bug: #1527716"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_623b0fd2","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":51},"updated":"2016-01-11 14:55:17.000000000","message":"(Not important) but I actually like the text in the bug which explains the link between tasks being deprecated and the image refactor. If you\u0027re pushing up another patch maybe consider adding it here.","commit_id":"65864fb8a4bec1bd8f582c19627fdbfc2dbfb936"}],"glance/api/v2/tasks.py":[{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"af589d99dc6778c816b4138fa67801efa6e866ce","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"_DEPRECATION_MESSAGE \u003d (\"The task API is being deprecated and \""},{"line_number":47,"context_line":"                        \"it\u0027ll be superseded by the new image import \""},{"line_number":48,"context_line":"                        \"process. Please, refer to this link for more \""},{"line_number":49,"context_line":"                        \"information about the aforementioned process: \""},{"line_number":50,"context_line":"                        \"https://specs.openstack.org/openstack/glance-specs/\""},{"line_number":51,"context_line":"                        \"specs/mitaka/approved/image-import/\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_6269cfbd","line":48,"range":{"start_line":48,"start_character":25,"end_line":48,"end_character":32},"updated":"2016-01-11 14:55:17.000000000","message":"process or API?","commit_id":"65864fb8a4bec1bd8f582c19627fdbfc2dbfb936"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"205a4be69b967a7f2f817739401c0cb024c69d96","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF.import_opt(\u0027task_time_to_live\u0027, \u0027glance.common.config\u0027, group\u003d\u0027task\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"_DEPRECATION_MESSAGE \u003d (\"The task API is being deprecated and \""},{"line_number":47,"context_line":"                        \"it\u0027ll be superseded by the new image import \""},{"line_number":48,"context_line":"                        \"API. Please, refer to this link for more \""},{"line_number":49,"context_line":"                        \"information about the aforementioned process: \""},{"line_number":50,"context_line":"                        \"https://specs.openstack.org/openstack/glance-specs/\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_17de8611","line":47,"range":{"start_line":47,"start_character":25,"end_line":47,"end_character":30},"updated":"2016-01-28 12:36:56.000000000","message":"nit: s/it\u0027ll/it will/\n(Sounds more forceful, like we really mean it!)","commit_id":"5e2972d7ef67aecf8902615ec6cb2942d7254950"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"205a4be69b967a7f2f817739401c0cb024c69d96","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"_DEPRECATION_MESSAGE \u003d (\"The task API is being deprecated and \""},{"line_number":47,"context_line":"                        \"it\u0027ll be superseded by the new image import \""},{"line_number":48,"context_line":"                        \"API. Please, refer to this link for more \""},{"line_number":49,"context_line":"                        \"information about the aforementioned process: \""},{"line_number":50,"context_line":"                        \"https://specs.openstack.org/openstack/glance-specs/\""},{"line_number":51,"context_line":"                        \"specs/mitaka/approved/image-import/\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_f7eacaab","line":48,"range":{"start_line":48,"start_character":36,"end_line":48,"end_character":37},"updated":"2016-01-28 12:36:56.000000000","message":"nit: don\u0027t think you need this comma","commit_id":"5e2972d7ef67aecf8902615ec6cb2942d7254950"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3436e38bc8987701d61b79cf0e457399357c8cfb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"CONF.import_opt(\u0027task_time_to_live\u0027, \u0027glance.common.config\u0027, group\u003d\u0027task\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"_DEPRECATION_MESSAGE \u003d (\"The task API is being deprecated and \""},{"line_number":47,"context_line":"                        \"it ll be superseded by the new image import \""},{"line_number":48,"context_line":"                        \"API. Please refer to this link for more \""},{"line_number":49,"context_line":"                        \"information about the aforementioned process: \""},{"line_number":50,"context_line":"                        \"https://specs.openstack.org/openstack/glance-specs/\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a5de9d1_9d14d744","line":47,"range":{"start_line":47,"start_character":25,"end_line":47,"end_character":30},"updated":"2016-01-28 13:02:28.000000000","message":"You dropped the \"\u0027\" but forgot to add the \"wi\" for \"will\" (sorry I brought it up in the first place!)","commit_id":"e17f4fffc4b3bb85e52c031baf9ceaa4c345d808"}],"releasenotes/notes/make-task-api-admin-only-by-default-7def996262e18f7a.yaml":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"cc22c4e98072876c552710b3f97f31f7f6a21182","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The task API was added to allow users for uploading images"},{"line_number":4,"context_line":"    asynchronously and for deployers to have more control in the"},{"line_number":5,"context_line":"    upload process. Unfortunately, this API has not worked the way it"},{"line_number":6,"context_line":"    was expected. Therefore, the task API is has entered a deprecation"},{"line_number":7,"context_line":"    period and is meant to be replaced by the new import API."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_2bc79d13","line":5,"range":{"start_line":5,"start_character":20,"end_line":5,"end_character":33},"updated":"2016-01-18 13:57:31.000000000","message":"\"to allow someone to do something\"","commit_id":"53e0897a79692c68432ff7f6a14c72a07c5aae8e"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"cc22c4e98072876c552710b3f97f31f7f6a21182","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    The task API was added to allow users for uploading images"},{"line_number":4,"context_line":"    asynchronously and for deployers to have more control in the"},{"line_number":5,"context_line":"    upload process. Unfortunately, this API has not worked the way it"},{"line_number":6,"context_line":"    was expected. Therefore, the task API is has entered a deprecation"},{"line_number":7,"context_line":"    period and is meant to be replaced by the new import API."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    This change makes the task API admin only by default so that it is"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da6ed579_ebd0a5cb","line":6,"range":{"start_line":6,"start_character":33,"end_line":6,"end_character":37},"updated":"2016-01-18 13:57:31.000000000","message":"s/is has/has/","commit_id":"53e0897a79692c68432ff7f6a14c72a07c5aae8e"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8fd5eff280de5947c5c19b0ddcc580a391cfbfdd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The task API was added to allow users for uploading images"},{"line_number":4,"context_line":"    asynchronously and for deployers to have more control in the"},{"line_number":5,"context_line":"    upload process. Unfortunately, this API has not worked the way it"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a68dd71_772e4efc","line":2,"updated":"2016-01-25 10:44:24.000000000","message":"Looking the release notes Sabari pointed out, this might be more appropriate to be in the deprecation section.","commit_id":"0d6e188fcaa478aac38e89dd154f011f6ecdaf30"},{"author":{"_account_id":7575,"name":"Sabari","email":"smurugesan@vmware.com","username":"sabari"},"change_message_id":"c3949f3f3bde0211139316266ee4f4ae7dabbf53","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    This change makes the task API admin only by default so that it is"},{"line_number":10,"context_line":"    not accidentally deployed as a public API."},{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - No changes are required unless the old policy file is replaced"},{"line_number":13,"context_line":"    with the new one containing the changes in this patch. If this is"},{"line_number":14,"context_line":"    done, then the deployer willing to have this API as a public"},{"line_number":15,"context_line":"    endpoint will have to change the `policy.json` file and remove"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a68dd71_462f0388","line":12,"updated":"2016-01-23 10:12:33.000000000","message":"Nit: This becomes out-of-context in the release note\u0027s upgrade section. You may want to repeat the last two lines from above.\n\nRef:- http://docs-draft.openstack.org/48/265448/5/check/gate-glance-releasenotes/a1a084b//releasenotes/build/html/unreleased.html","commit_id":"0d6e188fcaa478aac38e89dd154f011f6ecdaf30"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8fd5eff280de5947c5c19b0ddcc580a391cfbfdd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"upgrade:"},{"line_number":12,"context_line":"  - No changes are required unless the old policy file is replaced"},{"line_number":13,"context_line":"    with the new one containing the changes in this patch. If this is"},{"line_number":14,"context_line":"    done, then the deployer willing to have this API as a public"},{"line_number":15,"context_line":"    endpoint will have to change the `policy.json` file and remove"},{"line_number":16,"context_line":"    `role:admin` from every `task` related field."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a68dd71_370bf67e","line":14,"updated":"2016-01-25 10:44:24.000000000","message":"s/this API/tasks API/ could help for the confusion as well.","commit_id":"0d6e188fcaa478aac38e89dd154f011f6ecdaf30"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"205a4be69b967a7f2f817739401c0cb024c69d96","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    import API. This change makes the task API admin only by default so that it"},{"line_number":8,"context_line":"    is not accidentally deployed as a public API."},{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - The task API is being deprecated and it\u0027s been made admin only. If deployers"},{"line_number":11,"context_line":"    of Glance would like to have this API as a public one, it is necessary to"},{"line_number":12,"context_line":"    change the `policy.json` file and remove `role:admin` from every `task`"},{"line_number":13,"context_line":"    related field."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a5de9d1_371622a8","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":45},"updated":"2016-01-28 12:36:56.000000000","message":"nit: s/it\u0027s/has/","commit_id":"5e2972d7ef67aecf8902615ec6cb2942d7254950"}]}
